media: rc-core: simplify logging in rc_register_device

PATCH New Heiner Kallweit 1 participant 1 message Oct 29, 2015

Subsystems (2)

Media (V4L/DVB) RC-core / lirc framework

lore

Share & tools

lore

Heiner Kallweit

author

2015-10-29 21:39 UTC #0 lore raw

PATCH 1/1 media: rc-core: simplify logging in rc_register_device

Simplify the logging.

I had some doubts about using the elvis operator as it's GNU extension. However GNU extensions are explicitely allowed and this operator is used at several places in the kernel code.

Signed-off-by Heiner Kallweit <[email protected]>

---
 drivers/media/rc/rc-main.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

drivers/media/rc/rc-main.c +2 -4

index 3f0f71a..c47ed33 100644
@@ -1420,10 +1420,8 @@ int rc_register_device(struct rc_dev *dev)
 	dev->input_dev->rep[REP_PERIOD] = 125;
 
 	path = kobject_get_path(&dev->dev.kobj, GFP_KERNEL);
-	printk(KERN_INFO "%s: %s as %s\n",
-		dev_name(&dev->dev),
-		dev->input_name ? dev->input_name : "Unspecified device",
-		path ? path : "N/A");
+	dev_info(&dev->dev, "%s as %s\n",
+		dev->input_name ?: "Unspecified device", path ?: "N/A");
 	kfree(path);
 
 	if (dev->driver_type == RC_DRIVER_IR_RAW) {

Signature · 1 line

2.6.2