Skip to contentSkip to conversation

remove env location override

PATCH New Jakob Riepler 3 participants 3 messages Jul 27, 2020 – Jul 28, 2020 Arm STM32

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 remove env location override

Overriding the environment location is not necessary as the defconfig for the relevant boards only enable SPI flash and nowhere sources which are in the same order per default but having this explicit override prevents using eMMC or SD card (or EXT4) as environment source.

---

 ?board/dhelectronics/dh_stm32mp1/board.c | 12 ------------

?1 file changed, 12 deletions(-)

(quoted diff) +0 -0

b/board/dhelectronics/dh_stm32mp1/board.c
index ae8d581d1c..17dbf20d76 100644

board/dhelectronics/dh_stm32mp1/board.c +0 -12
@@ -653,18 +653,6 @@ int board_interface_eth_init(struct udevice *dev,
 ???? return 0;
 ?}
 
-enum env_location env_get_location(enum env_operation op, int prio)
-{
-??? if (prio)
-??? ??? return ENVL_UNKNOWN;
-
-#ifdef CONFIG_ENV_IS_IN_SPI_FLASH
-??? return ENVL_SPI_FLASH;
-#else
-??? return ENVL_NOWHERE;
-#endif
-}
-
 ?#if defined(CONFIG_OF_BOARD_SETUP)
 ?int ft_board_setup(void *blob, struct bd_info *bd)
 ?{
Signature · 1 line
2.27.0
#1 lore raw

PATCH 1/1 remove env location override

Hi Jakob,

Quoted 10 lines

From: U-Boot <[email protected]> On Behalf Of Jakob Riepler
Sent: lundi 27 juillet 2020 14:18

Overriding the environment location is not necessary as the defconfig for the relevant boards only enable SPI flash and nowhere sources which are in the same order per default but having this explicit override prevents using eMMC or SD card (or EXT4) as environment source.

---

Thanks

Patrick

#2 lore raw

PATCH 1/1 remove env location override

Quoted 10 lines · Patrick DELAUNAY

Hi Jakob,

Quoted 8 lines

From: U-Boot <[email protected]> On Behalf Of Jakob Riepler
Sent: lundi 27 juillet 2020 14:18

Overriding the environment location is not necessary as the defconfig for the relevant boards only enable SPI flash and nowhere sources which are in the same order per default but having this explicit override prevents using eMMC or SD card (or EXT4) as environment source.

Quoted 7 lines
Quoted 2 lines

---

Thanks

Patrick

Applied to u-boot-stm/master

Thanks

Patrice