Skip to contentSkip to conversation

MIPS: BMIPS: Enable GZIP ramdisk and timed printks

DISCUSSION Andreas Ziegler 2 participants 2 messages Nov 12, 2015 MIPS

lore
Share & tools
lore

Andreas Ziegler

author
#0 lore raw

Hi Florian,

your patch "MIPS: BMIPS: Enable GZIP ramdisk and timed printks" showed up as commit fb9e5642aa9e in linux-next today (that is, next-20151112). I noticed it because we (a research group from Erlangen[0]) are running daily checks on linux-next.

Your commit adds two entries to arch/mips/configs/bmips_stb_defconfig, but one of them has a typo (line 37):

CONFIG_PRINK_TIME=y

which should instead say (notice the missing 'T'):

CONFIG_PRINTK_TIME=y

Not sure how this got two Reviewed-by's, as this simple mistake could have been easily spotted by running scripts/checkkconfigsymbols.py on the patch.

Regards,

Andreas

[0] https://cados.cs.fau.de
Original patchwork: https://patchwork.linux-mips.org/patch/11307/

#1 lore raw
Quoted 12 lines · Andreas Ziegler

Hi Florian,

your patch "MIPS: BMIPS: Enable GZIP ramdisk and timed printks" showed up as commit fb9e5642aa9e in linux-next today (that is, next-20151112). I noticed it because we (a research group from Erlangen[0]) are running daily checks on linux-next.

Your commit adds two entries to arch/mips/configs/bmips_stb_defconfig, but one of them has a typo (line 37):

CONFIG_PRINK_TIME=y

Quoted 7 lines

which should instead say (notice the missing 'T'):

CONFIG_PRINTK_TIME=y

Not sure how this got two Reviewed-by's, as this simple mistake could have been easily spotted by running scripts/checkkconfigsymbols.py on the patch.

Sigh, fixed.

Ralf