adv7511: fix incorrect bit offset

PATCH Hans Verkuil 1 participant 1 message Nov 12, 2015

Subsystems (2)

Media (V4L/DVB) Analog devices inc ADV7511 driver

lore

Share & tools

lore

Hans Verkuil

author

2015-11-12 15:30 UTC #0 lore raw

The quantization bits are in bits 7-6, not 7-4, so shift by 6 instead of 4.

This bug is caused by a typo in the adv7511 datasheet.

Signed-off-by Hans Verkuil <[email protected]>

drivers/media/i2c/adv7511.c +1 -1

index e4900df..b8de64c 100644
@@ -1116,7 +1116,7 @@ static int adv7511_set_fmt(struct v4l2_subdev *sd,
 	adv7511_wr_and_or(sd, 0x55, 0x9f, y << 5);
 	adv7511_wr_and_or(sd, 0x56, 0x3f, c << 6);
 	adv7511_wr_and_or(sd, 0x57, 0x83, (ec << 4) | (q << 2));
-	adv7511_wr_and_or(sd, 0x59, 0x0f, yq << 4);
+	adv7511_wr_and_or(sd, 0x59, 0x3f, yq << 6);
 	adv7511_wr_and_or(sd, 0x4a, 0xff, 1);
 
 	return 0;