Skip to contentSkip to conversation

v4l2-pci-skeleton.c: forgot to update v4l2_match_dv_timings call

PATCH New Hans Verkuil 2 participants 2 messages Nov 13, 2015

Subsystems (2)
Documentation Media (V4L/DVB)
lore
Share & tools
lore

Hans Verkuil

author
#0 lore raw

PATCH 1/1 v4l2-pci-skeleton.c: forgot to update v4l2_match_dv_timings call

Add missing new argument to v4l2_match_dv_timings() in this skeleton driver.

Signed-off-by Hans Verkuil <[email protected]>
Documentation/video4linux/v4l2-pci-skeleton.c +1 -1
index 95ae828..1c8b102 100644
@@ -509,7 +509,7 @@ static int skeleton_s_dv_timings(struct file *file, void *_fh,
 		return -EINVAL;
 
 	/* Return 0 if the new timings are the same as the current timings. */
-	if (v4l2_match_dv_timings(timings, &skel->timings, 0))
+	if (v4l2_match_dv_timings(timings, &skel->timings, 0, false))
 		return 0;
 
 	/*
build bot
#1 lore raw
reproduce:

Hi Hans,

[auto build test ERROR on v4.3-rc7]
[also build test ERROR on next-20151113]

url:    https://github.com/0day-ci/linux/commits/Hans-Verkuil/v4l2-pci-skeleton-c-forgot-to-update-v4l2_match_dv_timings-call/20151113-220325
config: i386-randconfig-s0-201545 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386

All errors (new ones prefixed by >>):

Documentation/video4linux/v4l2-pci-skeleton.c: In function 'skeleton_s_dv_timings':

>> Documentation/video4linux/v4l2-pci-skeleton.c:510:6: error: too many arguments to function 'v4l2_match_dv_timings'
     if (v4l2_match_dv_timings(timings, &skel->timings, 0, false))
         ^

In file included from Documentation/video4linux/v4l2-pci-skeleton.c:37:0:
include/media/v4l2-dv-timings.h:113:6: note: declared here
bool v4l2_match_dv_timings(const struct v4l2_dv_timings *measured,
^

vim +/v4l2_match_dv_timings +510 Documentation/video4linux/v4l2-pci-skeleton.c

504 /* Check if the timings are part of the CEA-861 timings. */
505 if (!v4l2_find_dv_timings_cap(timings, &skel_timings_cap,
506 0, NULL, NULL))
507 return -EINVAL;
508
509 /* Return 0 if the new timings are the same as the current timings. */

 > 510		if (v4l2_match_dv_timings(timings, &skel->timings, 0, false))

511 return 0;
512
513 /*

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation