Skip to contentSkip to conversation

arm64 sched_clock cpu accounting

DISCUSSION Mario Smarduch 3 participants 7 messages Nov 18, 2015 – Dec 3, 2015 KVM arm64

lore
Share & tools
lore
#0 lore raw

Hello,
I noticed sched clock accounting can be enabled when arch-timer is
initialized. But arm64 doesn't appear to have 'HAVE_IRQ_TIME_ACCOUNTING' selected (as of mainline 4.4-rc1) and IRQ_TIME_ACCOUNTING can't be selected. After adding it to arch/arm64/Kconfig, option appears to work fine. Depending on need all accounting options are fine, but irq time accounting appears to be most preferable.

Any thoughts? Is it fine to enable it?

Thanks,
Mario

#1 lore raw

Also with tick accounting enabled, and periodic timer HZ set to 1000 no irq time is reported. That's with running a ping flood - 1200 int/s, not sure why wouldn't any irq time be reported? The other two modes report irq time as expected.

Quoted 19 lines · Mario Smarduch

Hello,
I noticed sched clock accounting can be enabled when arch-timer is
initialized. But arm64 doesn't appear to have 'HAVE_IRQ_TIME_ACCOUNTING' selected (as of mainline 4.4-rc1) and IRQ_TIME_ACCOUNTING can't be selected. After adding it to arch/arm64/Kconfig, option appears to work fine. Depending on need all accounting options are fine, but irq time accounting appears to be most preferable.

Any thoughts? Is it fine to enable it?

Thanks,
Mario

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

#2 lore raw

Hi Mario,

Quoted 4 lines · Mario Smarduch

Also with tick accounting enabled, and periodic timer HZ set to 1000 no irq time is reported. That's with running a ping flood - 1200 int/s, not sure why wouldn't any irq time be reported? The other two modes report irq time as expected.

Quoted 11 lines
Quoted 10 lines · Mario Smarduch

Hello,
I noticed sched clock accounting can be enabled when arch-timer is
initialized. But arm64 doesn't appear to have 'HAVE_IRQ_TIME_ACCOUNTING' selected (as of mainline 4.4-rc1) and IRQ_TIME_ACCOUNTING can't be selected. After adding it to arch/arm64/Kconfig, option appears to work fine. Depending on need all accounting options are fine, but irq time accounting appears to be most preferable.

Any thoughts? Is it fine to enable it?

Is any of this related to KVM?

-Christoffer

#3 lore raw
Quoted 16 lines · Christoffer Dall

Hi Mario,

Quoted 13 lines · Mario Smarduch

Also with tick accounting enabled, and periodic timer HZ set to 1000 no irq time is reported. That's with running a ping flood - 1200 int/s, not sure why wouldn't any irq time be reported? The other two modes report irq time as expected.

Quoted 8 lines · Mario Smarduch

Hello,
I noticed sched clock accounting can be enabled when arch-timer is
initialized. But arm64 doesn't appear to have 'HAVE_IRQ_TIME_ACCOUNTING' selected (as of mainline 4.4-rc1) and IRQ_TIME_ACCOUNTING can't be selected. After adding it to arch/arm64/Kconfig, option appears to work fine. Depending on need all accounting options are fine, but irq time accounting appears to be most preferable.

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

Any thoughts? Is it fine to enable it?

Is any of this related to KVM?

Indirectly, given the guest should yield same results. To be on the safe side I ran the guest in all combinations (7) to confirm that's the case.

Also verified that guest time on host appears fine in all these configurations. It takes extra effort to get the guest time as opposed to other modes.

- Mario

Quoted 3 lines

-Christoffer

#4 lore raw
Quoted 17 lines · Mario Smarduch
Quoted 16 lines · Christoffer Dall
Quoted 15 lines · Mario Smarduch

Also with tick accounting enabled, and periodic timer HZ set to 1000 no irq time is reported. That's with running a ping flood - 1200 int/s, not sure why wouldn't any irq time be reported? The other two modes report irq time as expected.

Quoted 10 lines · Mario Smarduch

Hello,
I noticed sched clock accounting can be enabled when arch-timer is
initialized. But arm64 doesn't appear to have 'HAVE_IRQ_TIME_ACCOUNTING' selected (as of mainline 4.4-rc1) and IRQ_TIME_ACCOUNTING can't be selected. After adding it to arch/arm64/Kconfig, option appears to work fine. Depending on need all accounting options are fine, but irq time accounting appears to be most preferable.

Any thoughts? Is it fine to enable it?

Quoted 7 lines
Quoted 1 line

Is any of this related to KVM?

Indirectly, given the guest should yield same results. To be on the safe side I ran the guest in all combinations (7) to confirm that's the case.

Also verified that guest time on host appears fine in all these configurations. It takes extra effort to get the guest time as opposed to other modes.

I can take this via the arm64 tree (where it's queued, but I've not pushed anything yet).

Will

#5 lore raw
Quoted 23 lines · Will Deacon
Quoted 22 lines · Mario Smarduch
Quoted 14 lines · Christoffer Dall
Quoted 13 lines · Mario Smarduch

Also with tick accounting enabled, and periodic timer HZ set to 1000 no irq time is reported. That's with running a ping flood - 1200 int/s, not sure why wouldn't any irq time be reported? The other two modes report irq time as expected.

Quoted 8 lines · Mario Smarduch

Hello,
I noticed sched clock accounting can be enabled when arch-timer is
initialized. But arm64 doesn't appear to have 'HAVE_IRQ_TIME_ACCOUNTING' selected (as of mainline 4.4-rc1) and IRQ_TIME_ACCOUNTING can't be selected. After adding it to arch/arm64/Kconfig, option appears to work fine. Depending on need all accounting options are fine, but irq time accounting appears to be most preferable.

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

Any thoughts? Is it fine to enable it?

Is any of this related to KVM?

Indirectly, given the guest should yield same results. To be on the safe side I ran the guest in all combinations (7) to confirm that's the case.

Quoted 7 lines
Quoted 2 lines

Also verified that guest time on host appears fine in all these configurations. It takes extra effort to get the guest time as opposed to other modes.

I can take this via the arm64 tree (where it's queued, but I've not pushed anything yet).

Will

Great thanks.

Quoted 1 line
#6 lore raw
In reply to Mario Smarduch

Hi Christoffer,

Quoted 29 lines · Mario Smarduch
Quoted 16 lines · Christoffer Dall

Hi Mario,

Quoted 13 lines · Mario Smarduch

Also with tick accounting enabled, and periodic timer HZ set to 1000 no irq time is reported. That's with running a ping flood - 1200 int/s, not sure why wouldn't any irq time be reported? The other two modes report irq time as expected.

Quoted 8 lines · Mario Smarduch

Hello,
I noticed sched clock accounting can be enabled when arch-timer is
initialized. But arm64 doesn't appear to have 'HAVE_IRQ_TIME_ACCOUNTING' selected (as of mainline 4.4-rc1) and IRQ_TIME_ACCOUNTING can't be selected. After adding it to arch/arm64/Kconfig, option appears to work fine. Depending on need all accounting options are fine, but irq time accounting appears to be most preferable.

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines

Any thoughts? Is it fine to enable it?

Is any of this related to KVM?

Indirectly, given the guest should yield same results. To be on the safe side I ran the guest in all combinations (7) to confirm that's the case.

Also verified that guest time on host appears fine in all these configurations. It takes extra effort to get the guest time as opposed to other modes.

Quoted 9 lines

- Mario

Quoted 3 lines

-Christoffer

_______________________________________________
kvmarm mailing list
[email protected]
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

While on this topic, one use case for RT like apps is run the host in full sched clock accounting mode/NO_HZ_FULL and guest in IRQ time accounting mode/NO_HZ_IDLE.

This should make sense for a control plane, gateway guest (using normal IP stack, timers, ..) there you have a lot of transitions between run modes. ANd irq, softirq accounting matters.

The host on the other side should be fine running a vCPU in full sched clock mode, you don't expect to many transitions from the vCPU, and less need for irq/softirq accounting if any.

I recall you raised the point of run modes when you fixed guest time accounting, but I didn't have a good use case back then for your question.

- Mario.