Skip to contentSkip to conversation

242: remove open-coded check for "zero" command

PATCH Superseded Eric Sandeen 2 participants 3 messages Dec 4, 2015 – Dec 11, 2015

lore
Share & tools
lore

Eric Sandeen

author
#0 lore raw

PATCH 1/1 242: remove open-coded check for "zero" command

We have helpers for this, no need to open-code it.

Signed-off-by Eric Sandeen <[email protected]>

---

tests/xfs/242 +1 -8
index 304e69f..4e1a8b4 100755
@@ -47,14 +47,7 @@ _supported_fs xfs
 _supported_os Linux
 _require_test
 
-_test_io_zero()
-{
-	$XFS_IO_PROG -c "zero help" 2>&1 | \
-			grep 'command "zero" not found' > /dev/null
-	echo $?
-}
-
-[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
+_require_xfs_io_command "zero"
 
 testfile=$TEST_DIR/242.$$
author
#1 lore raw

PATCH v2 1/1 xfs/242: remove open-coded check for "zero" command

We have helpers for this, no need to open-code it.

Signed-off-by Eric Sandeen <[email protected]>

---

v2: clarify subject w/ "xfs/242"

tests/xfs/242 +1 -8
index 304e69f..4e1a8b4 100755
@@ -47,14 +47,7 @@ _supported_fs xfs
 _supported_os Linux
 _require_test
 
-_test_io_zero()
-{
-	$XFS_IO_PROG -c "zero help" 2>&1 | \
-			grep 'command "zero" not found' > /dev/null
-	echo $?
-}
-
-[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
+_require_xfs_io_command "zero"
 
 testfile=$TEST_DIR/242.$$
Reviewed-by on v2 1/1
#2 lore raw

Re: [PATCH V2] xfs/242: remove open-coded check for "zero" command

Quoted 3 lines · Eric Sandeen

We have helpers for this, no need to open-code it.

Signed-off-by Eric Sandeen <[email protected]>
Reviewed-by Eryu Guan <[email protected]>
Quoted 30 lines

---

v2: clarify subject w/ "xfs/242"

tests/xfs/242 +1 -9
index 304e69f..4e1a8b4 100755
@@ -47,14 +47,7 @@ _supported_fs xfs
 _supported_os Linux
 _require_test
 
-_test_io_zero()
-{
-	$XFS_IO_PROG -c "zero help" 2>&1 | \
-			grep 'command "zero" not found' > /dev/null
-	echo $?
-}
-
-[ $(_test_io_zero) -eq 0 ] && _notrun "zero command not supported"
+_require_xfs_io_command "zero"
 
 testfile=$TEST_DIR/242.$$
 
 
 
--

To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html