Skip to contentSkip to conversation

xfs/293: tighten up checks for documented xfs_io commands

PATCH In review Eric Sandeen 2 participants 2 messages Dec 4, 2015 – Dec 11, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs/293: tighten up checks for documented xfs_io commands

Some commands (like "zero") are simple words which commonly occur in the manpage text even if they aren't documented as commands.

Grep for " $COMMAND" instead of the bare word, because
the documented commands show up as indented.

This reveals that the "zero" command is not documented yet. (It catches "help" too, because it's documented differently; I'll fix that up in the manpage when I add "zero").

---

tests/xfs/293 +1 -1
index d1a2853..ade6015 100755
@@ -49,7 +49,7 @@ _supported_os IRIX Linux
 echo "Silence is golden"
 
 for COMMAND in `$XFS_IO_PROG -c help | awk '{print $1}' | grep -v "^Use"`; do
-  man xfs_io | col -b | grep -wq $COMMAND || \
+  man xfs_io | col -b | grep -wq "   $COMMAND" || \
 	echo "$COMMAND not documented in the xfs_io manpage"
 done
 
Reviewed-by on v1 1/1
#1 lore raw
Quoted 4 lines · Eric Sandeen

Some commands (like "zero") are simple words which commonly occur in the manpage text even if they aren't documented as commands.

Quoted 8 lines

Grep for " $COMMAND" instead of the bare word, because
the documented commands show up as indented.

This reveals that the "zero" command is not documented yet. (It catches "help" too, because it's documented differently; I'll fix that up in the manpage when I add "zero").

Quoted 19 lines

---

tests/xfs/293 +1 -2
index d1a2853..ade6015 100755
@@ -49,7 +49,7 @@ _supported_os IRIX Linux
 echo "Silence is golden"
 
 for COMMAND in `$XFS_IO_PROG -c help | awk '{print $1}' | grep -v "^Use"`; do
-  man xfs_io | col -b | grep -wq $COMMAND || \
+  man xfs_io | col -b | grep -wq "   $COMMAND" || \
 	echo "$COMMAND not documented in the xfs_io manpage"
 done
 
--

To unsubscribe from this list: send the line "unsubscribe fstests" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html