Skip to contentSkip to conversation

Finding labelled statements with SmPL

Cocci SF Markus Elfring 2 participants 5 messages Dec 9, 2015

lore
Share & tools
lore
#0 lore raw

Hello,

I have tried another small SmPL script out.

@label_used@
identifier target, work;
type return_type;
@@
return_type work(...)
{
... when any
*target:
... when any
}

Test example:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/block/skd_main.c

elfring at Sonne:~/Projekte/Coccinelle/janitor> spatch.opt show_labels1.cocci ~/Projekte/Linux/next-patched/drivers/block/skd_main.c ?
@@ -778,7 +778,6 @@ static void skd_request_fn(struct reques

                        continue;
                }

-skip_sg:

                scsi_req->hdr.sg_list_len_bytes =
                        cpu_to_be32(skreq->sg_byte_count);

?
@@ -5114,10 +5094,8 @@ err_out_iounmap:

        if (skdev->pcie_error_reporting_is_enabled)
                pci_disable_pcie_error_reporting(pdev);

-err_out_regions:

        pci_release_regions(pdev);

-err_out:

        pci_disable_device(pdev);
        return rc;

}

It seems that only jump labels are found by the shown source code analysis approach so far.
http://en.cppreference.com/w/c/language/goto

Does an enumeration symbol like "SKD_IRQ_MSIX" fit to the properties of a C identifier?

I imagine that case labels could also be matched by such a simple search pattern.
http://en.cppreference.com/w/c/language/switch
http://c0x.coding-guidelines.com/6.8.1.html

@label_used@
expression label;
identifier work;
type return_type;
@@
return_type work(...)
{
... when any
*label:
... when any
}

elfring at Sonne:~/Projekte/Coccinelle/janitor> spatch.opt show_labels2.cocci ~/Projekte/Linux/next-patched/drivers/block/skd_main.c
init_defs_builtins: /usr/local/lib64/coccinelle/standard.h
115 116
Fatal error: exception Failure("minus: parse error: \n = File \"show_labels2.cocci\", line 9, column 6, charpos = 115\n around = ':', whole content = *label:\n")

Would you like to clarify these observations?

Regards,
Markus

#1 lore raw

A label has to be an identifier. A sequence of all capital letters is also an identifier.

julia

Quoted 83 lines · SF Markus Elfring

Hello,

I have tried another small SmPL script out.

@label_used@
identifier target, work;
type return_type;
@@
return_type work(...)
{
... when any
*target:
... when any
}

Test example:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/block/skd_main.c

elfring at Sonne:~/Projekte/Coccinelle/janitor> spatch.opt show_labels1.cocci ~/Projekte/Linux/next-patched/drivers/block/skd_main.c ?

(quoted diff) +0 -1
@@ -778,7 +778,6 @@ static void skd_request_fn(struct reques
                        continue;
                }
 
-skip_sg:
                scsi_req->hdr.sg_list_len_bytes =
                        cpu_to_be32(skreq->sg_byte_count);
 

?

(quoted diff) +0 -2
@@ -5114,10 +5094,8 @@ err_out_iounmap:
        if (skdev->pcie_error_reporting_is_enabled)
                pci_disable_pcie_error_reporting(pdev);
 
-err_out_regions:
        pci_release_regions(pdev);
 
-err_out:
        pci_disable_device(pdev);
        return rc;
 }

It seems that only jump labels are found by the shown source code analysis approach so far.
http://en.cppreference.com/w/c/language/goto

Does an enumeration symbol like "SKD_IRQ_MSIX" fit to the properties of a C identifier?

I imagine that case labels could also be matched by such a simple search pattern.
http://en.cppreference.com/w/c/language/switch
http://c0x.coding-guidelines.com/6.8.1.html

@label_used@
expression label;
identifier work;
type return_type;
@@
return_type work(...)
{
... when any
*label:
... when any
}

elfring at Sonne:~/Projekte/Coccinelle/janitor> spatch.opt show_labels2.cocci ~/Projekte/Linux/next-patched/drivers/block/skd_main.c
init_defs_builtins: /usr/local/lib64/coccinelle/standard.h
115 116
Fatal error: exception Failure("minus: parse error: \n = File \"show_labels2.cocci\", line 9, column 6, charpos = 115\n around = ':', whole content = *label:\n")

Would you like to clarify these observations?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci at systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

#2 lore raw
Quoted 1 line

A label has to be an identifier.

This wording fits only to a jump label for the statement "goto", doesn't it?

Quoted 1 line

A sequence of all capital letters is also an identifier.

Does this feedback mean that the following SmPL approach should also work for case labels?

@label_used@
identifier label;
@@
*label:

How much do constant expressions matter in such a source code analysis?

Why did I get the message "minus: parse error"?

Regards,
Markus

#3 lore raw
Quoted 3 lines · SF Markus Elfring
Quoted 1 line

A label has to be an identifier.

This wording fits only to a jump label for the statement "goto", doesn't it?

The labels for switch have "case" in front of them. They won't be matched by a pattern like label:

Quoted 13 lines
Quoted 2 lines

A sequence of all capital letters is also an identifier.

Does this feedback mean that the following SmPL approach should also work for case labels?

@label_used@
identifier label;
@@
*label:

Quoted 3 lines

How much do constant expressions matter in such a source code analysis?

Why did I get the message "minus: parse error"?

Probably because a label by itself is not valid C code. It needs a statement after it.

julia

#4 lore raw
Quoted 2 lines

The labels for switch have "case" in front of them. They won't be matched by a pattern like label:

I would expect that the key word "case" can be optional because such source code should be matched by the specified SmPL ellipsis.

Regards,
Markus