Asymmetry in setting of "fileaddr" variable
Hello
In net/net.c::net_loop(), the variables "fileaddr" and "filesize" are both set in case of a successful transfer.
In fs/fs.c::do_load(), just the variable "filesize" is set in case of success.
Is this asymmetry intentional or a mistake?
Dave
PATCH 1/1 fs: handle the fileaddr variable in the same way as in the network case
--- fs/fs.c | 1 + 1 file changed, 1 insertion(+)
fs/fs.c +1 -0
@@ -427,6 +427,7 @@ int do_load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[], }puts ("\n" ); +setenv_hex ("fileaddr" , addr);setenv_hex ("filesize" , len_read);return 0 ;
Signature · 1 line
1.8.4
PATCH v2 1/1 fs: handle the fileaddr variable in the same way as in the network case
In reply to David Müller (ELSOFT AG)Signed-off-by David M?ller <[email protected]>
--- fs/fs.c | 1 + 1 file changed, 1 insertion(+)
fs/fs.c +1 -0
@@ -427,6 +427,7 @@ int do_load(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[], }puts ("\n" ); +setenv_hex ("fileaddr" , addr);setenv_hex ("filesize" , len_read);return 0 ;
Signature · 1 line
1.8.4
PATCH v2 1/1 fs: handle the fileaddr variable in the same way as in the network case
Quoted 1 line · David M?ller (ELSOFT AG)
Signed-off-by David M?ller <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160108/bac640bb/attachment.sig>