Skip to contentSkip to conversation

ASoC: ssm2518: Use a signed return type for ssm2518_lookup_mcs()

PATCH In review SF Markus Elfring 2 participants 2 messages Dec 20, 2015 – Dec 23, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: ssm2518: Use a signed return type for ssm2518_lookup_mcs()

From: Markus Elfring <[email protected]>
Date: Sun, 20 Dec 2015 10:34:25 +0100

The return type "unsigned int" was used by the ssm2518_lookup_mcs() function even though it will eventually return a negative error code. Improve this implementation detail by deletion of the type modifier then.

This issue was detected by using the Coccinelle software.

---
 sound/soc/codecs/ssm2518.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ssm2518.c +1 -1
index 86b81a6..e2e0bfa 100644
@@ -309,7 +309,7 @@ static const struct snd_pcm_hw_constraint_list ssm2518_constraints_12288000 = {
 	.count = ARRAY_SIZE(ssm2518_rates_12288000),
 };
 
-static unsigned int ssm2518_lookup_mcs(struct ssm2518 *ssm2518,
+static int ssm2518_lookup_mcs(struct ssm2518 *ssm2518,
 	unsigned int rate)
 {
 	const unsigned int *sysclks = NULL;
Signature · 1 line
2.6.3
maintainer
#1 lore raw

Applied "ASoC: ssm2518: Use a signed return type for ssm2518_lookup_mcs()" to the asoc tree

The patch

ASoC: ssm2518: Use a signed return type for ssm2518_lookup_mcs()

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From bfbcab7c2d8ab4cb52f0785d7381d20f39bb065b Mon Sep 17 00:00:00 2001

From: Markus Elfring <[email protected]>
Date: Sun, 20 Dec 2015 10:34:25 +0100
Subject: [PATCH] ASoC: ssm2518: Use a signed return type for
ssm2518_lookup_mcs()

The return type "unsigned int" was used by the ssm2518_lookup_mcs() function even though it will eventually return a negative error code. Improve this implementation detail by deletion of the type modifier then.

This issue was detected by using the Coccinelle software.

---
 sound/soc/codecs/ssm2518.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/ssm2518.c +1 -1
index 86b81a60ac52..e2e0bfa7ec20 100644
@@ -309,7 +309,7 @@ static const struct snd_pcm_hw_constraint_list ssm2518_constraints_12288000 = {
 	.count = ARRAY_SIZE(ssm2518_rates_12288000),
 };
 
-static unsigned int ssm2518_lookup_mcs(struct ssm2518 *ssm2518,
+static int ssm2518_lookup_mcs(struct ssm2518 *ssm2518,
 	unsigned int rate)
 {
 	const unsigned int *sysclks = NULL;
Signature · 1 line
2.6.2