Skip to contentSkip to conversation

mmc: enable mmc host device to suspend/resume asynchronously

PATCH In review Fu, Zhonghui 3 participants 5 messages Dec 28, 2015 – Jan 22, 2016 MMC, SD and SDIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mmc: enable mmc host device to suspend/resume asynchronously

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition dependency between devices. This patch enables mmc hosts to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed. After applying this patch and enabling all mmc hosts' child devices to suspend/resume asynchronously on ASUS T100TA, the system suspend-to-idle time is reduced from 1645ms to 1107ms, and the system resume time is reduced from 940ms to 914ms.

---
 drivers/mmc/core/host.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/core/host.c +1 -0
index da950c4..7222fd7 100644
@@ -339,6 +339,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
 	host->class_dev.parent = dev;
 	host->class_dev.class = &mmc_host_class;
 	device_initialize(&host->class_dev);
+	device_enable_async_suspend(&host->class_dev);
 
 	if (mmc_gpio_alloc(host)) {
 		put_device(&host->class_dev);

-- 1.7.1

Acked-by on v1 1/2
#1 lore raw

Looks good to me.

BR,
Venu

-----Original Message-----
From: Fu, Zhonghui [mailto:[email protected]]
Sent: Monday, December 28, 2015 9:09 PM
To: Ulf Hansson
Cc: Adrian Hunter; [email protected]; [email protected]; Venu Byravarasu; [email protected]; linux-mmc; [email protected]
Subject: [PATCH 1/2] mmc: enable mmc host device to suspend/resume asynchronously

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition dependency between devices. This patch enables mmc hosts to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed. After applying this patch and enabling all mmc hosts' child devices to suspend/resume asynchronously on ASUS T100TA, the system suspend-to-idle time is reduced from 1645ms to 1107ms, and the system resume time is reduced from 940ms to 914ms.

---
 drivers/mmc/core/host.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/core/host.c +1 -0
@@ -339,6 +339,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
 	host->class_dev.parent = dev;
 	host->class_dev.class = &mmc_host_class;
 	device_initialize(&host->class_dev);
+	device_enable_async_suspend(&host->class_dev);
 
 	if (mmc_gpio_alloc(host)) {
 		put_device(&host->class_dev);

-- 1.7.1

#2 lore raw
In reply to Fu, Zhonghui

Hi Ulf,

What do you think about this patch?

Thanks,
Zhonghui

Quoted 30 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition dependency between devices. This patch enables mmc hosts to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed. After applying this patch and enabling all mmc hosts' child devices to suspend/resume asynchronously on ASUS T100TA, the system suspend-to-idle time is reduced from 1645ms to 1107ms, and the system resume time is reduced from 940ms to 914ms.

---
 drivers/mmc/core/host.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/core/host.c +1 -1
index da950c4..7222fd7 100644
@@ -339,6 +339,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
 	host->class_dev.parent = dev;
 	host->class_dev.class = &mmc_host_class;
 	device_initialize(&host->class_dev);
+	device_enable_async_suspend(&host->class_dev);
 
 	if (mmc_gpio_alloc(host)) {
 		put_device(&host->class_dev);
-- 1.7.1
#3 lore raw
In reply to Fu, Zhonghui
Quoted 10 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition dependency between devices. This patch enables mmc hosts to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed. After applying this patch and enabling all mmc hosts' child devices to suspend/resume asynchronously on ASUS T100TA, the system suspend-to-idle time is reduced from 1645ms to 1107ms, and the system resume time is reduced from 940ms to 914ms.

Please update the change log as I don't think the above is really correct.

I think you can simplify the change log quite a bit and just mention what and why we want this change.

Quoted 12 lines
---
 drivers/mmc/core/host.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/core/host.c +0 -0
index da950c4..7222fd7 100644

drivers/mmc/core/host.c struct mmc_host *mmc_alloc_host(int extra, struct device *dev)

Quoted 8 lines
drivers/mmc/core/host.c +1 -1
@@ -339,6 +339,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
        host->class_dev.parent = dev;
        host->class_dev.class = &mmc_host_class;
        device_initialize(&host->class_dev);
+       device_enable_async_suspend(&host->class_dev);
 
        if (mmc_gpio_alloc(host)) {
                put_device(&host->class_dev);
-- 1.7.1

Otherwise I think this looks good!

Kind regards
Uffe

#4 lore raw
Quoted 11 lines · Ulf Hansson
Quoted 10 lines · Zhonghui

Now, PM core supports asynchronous suspend/resume mode for devices during system suspend/resume, and the power state transition of one device may be completed in separate kernel thread. PM core ensures all power state transition dependency between devices. This patch enables mmc hosts to suspend/resume asynchronously. This will take advantage of multicore and improve system suspend/resume speed. After applying this patch and enabling all mmc hosts' child devices to suspend/resume asynchronously on ASUS T100TA, the system suspend-to-idle time is reduced from 1645ms to 1107ms, and the system resume time is reduced from 940ms to 914ms.

Quoted 4 lines

Please update the change log as I don't think the above is really correct.

I think you can simplify the change log quite a bit and just mention what and why we want this change.

I have updated the change log according to your comments and resent this patch - "[PATCH 1/2 v2] mmc: enable mmc host device to suspend/resume asynchronously".

Thanks,
Zhonghui

Quoted 24 lines
Quoted 12 lines
---
 drivers/mmc/core/host.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/mmc/core/host.c +0 -0
index da950c4..7222fd7 100644

drivers/mmc/core/host.c struct mmc_host *mmc_alloc_host(int extra, struct device *dev)

Quoted 8 lines
drivers/mmc/core/host.c +1 -1
@@ -339,6 +339,7 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
        host->class_dev.parent = dev;
        host->class_dev.class = &mmc_host_class;
        device_initialize(&host->class_dev);
+       device_enable_async_suspend(&host->class_dev);
 
        if (mmc_gpio_alloc(host)) {
                put_device(&host->class_dev);
-- 1.7.1

Otherwise I think this looks good!

Kind regards
Uffe