Select on now-gone Kconfig option STOP_MACHINE

DISCUSSION Andreas Ziegler 2 participants 2 messages Jan 25, 2016

Share & tools

Andreas Ziegler

author

2016-01-25 10:52 UTC #0 lore raw

Hi Chris,

your commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access through GGTT on Braswell") added a select to STOP_MACHINE to the DRM_I915 Kconfig option.

In 4.5-rc1, your commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig dependency") then removed STOP_MACHINE entirely, but didn't delete the select from drivers/gpu/drm/i915/Kconfig.

Should I prepare a simple patch which removes the select?

Best regards,

Andreas

Chris Wilson

2016-01-25 10:59 UTC #1 lore raw

Quoted 11 lines · Andreas Ziegler

Hi Chris,
your commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access through GGTT on Braswell") added a select to STOP_MACHINE to the DRM_I915 Kconfig option.
In 4.5-rc1, your commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig dependency") then removed STOP_MACHINE entirely, but didn't delete the select from drivers/gpu/drm/i915/Kconfig.
Should I prepare a simple patch which removes the select?

Yes, it was intended to be removed on merging.
-Chris

Signature · 5 lines

Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx