Skip to contentSkip to conversation

megaraid_sas: add an i/o barrier

PATCH Applied Tomas Henzl 4 participants 5 messages Feb 1, 2016 – Feb 11, 2016

Subsystems (3)
Stable branch SCSI Megaraid SCSI/SAS drivers
lore
Share & tools
lore

Tomas Henzl

author
#0 lore raw

PATCH v2 1/1 megaraid_sas: add an i/o barrier

A barrier should be added to ensure proper
ordering of memory mapped writes.

V2: - added the barrier also to megasas_fire_cmd_skinny, as suggested by Kashyap Desai

Signed-off-by Tomas Henzl <[email protected]>
---
 drivers/scsi/megaraid/megaraid_sas_base.c   | 1 +
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
 2 files changed, 2 insertions(+)
drivers/scsi/megaraid/megaraid_sas_base.c +1 -0
index cc92c8198d..9f7689515c 100644
@@ -749,6 +749,7 @@ megasas_fire_cmd_skinny(struct megasas_instance *instance,
 	       &(regs)->inbound_high_queue_port);
 	writel((lower_32_bits(frame_phys_addr) | (frame_count<<1))|1,
 	       &(regs)->inbound_low_queue_port);
+	mmiowb();
 	spin_unlock_irqrestore(&instance->hba_lock, flags);
 }
drivers/scsi/megaraid/megaraid_sas_fusion.c +1 -0
index d9d0029fb1..98a848bdfd 100644
@@ -204,6 +204,7 @@ megasas_fire_cmd_fusion(struct megasas_instance *instance,
 		&instance->reg_set->inbound_low_queue_port);
 	writel(le32_to_cpu(req_desc->u.high),
 		&instance->reg_set->inbound_high_queue_port);
+	mmiowb();
 	spin_unlock_irqrestore(&instance->hba_lock, flags);
 #endif
 }
Signature · 1 line
2.4.3
#1 lore raw
Quoted 11 lines · Tomas Henzl

A barrier should be added to ensure proper
ordering of memory mapped writes.

V2: - added the barrier also to megasas_fire_cmd_skinny, as suggested by Kashyap Desai

Signed-off-by Tomas Henzl <[email protected]>
---
 drivers/scsi/megaraid/megaraid_sas_base.c   | 1 +
 drivers/scsi/megaraid/megaraid_sas_fusion.c | 1 +
 2 files changed, 2 insertions(+)

<formletter>

This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly.

</formletter>

#2 lore raw
In reply to Tomas Henzl
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Tomas" == Tomas Henzl <[email protected]> writes:

Tomas> A barrier should be added to ensure proper ordering of memory Tomas> mapped writes.

Tomas> V2: - added the barrier also to megasas_fire_cmd_skinny, as Tomas> suggested by Kashyap Desai

Sumit, Kashyap: Please review this patch.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
maintainer Reviewed-by Acked-by
#3 lore raw
Quoted 8 lines

-----Original Message-----
From: Martin K. Petersen [mailto:[email protected]]
Sent: Wednesday, February 10, 2016 10:55 PM
To: Tomas Henzl
Cc: '[email protected]'; [email protected]; Desai, Kashyap; Uday Lingala; [email protected]
Subject: Re: [PATCH v2] megaraid_sas: add an i/o barrier

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Tomas" == Tomas Henzl <[email protected]> writes:

Tomas> A barrier should be added to ensure proper ordering of memory Tomas> mapped writes.

Tomas> V2: - added the barrier also to megasas_fire_cmd_skinny, as Tomas> suggested by Kashyap Desai

Reviewed-by Kashyap Desai <[email protected]>
Acked-by Kashyap Desai <[email protected]>
Quoted 5 lines

Sumit, Kashyap: Please review this patch.

--
Martin K. Petersen Oracle Linux Engineering

Applied
#4 lore raw
In reply to Tomas Henzl
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Tomas" == Tomas Henzl <[email protected]> writes:

Tomas> A barrier should be added to ensure proper ordering of memory Tomas> mapped writes.

Applied to 4.6/scsi-queue.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering