Skip to contentSkip to conversation

MAINTAINERS: trim the file triggers for ABI/API

PATCH In review Michael Kerrisk (man-pages) 4 participants 5 messages Feb 4, 2016 ABI/API

lore
Share & tools
lore

Michael Kerrisk (man-pages)

author
#0 lore raw

PATCH 1/1 MAINTAINERS: trim the file triggers for ABI/API

Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e was well intentioned (I even Acked it), but in practice it has mostly generated (a lot of) useless noise on linux-api as developers of drivers and implementers of other uninteresting changes run scripts/get-maintainers.pl and unthinkingly paste the results into their email clients. And that commit didn't really help catch the really important API changes (new system calls, new options to existing system calls, new pseudofile entries, and so on). So, trim the 'F:' triggers for the "ABI/API" entry in MAINTAINERS right back to the minimum.

Signed-off-by Michael Kerrisk <[email protected]>
---
 MAINTAINERS | 2 --
 1 file changed, 2 deletions(-)
MAINTAINERS +0 -2
index f678c37..56f7a4f 100644
@@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
 
 ABI/API
 L:     [email protected]
-F:     Documentation/ABI/
 F:     include/linux/syscalls.h
-F:     include/uapi/
 F:     kernel/sys_ni.c
 
 ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
Signature · 1 line
2.5.0
Acked-by on v1 1/1
#1 lore raw
Quoted 22 lines · Michael Kerrisk (man-pages)

Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e was well intentioned (I even Acked it), but in practice it has mostly generated (a lot of) useless noise on linux-api as developers of drivers and implementers of other uninteresting changes run scripts/get-maintainers.pl and unthinkingly paste the results into their email clients. And that commit didn't really help catch the really important API changes (new system calls, new options to existing system calls, new pseudofile entries, and so on). So, trim the 'F:' triggers for the "ABI/API" entry in MAINTAINERS right back to the minimum.

Signed-off-by Michael Kerrisk <[email protected]>
---
 MAINTAINERS | 2 --
 1 file changed, 2 deletions(-)
MAINTAINERS +0 -0
index f678c37..56f7a4f 100644

MAINTAINERS F: drivers/scsi/aacraid/ · line 229

Quoted 9 lines
MAINTAINERS +0 -2
@@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
 
 ABI/API
 L:     [email protected]
-F:     Documentation/ABI/
 F:     include/linux/syscalls.h
-F:     include/uapi/
 F:     kernel/sys_ni.c
 
 ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
Acked-by Shuah khan <[email protected]>

thanks,
-- Shuah

Signature · 5 lines
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
[email protected] | (970) 217-8978
#2 lore raw
In reply to Michael Kerrisk (man-pages)
Quoted 1 line · Michael Kerrisk (man-pages)

Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e

s/Tripplett/Triplett/

Quoted 9 lines

was well intentioned (I even Acked it), but in practice it has mostly generated (a lot of) useless noise on linux-api as developers of drivers and implementers of other uninteresting changes run scripts/get-maintainers.pl and unthinkingly paste the results into their email clients. And that commit didn't really help catch the really important API changes (new system calls, new options to existing system calls, new pseudofile entries, and so on). So, trim the 'F:' triggers for the "ABI/API" entry in MAINTAINERS right back to the minimum.

This change makes sense, but I don't think this commit message explains the specific changes to the file triggers. (Also, there's a convention for referencing past commits.) Might I suggest an alternate commit message?

"""
Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI changes") added file triggers for various paths that likely indicated API/ABI changes. However, catching all changes in Documentation/ABI/ and include/uapi/ produces a large volume of mail to linux-api, rather than only API/ABI changes. Drop those two entries, but leave include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related changes.
"""

Quoted 21 lines
Signed-off-by Michael Kerrisk <[email protected]>
---
 MAINTAINERS | 2 --
 1 file changed, 2 deletions(-)
MAINTAINERS +0 -2
index f678c37..56f7a4f 100644
@@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
 
 ABI/API
 L:     [email protected]
-F:     Documentation/ABI/
 F:     include/linux/syscalls.h
-F:     include/uapi/
 F:     kernel/sys_ni.c
 
 ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
Signature · 1 line
2.5.0
author
#3 lore raw

Hi Josh,

Quoted 20 lines · Josh Triplett
Quoted 1 line · Michael Kerrisk (man-pages)

Josh Tripplett's commit ea8f8fc8631d9f890580a94d57a18bfeb827fa2e

s/Tripplett/Triplett/

Quoted 9 lines

was well intentioned (I even Acked it), but in practice it has mostly generated (a lot of) useless noise on linux-api as developers of drivers and implementers of other uninteresting changes run scripts/get-maintainers.pl and unthinkingly paste the results into their email clients. And that commit didn't really help catch the really important API changes (new system calls, new options to existing system calls, new pseudofile entries, and so on). So, trim the 'F:' triggers for the "ABI/API" entry in MAINTAINERS right back to the minimum.

This change makes sense, but I don't think this commit message explains the specific changes to the file triggers. (Also, there's a convention for referencing past commits.) Might I suggest an alternate commit message?

Quoted 9 lines

"""
Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI changes") added file triggers for various paths that likely indicated API/ABI changes. However, catching all changes in Documentation/ABI/ and include/uapi/ produces a large volume of mail to linux-api, rather than only API/ABI changes. Drop those two entries, but leave include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related changes.
"""

Thanks. Looks like Andrew picked your version of the commit message up.

Cheers,

Michael

Quoted 21 lines
Quoted 21 lines
Signed-off-by Michael Kerrisk <[email protected]>
---
 MAINTAINERS | 2 --
 1 file changed, 2 deletions(-)
MAINTAINERS +0 -3
index f678c37..56f7a4f 100644
@@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/
 
 ABI/API
 L:     [email protected]
-F:     Documentation/ABI/
 F:     include/linux/syscalls.h
-F:     include/uapi/
 F:     kernel/sys_ni.c
 
 ABIT UGURU 1,2 HARDWARE MONITOR DRIVER
--

2.5.0

Signature · 3 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
#4 lore raw
In reply to Josh Triplett
Quoted 4 lines · Josh Triplett

On Thu, Feb 04, 2016 at 03:05:19PM +0100, Michael Kerrisk (man-pages) wrote:

Might I suggest an alternate commit message?

Quoted 9 lines

"""
Commit ea8f8fc8631 ("MAINTAINERS: add linux-api for review of API/ABI changes") added file triggers for various paths that likely indicated API/ABI changes.  However, catching all changes in Documentation/ABI/ and include/uapi/ produces a large volume of mail to linux-api, rather than only API/ABI changes.  Drop those two entries, but leave include/linux/syscalls.h and kernel/sys_ni.c to catch syscall-related changes.
"""

[]

Quoted 1 line

MAINTAINERS

Quoted 1 line
MAINTAINERS +0 -0

[]

Quoted 8 lines
Quoted 8 lines
MAINTAINERS +0 -0
@@ -223,9 +223,7 @@ F:  drivers/scsi/aacraid/

 ABI/API
 L:     [email protected]
-F:     Documentation/ABI/
 F:     include/linux/syscalls.h
-F:     include/uapi/
 F:     kernel/sys_ni.c

Maybe add a keyword entry like:

K: (?i)syscall

to see all actual changes of syscalls too?