Skip to contentSkip to conversation

4.5rc4 sound fsl-soc

REGRESSION, bisected Mika Penttilä 4 participants 5 messages Feb 15, 2016 – Feb 20, 2016 2 messages not in the archive

lore
Share & tools
lore

Mika Penttilä

author Tested-by Fabio Estevam
#0 lore raw

Hi,

The following commit :

5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit commit 5c408fee254633a5be69505bc86c6b034f871ab4

Author: Maciej S. Szmigiero <[email protected]>
Date:   Mon Jan 18 20:07:44 2016 +0100

ASoC: fsl_ssi: remove explicit register defaults

There is no guarantee that on fsl_ssi module load SSI registers will have their power-on-reset values.

In fact, if the driver is reloaded the values in registers will be whatever they were set to previously.

However, the cache needs to be fully populated at probe time to avoid non-atomic allocations during register access.

Special case here is imx21-class SSI, since according to datasheet it don't have SACC{ST,EN,DIS} regs.

This fixes hard lockup on fsl_ssi module reload, at least in AC'97 mode.

Fixes 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")

causes regmap init failure when loading the sgtl5000 codec on imx6q, and leads to no audio.

With the mentioned patch reverted sound works ok.

--Mika

Tested-by
#1 lore raw

[Sorry for the top post, can't reply properly from this Inbox]

Could you please try applying this commit from linux-next?
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf

Thanks,

Fabio Estevam

________________________________________
From: Mika Penttilä <[email protected]>
Sent: Monday, February 15, 2016 9:25 AM
To: LKML; [email protected]; Fabio Estevam
Subject: [REGRESSION, bisected] 4.5rc4 sound fsl-soc

Hi,

The following commit :

5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit commit 5c408fee254633a5be69505bc86c6b034f871ab4

Author: Maciej S. Szmigiero <[email protected]>
Date:   Mon Jan 18 20:07:44 2016 +0100

ASoC: fsl_ssi: remove explicit register defaults

There is no guarantee that on fsl_ssi module load SSI registers will have their power-on-reset values.

In fact, if the driver is reloaded the values in registers will be whatever they were set to previously.

However, the cache needs to be fully populated at probe time to avoid non-atomic allocations during register access.

Special case here is imx21-class SSI, since according to datasheet it don't have SACC{ST,EN,DIS} regs.

This fixes hard lockup on fsl_ssi module reload, at least in AC'97 mode.

Fixes 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")

causes regmap init failure when loading the sgtl5000 codec on imx6q, and leads to no audio.

With the mentioned patch reverted sound works ok.

--Mika

#2 lore raw
Quoted 4 lines · Fabio Estevam

[Sorry for the top post, can't reply properly from this Inbox]

Could you please try applying this commit from linux-next?
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf

I just confirmed that applying this patch to 4.5-rc4 fixes the fsl ssi regression.

Mark,

Could you apply
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf

to 4.5-rc?

Thanks

#5 lore raw
In reply to a message not in the archive

Mark,

I can confirm that the patch:

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf

solved the audio codec probing issue for me. Without it there's no sound on imx6 with 4.5-rc4.

Please apply.

Thanks,
Mika

Quoted 79 lines · Fabio Estevam

Hi Mika,

Did it work for you?

If so, please ask in the mailing list for Mark Brown to apply that patch.

Thanks

________________________________________
From: Mika Penttilä <[email protected]>
Sent: Monday, February 15, 2016 11:00 AM
To: Fabio Estevam
Subject: Re: [REGRESSION, bisected] 4.5rc4 sound fsl-soc

Quoted 1 line · Fabio Estevam

[Sorry for the top post, can't reply properly from this Inbox]

Hi,

will test that tomorrow morning EET.

thanks,
Mika

Quoted 54 lines

Could you please try applying this commit from linux-next?
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf

Thanks,

Fabio Estevam

________________________________________
From: Mika Penttilä <[email protected]>
Sent: Monday, February 15, 2016 9:25 AM
To: LKML; [email protected]; Fabio Estevam
Subject: [REGRESSION, bisected] 4.5rc4 sound fsl-soc

Hi,

The following commit :

5c408fee254633a5be69505bc86c6b034f871ab4 is the first bad commit commit 5c408fee254633a5be69505bc86c6b034f871ab4

Author: Maciej S. Szmigiero <[email protected]>
Date:   Mon Jan 18 20:07:44 2016 +0100

ASoC: fsl_ssi: remove explicit register defaults

There is no guarantee that on fsl_ssi module load SSI registers will have their power-on-reset values.

In fact, if the driver is reloaded the values in registers will be whatever they were set to previously.

However, the cache needs to be fully populated at probe time to avoid non-atomic allocations during register access.

Special case here is imx21-class SSI, since according to datasheet it don't have SACC{ST,EN,DIS} regs.

This fixes hard lockup on fsl_ssi module reload, at least in AC'97 mode.

Fixes 05cf237972fe ("ASoC: fsl_ssi: Add driver suspend and resume to support MEGA Fast")

causes regmap init failure when loading the sgtl5000 codec on imx6q, and leads to no audio.

With the mentioned patch reverted sound works ok.

--Mika

#6 lore raw
Quoted 5 lines · Mika Penttilä

Mark,

I can confirm that the patch:

https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/drivers/base/regmap/regcache.c?id=3245d460a1eb55b5c3ca31dde7b5c5ac71546edf

Please don't top post, reply in line with needed context. This allows readers to readily follow the flow of conversation and understand what you are talking about and also helps ensure that everything in the discussion is being addressed. Please also fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to.

Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.

Quoted 1 line

solved the audio codec probing issue for me. Without it there's no sound on imx6 with 4.5-rc4.

Did this ever work? What is the problem, this is the first message in this thread I have seen (the subject line isn't very intelligable with very long tags that hide most of the actual text, I may well have deleted prior mails)?