ls1021aqds_nor_lpuart_ boards

U-Boot Stefano Babic 5 participants 6 messages Feb 21, 2016 – Feb 22, 2016

lore

Share & tools

lore

Stefano Babic

author

2016-02-21 11:31 UTC #0 lore raw

Hi Bhuvanchandra,

your applied patch:

commit 5160def267739518950e8e3bb78e0e6c3941cb3e

Author: Bhuvanchandra DV <[email protected]>
Date:   Wed Jan 27 10:31:52 2016 +0530

dm: lpuart: Drop the legacy code

braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for these boards (setting them, build is fine):

For example, for ls1021aqds_nor_lpuart:

(quoted diff) +0 -0

b/configs/ls1021aqds_nor_lpuart_defconfig
index 1186af2..d8d77c2 100644

configs/ls1021aqds_nor_lpuart_defconfig +2 -0

@@ -2,6 +2,8 @@ CONFIG_ARM=y
 CONFIG_TARGET_LS1021AQDS=y
 CONFIG_SYS_EXTRA_OPTIONS="LPUART"
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
+CONFIG_DM_SERIAL=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_FSL_LPUART=y

Can you provide a formal patch and resubmit ? I have no way to test the result on the board.

Thanks,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Fabio Estevam

2016-02-21 13:00 UTC #1 lore raw

Quoted 30 lines · Stefano Babic

Hi Bhuvanchandra,
your applied patch:
commit 5160def267739518950e8e3bb78e0e6c3941cb3e
Author: Bhuvanchandra DV <[email protected]>
Date:   Wed Jan 27 10:31:52 2016 +0530
dm: lpuart: Drop the legacy code
braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for these boards (setting them, build is fine):
For example, for ls1021aqds_nor_lpuart:
configs/ls1021aqds_nor_lpuart_defconfig +2 -0
index 1186af2..d8d77c2 100644
@@ -2,6 +2,8 @@ CONFIG_ARM=y
 CONFIG_TARGET_LS1021AQDS=y
 CONFIG_SYS_EXTRA_OPTIONS="LPUART"
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
+CONFIG_DM_SERIAL=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_FSL_LPUART=y

Quoted 2 lines

Can you provide a formal patch and resubmit ? I have no way to test the result on the board.

Adding Alison, who is the maintainer of this board and could probably help testing the patch.

Bin Meng

2016-02-22 01:44 UTC #2 lore raw

Quoted 31 lines · Fabio Estevam

Quoted 30 lines · Stefano Babic
Hi Bhuvanchandra,
your applied patch:
commit 5160def267739518950e8e3bb78e0e6c3941cb3e
Author: Bhuvanchandra DV <[email protected]>
Date:   Wed Jan 27 10:31:52 2016 +0530
dm: lpuart: Drop the legacy code
braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for these boards (setting them, build is fine):
For example, for ls1021aqds_nor_lpuart:
configs/ls1021aqds_nor_lpuart_defconfig +2 -0
index 1186af2..d8d77c2 100644
@@ -2,6 +2,8 @@ CONFIG_ARM=y
 CONFIG_TARGET_LS1021AQDS=y
 CONFIG_SYS_EXTRA_OPTIONS="LPUART"
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
+CONFIG_DM_SERIAL=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_FSL_LPUART=y

Quoted 5 lines

Quoted 2 lines
Can you provide a formal patch and resubmit ? I have no way to test the result on the board.
Adding Alison, who is the maintainer of this board and could probably help testing the patch.

There is already a series [1] for the ls1021a-qds.

[1] http://patchwork.ozlabs.org/patch/580577/

Regards,
Bin

Huan Wang

2016-02-22 07:08 UTC #3 lore raw

Quoted 39 lines

Quoted 31 lines · Fabio Estevam
Quoted 30 lines · Stefano Babic
Hi Bhuvanchandra,
your applied patch:
commit 5160def267739518950e8e3bb78e0e6c3941cb3e
Author: Bhuvanchandra DV <[email protected]>
Date:   Wed Jan 27 10:31:52 2016 +0530
dm: lpuart: Drop the legacy code
braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for these boards (setting them, build is fine):
For example, for ls1021aqds_nor_lpuart:
configs/ls1021aqds_nor_lpuart_defconfig +2 -0
index 1186af2..d8d77c2 100644
@@ -2,6 +2,8 @@ CONFIG_ARM=y
 CONFIG_TARGET_LS1021AQDS=y
 CONFIG_SYS_EXTRA_OPTIONS="LPUART"
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
+CONFIG_DM_SERIAL=y
 CONFIG_NETDEVICES=y
 CONFIG_E1000=y
 CONFIG_FSL_LPUART=y
Quoted 5 lines
Quoted 2 lines
Can you provide a formal patch and resubmit ? I have no way to test the result on the board.
Adding Alison, who is the maintainer of this board and could probably help testing the patch.

Quoted 3 lines

There is already a series [1] for the ls1021a-qds.
[1] http://patchwork.ozlabs.org/patch/580577/

[Alison Wang] Yes, York has sent a series to fix this problem.

I only review and test his series.

Best Regards,
Alison Wang

Bhuvanchandra DV

2016-02-22 03:19 UTC #4 lore raw

In reply to Stefano Babic

Hi Stefano,

Adding Bin Meng.

Quoted 30 lines · Stefano Babic

Hi Bhuvanchandra,
your applied patch:
commit 5160def267739518950e8e3bb78e0e6c3941cb3e
Author: Bhuvanchandra DV <[email protected]>
Date:   Wed Jan 27 10:31:52 2016 +0530
dm: lpuart: Drop the legacy code
braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for these boards (setting them, build is fine):
For example, for ls1021aqds_nor_lpuart:
configs/ls1021aqds_nor_lpuart_defconfig +2 -0
index 1186af2..d8d77c2 100644
@@ -2,6 +2,8 @@ CONFIG_ARM=y
  CONFIG_TARGET_LS1021AQDS=y
  CONFIG_SYS_EXTRA_OPTIONS="LPUART"
  # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
+CONFIG_DM_SERIAL=y
  CONFIG_NETDEVICES=y
  CONFIG_E1000=y
  CONFIG_FSL_LPUART=y

Quoted 2 lines

Can you provide a formal patch and resubmit ? I have no way to test the result on the board.

I also don't have this h/w to test at my end, may be Bin can help here.

Quoted 4 lines

Thanks,
Stefano Babic

Signature · 2 lines

Best regards,
Bhuvan

Stefano Babic

author

2016-02-22 06:44 UTC #5 lore raw

Hi,

Quoted 35 lines · Bhuvanchandra DV

Hi Stefano,
Adding Bin Meng.
Quoted 30 lines · Stefano Babic
Hi Bhuvanchandra,
your applied patch:
commit 5160def267739518950e8e3bb78e0e6c3941cb3e
Author: Bhuvanchandra DV <[email protected]>
Date:   Wed Jan 27 10:31:52 2016 +0530
dm: lpuart: Drop the legacy code
braks ls1021aqds_*nor_lpuart. Tom has gently merged my PR, but this should be fixed. In fact, CONFIG_DM and CONFIG_DM_SERIAL are not set for these boards (setting them, build is fine):
For example, for ls1021aqds_nor_lpuart:
configs/ls1021aqds_nor_lpuart_defconfig +2 -0
index 1186af2..d8d77c2 100644
@@ -2,6 +2,8 @@ CONFIG_ARM=y
  CONFIG_TARGET_LS1021AQDS=y
  CONFIG_SYS_EXTRA_OPTIONS="LPUART"
  # CONFIG_CMD_SETEXPR is not set
+CONFIG_DM=y
+CONFIG_DM_SERIAL=y
  CONFIG_NETDEVICES=y
  CONFIG_E1000=y
  CONFIG_FSL_LPUART=y

Quoted 4 lines

Quoted 2 lines
Can you provide a formal patch and resubmit ? I have no way to test the result on the board.
I also don't have this h/w to test at my end, may be Bin can help here.

Fabio has already added Alison who is board maintainer - the one could have the hw for test.

Best regards,
Stefano

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================