drm/i915: Check live status before reading edid

4.4-rc1 Joseph Salisbury 3 participants 8 messages Feb 24, 2016 – Apr 18, 2016

Share & tools

Joseph Salisbury

author

2016-02-24 21:38 UTC #0 lore raw

Hi Sonika,

A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 237ed86c693d8a8e4db476976aeb30df4deac74b

Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530

drm/i915: Check live status before reading edid

The regression was introduced as of v4.4-rc1.

I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?

Thanks,

Joe

[0] http://pad.lv/lp1543683

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Jindal, Sonika

2016-02-25 03:53 UTC #1 lore raw

Hi Joe,

Yes, first thing to try is to increase the tries.
Can you please point me to the bug and provide more details like platform, monitor, cable.
Are you referring to the same issue as Oleksandr reported where a single link dvi/hdmi cable didn’t work and dual link worked?

Regards,
Sonika

-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, February 25, 2016 3:09 AM
To: Jindal, Sonika <[email protected]>
Cc: Sharma, Shashank <[email protected]>; Vivi, Rodrigo <[email protected]>; Daniel Vetter <[email protected]>; Jani Nikula <[email protected]>; David Airlie <[email protected]>; intel-gfx <[email protected]>; dri-devel <[email protected]>; LKML <[email protected]>
Subject: [4.4-rc1][Regression] drm/i915: Check live status before reading edid

Hi Sonika,

A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:

commit 237ed86c693d8a8e4db476976aeb30df4deac74b

Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530

drm/i915: Check live status before reading edid

The regression was introduced as of v4.4-rc1.

Thanks,

Joe

[0] http://pad.lv/lp1543683

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Joseph Salisbury

author

2016-02-25 18:41 UTC #2 lore raw

Quoted 3 lines · Sonika

Hi Joe,
Yes, first thing to try is to increase the tries.

We testing with 300 retries, but the second monitor still did not show up. However, it did show up in lspci.

Quoted 1 line

Can you please point me to the bug and provide more details like platform, monitor, cable.

The bug is at: http://pad.lv/1543683 . All the hardware details should be in the bug report. The cable is a single link dvi-d cable. Unfortunately the bug reporter does not have a dual link cable to test. If you need any additional info, we can ask the bug reporter.

Quoted 1 line

Are you referring to the same issue as Oleksandr reported where a single link dvi/hdmi cable didn’t work and dual link worked?

I'm not sure if this is the exact issue or not. I'll review the other thread and compare.

Quoted 25 lines

Regards,
Sonika
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, February 25, 2016 3:09 AM
To: Jindal, Sonika <[email protected]>
Cc: Sharma, Shashank <[email protected]>; Vivi, Rodrigo <[email protected]>; Daniel Vetter <[email protected]>; Jani Nikula <[email protected]>; David Airlie <[email protected]>; intel-gfx <[email protected]>; dri-devel <[email protected]>; LKML <[email protected]>
Subject: [4.4-rc1][Regression] drm/i915: Check live status before reading edid
Hi Sonika,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid
The regression was introduced as of v4.4-rc1.

Quoted 9 lines

I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Thanks,
Joe
[0] http://pad.lv/lp1543683

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Jindal, Sonika

2016-02-26 06:08 UTC #3 lore raw

Quoted 8 lines · Joseph Salisbury

Quoted 3 lines · Sonika
Hi Joe,
Yes, first thing to try is to increase the tries.
We testing with 300 retries, but the second monitor still did not show up. However, it did show up in lspci.

Quoted 5 lines

Quoted 1 line
Can you please point me to the bug and provide more details like platform, monitor, cable.
The bug is at: http://pad.lv/1543683 . All the hardware details should be in the bug report. The cable is a single link dvi-d cable. Unfortunately the bug reporter does not have a dual link cable to test. If you need any additional info, we can ask the bug reporter.

If this is with single link cable, the issue could be the same.
As Ville suggested for the other issue to use video=HDMI-A-1:e as command line argument, can you please give it a try? The logs shared in the bug doesn't have drm logs enabled, so couldnt get much out of it.
Which platform is this?

Alternatively you can add something like following in intel_hdmi_detect to make it ignore the live status checks.

@@ -1419,7 +1419,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)

        intel_hdmi_unset_edid(connector);

-
+ live_status = live_status | force;
if (intel_hdmi_set_edid(connector, live_status)) {
struct intel_hdmi *intel_hdmi =
intel_attached_hdmi(connector);

Regards,
Sonika

Quoted 38 lines

Quoted 1 line
Are you referring to the same issue as Oleksandr reported where a single link dvi/hdmi cable didn’t work and dual link worked?
I'm not sure if this is the exact issue or not. I'll review the other thread and compare.
Quoted 33 lines
Regards,
Sonika
-----Original Message-----
From: Joseph Salisbury [mailto:[email protected]]
Sent: Thursday, February 25, 2016 3:09 AM
To: Jindal, Sonika <[email protected]>
Cc: Sharma, Shashank <[email protected]>; Vivi, Rodrigo <[email protected]>; Daniel Vetter <[email protected]>; Jani Nikula <[email protected]>; David Airlie <[email protected]>; intel-gfx <[email protected]>; dri-devel <[email protected]>; LKML <[email protected]>
Subject: [4.4-rc1][Regression] drm/i915: Check live status before reading edid
Hi Sonika,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid
The regression was introduced as of v4.4-rc1.
I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Thanks,
Joe
[0] http://pad.lv/lp1543683

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Jani Nikula

2016-02-29 09:33 UTC #4 lore raw

In reply to Joseph Salisbury

Quoted 13 lines · Joseph Salisbury

Hi Sonika,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid

Quoted 6 lines

The regression was introduced as of v4.4-rc1.
I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?

There are at least the following commits claiming to fix issues in the above commit. Please make sure you have them.

BR,
Jani.

commit 8d409cb3e8a24196be7271defafd4638f3e0b514

Author: Ville Syrjälä <[email protected]>
Date:   Wed Feb 10 19:59:05 2016 +0200

drm/i915: Fix hpd live status bits for g4x

commit 3d8acd1f667b45c531401c8f0c2033072e32a05d

Author: Gary Wang <[email protected]>
Date:   Wed Dec 23 16:11:35 2015 +0800

drm/i915: increase the tries for HDMI hotplug live status checking

commit 97f9010af05c15e0b7e6b4ef6ff8cb0ebb7e7715

Author: Daniel Vetter <[email protected]>
Date:   Fri Dec 11 19:44:15 2015 +0100

drm/i915: mdelay(10) considered harmful

commit 0f5a9be15797f78c9a34e432f26c796165b6e49a

Author: Imre Deak <[email protected]>
Date:   Fri Nov 27 18:55:29 2015 +0200

drm/i915: take a power domain reference while checking the HDMI live status

Signature · 5 lines

Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Joseph Salisbury

author

2016-03-02 21:58 UTC #5 lore raw

Quoted 14 lines · Jani Nikula

Quoted 13 lines · Joseph Salisbury
Hi Sonika,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid

Quoted 6 lines

Quoted 6 lines
The regression was introduced as of v4.4-rc1.
I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?

Thanks for the info. I will have all of these commits tested.

Quoted 23 lines

There are at least the following commits claiming to fix issues in the above commit. Please make sure you have them.
BR,
Jani.
commit 8d409cb3e8a24196be7271defafd4638f3e0b514
Author: Ville Syrjälä <[email protected]>
Date:   Wed Feb 10 19:59:05 2016 +0200
drm/i915: Fix hpd live status bits for g4x
commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
Author: Gary Wang <[email protected]>
Date:   Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking
commit 97f9010af05c15e0b7e6b4ef6ff8cb0ebb7e7715
Author: Daniel Vetter <[email protected]>
Date:   Fri Dec 11 19:44:15 2015 +0100

Quoted 11 lines

drm/i915: mdelay(10) considered harmful
commit 0f5a9be15797f78c9a34e432f26c796165b6e49a
Author: Imre Deak <[email protected]>
Date:   Fri Nov 27 18:55:29 2015 +0200
drm/i915: take a power domain reference while checking the HDMI live status

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Joseph Salisbury

author

2016-03-28 18:39 UTC #6 lore raw

Quoted 15 lines · Joseph Salisbury

Quoted 14 lines · Jani Nikula
Quoted 13 lines · Joseph Salisbury
Hi Sonika,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid

Quoted 43 lines

Quoted 6 lines
Quoted 6 lines
The regression was introduced as of v4.4-rc1.
I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Thanks for the info. I will have all of these commits tested.
Quoted 34 lines
There are at least the following commits claiming to fix issues in the above commit. Please make sure you have them.
BR,
Jani.
commit 8d409cb3e8a24196be7271defafd4638f3e0b514
Author: Ville Syrjälä <[email protected]>
Date:   Wed Feb 10 19:59:05 2016 +0200
drm/i915: Fix hpd live status bits for g4x
commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
Author: Gary Wang <[email protected]>
Date:   Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking
commit 97f9010af05c15e0b7e6b4ef6ff8cb0ebb7e7715
Author: Daniel Vetter <[email protected]>
Date:   Fri Dec 11 19:44:15 2015 +0100
drm/i915: mdelay(10) considered harmful
commit 0f5a9be15797f78c9a34e432f26c796165b6e49a
Author: Imre Deak <[email protected]>
Date:   Fri Nov 27 18:55:29 2015 +0200
drm/i915: take a power domain reference while checking the HDMI live status

Hi Jani,

Applying the following commit did indeed fix the original bug[0]:

commit 8d409cb3e8a24196be7271defafd4638f3e0b514

Author: Ville Syrjälä <[email protected]>
Date:   Wed Feb 10 19:59:05 2016 +0200

drm/i915: Fix hpd live status bits for g4x

However, it also introduced a new bug, which is covered in that bug report. The new bug is that after locking/unlocking the screen, all the windows get shuffled around in a manner that is consistent with X deciding that it's single-headed again, and then back to double headed. This only happens when I build a kernel with both commit 237ed86c AND commit 8d409cb3e. If I revert 237ed86c and keep only 8d409cb3e both the original bug and the new bug go away. Do you think commit 237ed86c is still even needed now that 8d409cb3e has landed? Maybe the new bug is due to the interaction between 237ed86c and 8d409cb3e.

Thanks,

Joe

[0] http://pad.lv/1543683

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Joseph Salisbury

author

2016-04-18 19:46 UTC #7 lore raw

Quoted 81 lines · Joseph Salisbury

Quoted 15 lines · Joseph Salisbury
Quoted 14 lines · Jani Nikula
Quoted 13 lines · Joseph Salisbury
Hi Sonika,
A kernel bug report was opened against Ubuntu [0]. After a kernel bisect, it was found that reverting the following commit resolved this bug:
commit 237ed86c693d8a8e4db476976aeb30df4deac74b
Author: Sonika Jindal <[email protected]>
Date:   Tue Sep 15 09:44:20 2015 +0530
drm/i915: Check live status before reading edid
Quoted 43 lines
Quoted 6 lines
Quoted 6 lines
The regression was introduced as of v4.4-rc1.
I was hoping to get your feedback, since you are the patch author. Do think increasing the number of tries in intel_hdmi_detect() is worth trying? Do you think gathering any additional data will help diagnose this issue, or would it be best to submit a revert request?
Thanks for the info. I will have all of these commits tested.
Quoted 34 lines
There are at least the following commits claiming to fix issues in the above commit. Please make sure you have them.
BR,
Jani.
commit 8d409cb3e8a24196be7271defafd4638f3e0b514
Author: Ville Syrjälä <[email protected]>
Date:   Wed Feb 10 19:59:05 2016 +0200
drm/i915: Fix hpd live status bits for g4x
commit 3d8acd1f667b45c531401c8f0c2033072e32a05d
Author: Gary Wang <[email protected]>
Date:   Wed Dec 23 16:11:35 2015 +0800
drm/i915: increase the tries for HDMI hotplug live status checking
commit 97f9010af05c15e0b7e6b4ef6ff8cb0ebb7e7715
Author: Daniel Vetter <[email protected]>
Date:   Fri Dec 11 19:44:15 2015 +0100
drm/i915: mdelay(10) considered harmful
commit 0f5a9be15797f78c9a34e432f26c796165b6e49a
Author: Imre Deak <[email protected]>
Date:   Fri Nov 27 18:55:29 2015 +0200
drm/i915: take a power domain reference while checking the HDMI live status
Hi Jani,
Applying the following commit did indeed fix the original bug[0]:
commit 8d409cb3e8a24196be7271defafd4638f3e0b514
Author: Ville Syrjälä <[email protected]>
Date:   Wed Feb 10 19:59:05 2016 +0200
drm/i915: Fix hpd live status bits for g4x
However, it also introduced a new bug, which is covered in that bug report. The new bug is that after locking/unlocking the screen, all the windows get shuffled around in a manner that is consistent with X deciding that it's single-headed again, and then back to double headed. This only happens when I build a kernel with both commit 237ed86c AND commit 8d409cb3e. If I revert 237ed86c and keep only 8d409cb3e both the original bug and the new bug go away. Do you think commit 237ed86c is still even needed now that 8d409cb3e has landed? Maybe the new bug is due to the interaction between 237ed86c and 8d409cb3e.

Quoted 10 lines

Thanks,
Joe
[0] http://pad.lv/1543683

Hello,

Is there any addition debug data we can collect to debug the new bug that commit 8d409cb3e introduced?

Thanks,

Joe
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx