Skip to contentSkip to conversation

Left-over select to PUBLIC_KEY_ALGO_RSA

PATCH Applied Andreas Ziegler 2 participants 4 messages Mar 4, 2016 – Mar 7, 2016

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

Hi David,

your patch "akcipher: Move the RSA DER encoding check to the crypto layer" showed up in linux-next today as commit d43de6c780a8 (that is, next-20160304).

It removes the CONFIG_PUBLIC_KEY_ALGO_RSA option, but does leave one reference to it in place inside security/integrity/Kconfig, in the definition of CONFIG_INTEGRITY_ASYMMETRIC_KEYS.

As the corresponding option is gone, the select statement can safely be removed. Should I prepare a simple patch for that?

I detected this by using scripts/checkkconfigsymbols on today's and yesterday's linux-next trees (i.e., "./scripts/checkkconfigsymbols.py -d next-20160303..next-20160304").

Best regards,

Andreas

#1 lore raw
Quoted 2 lines · Andreas Ziegler

As the corresponding option is gone, the select statement can safely be removed. Should I prepare a simple patch for that?

Please.

Quoted 3 lines

I detected this by using scripts/checkkconfigsymbols on today's and yesterday's linux-next trees (i.e., "./scripts/checkkconfigsymbols.py -d next-20160303..next-20160304").

Interesting - I didn't realise that exists. This sort of consistency check should be run every time the Kconfig files are parsed.

Thanks,
David

#2 lore raw

PATCH 1/1 security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA

Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA, but forgot to remove a 'select' to this option in the definition of INTEGRITY_ASYMMETRIC_KEYS.

Let's remove the select, as it's ineffective now.

---
 security/integrity/Kconfig | 1 -
 1 file changed, 1 deletion(-)
security/integrity/Kconfig +0 -1
index 979be65..da95658 100644
@@ -35,7 +35,6 @@ config INTEGRITY_ASYMMETRIC_KEYS
 	default n
         select ASYMMETRIC_KEY_TYPE
         select ASYMMETRIC_PUBLIC_KEY_SUBTYPE
-        select PUBLIC_KEY_ALGO_RSA
         select CRYPTO_RSA
         select X509_CERTIFICATE_PARSER
 	help
Signature · 1 line
1.9.1
#3 lore raw

Re: [PATCH] security: integrity: Remove select to deleted option PUBLIC_KEY_ALGO_RSA

Quoted 8 lines · Andreas Ziegler

Commit d43de6c780a8 ("akcipher: Move the RSA DER encoding check to the crypto layer") removed the Kconfig option PUBLIC_KEY_ALGO_RSA, but forgot to remove a 'select' to this option in the definition of INTEGRITY_ASYMMETRIC_KEYS.

Let's remove the select, as it's ineffective now.

Applied.