Skip to contentSkip to conversation

pps: kc: fix non-tickless system config dependency

PATCH Superseded Maciej S. Szmigiero 2 participants 5 messages Mar 5, 2016 – Mar 28, 2016 PPS support

lore
Share & tools
lore

Maciej S. Szmigiero

author
#0 lore raw

PATCH 1/1 pps: kc: fix non-tickless system config dependency

CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.

Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.

Signed-off-by Maciej S. Szmigiero <[email protected]>
---
 drivers/pps/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pps/Kconfig +1 -1
index 7512e98e9311..564a51abeece 100644
@@ -31,7 +31,7 @@ config PPS_DEBUG
 
 config NTP_PPS
 	bool "PPS kernel consumer support"
-	depends on !NO_HZ
+	depends on !NO_HZ_COMMON
 	help
 	  This option adds support for direct in-kernel time
 	  synchronization using an external PPS signal.
maintainer
#1 lore raw
Quoted 10 lines · Maciej S. Szmigiero

CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.

Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.

Signed-off-by Maciej S. Szmigiero <[email protected]>

It's ok for me.

Ciao,

Rodolfo

Signature · 7 lines
HCE Engineering                      e-mail: [email protected]
GNU/Linux Solutions                          [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.io
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
author
#2 lore raw

Hi Rodolfo,

Quoted 6 lines · Rodolfo Giometti
Quoted 5 lines · Maciej S. Szmigiero

CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.

Quoted 7 lines
Quoted 5 lines

Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.

Signed-off-by Maciej S. Szmigiero <[email protected]>

It's ok for me.

Thanks for review, do you know who should merge it then?

Quoted 3 lines

Ciao,

Rodolfo

Best regards,
Maciej

maintainer
#3 lore raw
Quoted 13 lines · Maciej S. Szmigiero

Hi Rodolfo,

Quoted 10 lines · Rodolfo Giometti
Quoted 9 lines · Maciej S. Szmigiero

CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.

Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Maciej S. Szmigiero <[email protected]>

It's ok for me.

Thanks for review, do you know who should merge it then?

Usually I ask to Andrew Morton <[email protected]>

Ciao,

Rodolfo

Signature · 7 lines
HCE Engineering                      e-mail: [email protected]
GNU/Linux Solutions                          [email protected]
Linux Device Driver                          [email protected]
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.io
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
author
#4 lore raw

Hi Andrew,

Could you take this patch, please?

Thanks,
Maciej

Quoted 26 lines · Rodolfo Giometti
Quoted 13 lines · Maciej S. Szmigiero

Hi Rodolfo,

Quoted 10 lines · Rodolfo Giometti
Quoted 9 lines · Maciej S. Szmigiero

CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ.

Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Maciej S. Szmigiero <[email protected]>

It's ok for me.

Thanks for review, do you know who should merge it then?

Usually I ask to Andrew Morton <[email protected]>

Ciao,

Rodolfo