Skip to contentSkip to conversation

leds: use config symbol LEDS_CLASS_RGB consistently

PATCH In review Heiner Kallweit 2 participants 3 messages Mar 21, 2016 LED

lore
Share & tools
lore

Heiner Kallweit

author
#0 lore raw

PATCH 1/1 leds: use config symbol LEDS_CLASS_RGB consistently

Config symbol LEDS_RGB was renamed to LEDS_CLASS_RGB. This makes sense, but the change wasn't done consistently.

Signed-off-by Heiner Kallweit <[email protected]>
---
 drivers/leds/Kconfig  | 4 ++--
 drivers/leds/Makefile | 2 +-
 drivers/leds/leds.h   | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/leds/Kconfig +2 -2
index 4d819ba..f213c06 100644
@@ -624,9 +624,9 @@ config LEDS_VERSATILE
 	  This option enabled support for the LEDs on the ARM Versatile
 	  and RealView boards. Say Y to enabled these.
 
-if LEDS_RGB
+if LEDS_CLASS_RGB
 comment "RGB LED drivers"
-endif # LEDS_RGB
+endif # LEDS_CLASS_RGB
 
 comment "LED Triggers"
 source "drivers/leds/trigger/Kconfig"
drivers/leds/Makefile +1 -1
index 9419dbf..e36ef69 100644
@@ -2,7 +2,7 @@
 # LED Core
 obj-$(CONFIG_NEW_LEDS)			+= led-core-objs.o
 led-core-objs-y				:= led-core.o
-led-core-objs-$(CONFIG_LEDS_RGB)	+= led-rgb-core.o
+led-core-objs-$(CONFIG_LEDS_CLASS_RGB)	+= led-rgb-core.o
 obj-$(CONFIG_LEDS_CLASS)		+= led-class.o
 obj-$(CONFIG_LEDS_CLASS_FLASH)		+= led-class-flash.o
 obj-$(CONFIG_LEDS_TRIGGERS)		+= led-triggers.o
drivers/leds/leds.h +1 -1
index b853f54..9c5f3fe 100644
@@ -35,7 +35,7 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
 				enum led_brightness value);
 void led_set_brightness_nosleep(struct led_classdev *led_cdev,
 				enum led_brightness value);
-#if IS_ENABLED(CONFIG_LEDS_RGB)
+#if IS_ENABLED(CONFIG_LEDS_CLASS_RGB)
 enum led_brightness led_confine_brightness(struct led_classdev *led_cdev,
 					   enum led_brightness value);
 #else
Signature · 1 line
2.7.3
#1 lore raw

Hi Heiner,

Please note that you don't need to submit incremental patches for the code that is not in mainline yet. You can send just a new version and I'll replace the old one with it.

Thanks,
Jacek Anaszewski

Quoted 53 lines · Heiner Kallweit

Config symbol LEDS_RGB was renamed to LEDS_CLASS_RGB. This makes sense, but the change wasn't done consistently.

Signed-off-by Heiner Kallweit <[email protected]>
---
  drivers/leds/Kconfig  | 4 ++--
  drivers/leds/Makefile | 2 +-
  drivers/leds/leds.h   | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)
drivers/leds/Kconfig +2 -2
index 4d819ba..f213c06 100644
@@ -624,9 +624,9 @@ config LEDS_VERSATILE
  	  This option enabled support for the LEDs on the ARM Versatile
  	  and RealView boards. Say Y to enabled these.
 
-if LEDS_RGB
+if LEDS_CLASS_RGB
  comment "RGB LED drivers"
-endif # LEDS_RGB
+endif # LEDS_CLASS_RGB
 
  comment "LED Triggers"
  source "drivers/leds/trigger/Kconfig"
drivers/leds/Makefile +1 -1
index 9419dbf..e36ef69 100644
@@ -2,7 +2,7 @@
  # LED Core
  obj-$(CONFIG_NEW_LEDS)			+= led-core-objs.o
  led-core-objs-y				:= led-core.o
-led-core-objs-$(CONFIG_LEDS_RGB)	+= led-rgb-core.o
+led-core-objs-$(CONFIG_LEDS_CLASS_RGB)	+= led-rgb-core.o
  obj-$(CONFIG_LEDS_CLASS)		+= led-class.o
  obj-$(CONFIG_LEDS_CLASS_FLASH)		+= led-class-flash.o
  obj-$(CONFIG_LEDS_TRIGGERS)		+= led-triggers.o
drivers/leds/leds.h +1 -1
index b853f54..9c5f3fe 100644
@@ -35,7 +35,7 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
  				enum led_brightness value);
  void led_set_brightness_nosleep(struct led_classdev *led_cdev,
  				enum led_brightness value);
-#if IS_ENABLED(CONFIG_LEDS_RGB)
+#if IS_ENABLED(CONFIG_LEDS_CLASS_RGB)
  enum led_brightness led_confine_brightness(struct led_classdev *led_cdev,
  					   enum led_brightness value);
  #else
author
#2 lore raw

Am 21.03.2016 um 16:45 schrieb Jacek Anaszewski:

Quoted 5 lines

Hi Heiner,

Please note that you don't need to submit incremental patches for the code that is not in mainline yet. You can send just a new version and I'll replace the old one with it.

OK, I see. Then I'll send a v8 of the patch.

Heiner

Quoted 61 lines

Thanks,
Jacek Anaszewski

Quoted 53 lines · Heiner Kallweit

Config symbol LEDS_RGB was renamed to LEDS_CLASS_RGB. This makes sense, but the change wasn't done consistently.

Signed-off-by Heiner Kallweit <[email protected]>
---
  drivers/leds/Kconfig  | 4 ++--
  drivers/leds/Makefile | 2 +-
  drivers/leds/leds.h   | 2 +-
  3 files changed, 4 insertions(+), 4 deletions(-)
drivers/leds/Kconfig +2 -2
index 4d819ba..f213c06 100644
@@ -624,9 +624,9 @@ config LEDS_VERSATILE
        This option enabled support for the LEDs on the ARM Versatile
        and RealView boards. Say Y to enabled these.
 
-if LEDS_RGB
+if LEDS_CLASS_RGB
  comment "RGB LED drivers"
-endif # LEDS_RGB
+endif # LEDS_CLASS_RGB
 
  comment "LED Triggers"
  source "drivers/leds/trigger/Kconfig"
drivers/leds/Makefile +1 -1
index 9419dbf..e36ef69 100644
@@ -2,7 +2,7 @@
  # LED Core
  obj-$(CONFIG_NEW_LEDS)            += led-core-objs.o
  led-core-objs-y                := led-core.o
-led-core-objs-$(CONFIG_LEDS_RGB)    += led-rgb-core.o
+led-core-objs-$(CONFIG_LEDS_CLASS_RGB)    += led-rgb-core.o
  obj-$(CONFIG_LEDS_CLASS)        += led-class.o
  obj-$(CONFIG_LEDS_CLASS_FLASH)        += led-class-flash.o
  obj-$(CONFIG_LEDS_TRIGGERS)        += led-triggers.o
drivers/leds/leds.h +1 -1
index b853f54..9c5f3fe 100644
@@ -35,7 +35,7 @@ void led_set_brightness_nopm(struct led_classdev *led_cdev,
                  enum led_brightness value);
  void led_set_brightness_nosleep(struct led_classdev *led_cdev,
                  enum led_brightness value);
-#if IS_ENABLED(CONFIG_LEDS_RGB)
+#if IS_ENABLED(CONFIG_LEDS_CLASS_RGB)
  enum led_brightness led_confine_brightness(struct led_classdev *led_cdev,
                         enum led_brightness value);
  #else