Workqueue change with commit id,1bd04bf6f breaks mpt3sas scsi driver
A message that is not in the archive (sent off-list or not yet received): [email protected]
(cc'ing Thomas)
Hello,
Quoted 7 lines · nick
Seems that commit id,
1bd04bf6fbreaks the mpt3sas driver according to this bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=114611. Seems that the driver is fine as have inspection all the driver functions are wrappers aroundqueue_delayed_workand according to the person's debugging this commit breaks it. However they are not sure if it's the driver or the timer subsystem. I am assuming it's the timer subsystem as the driver is just using wrapper functions around core workqueue functions with irqs disabled and a spin lock held.
Hmmm... 1bd04bf6f68d ("timer: Remove FIFO "guarantee"") doesn't look like an easy change to undo and it sounds like the driver was already (subtly) broken even before the commit given that ordered workqueues are not affine to any CPU and timer expirations across different CPUs aren't strictly ordered. Unfortunately, the only way forward seems to be implementing ordering from the driver's side.
Thanks.
Signature · 1 line
tejun
Quoted 9 lines · Tejun Heo
Quoted 7 lines · nick
Seems that commit id,
1bd04bf6fbreaks the mpt3sas driver according to this bug report:
https://bugzilla.kernel.org/show_bug.cgi?id=114611. Seems that the driver is fine as have inspection all the driver functions are wrappers aroundqueue_delayed_workand according to the person's debugging this commit breaks it. However they are not sure if it's the driver or the timer subsystem. I am assuming it's the timer subsystem as the driver is just using wrapper functions around core workqueue functions with irqs disabled and a spin lock held.
Quoted 6 lines
Hmmm...
1bd04bf6f68d("timer: Remove FIFO "guarantee"") doesn't look like an easy change to undo and it sounds like the driver was already (subtly) broken even before the commit given that ordered workqueues are not affine to any CPU and timer expirations across different CPUs aren't strictly ordered. Unfortunately, the only way forward seems to be implementing ordering from the driver's side.
The changelog explains in detail, that the FIFO "guarantee" did not exist for a long time. Certainly that commit removed the last reminders of that so called guarantee, but anything relying on FIFO ordering of the timer wheel was broken before that commit. Just because it "worked" before that commit does not mean it was correct.
Thanks,
tglx