ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies
Subsystems (2)
PATCH 1/1 ARM: dts: exynos-5422-odroid: Add eMMC and SD regulator supplies
Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on odroid XU3 and XU4 to avoid warnings in dmesg output.
--- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +13 -2
@@ -121,7 +121,7 @@ }; ldo3_reg: LDO3 { - regulator-name = "vdd_ldo3"; + regulator-name = "vddq_mmc0"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on;
@@ -184,7 +184,7 @@ }; ldo13_reg: LDO13 { - regulator-name = "vdd_ldo13"; + regulator-name = "vddq_mmc2"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; regulator-always-on;
@@ -211,6 +211,13 @@ regulator-always-on; }; + ldo18_reg: LDO18 { + regulator-name = "vdd_emmc_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on; + }; + ldo19_reg: LDO19 { regulator-name = "vdd_sd"; regulator-min-microvolt = <2800000>;
@@ -347,6 +354,8 @@ cap-mmc-highspeed; mmc-hs200-1_8v; mmc-hs400-1_8v; + vmmc-supply = <&ldo18_reg>; + vqmmc-supply = <&ldo3_reg>; }; &mmc_2 {
@@ -359,6 +368,8 @@ pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus1 &sd2_bus4>; bus-width = <4>; cap-sd-highspeed; + vmmc-supply = <&ldo19_reg>; + vqmmc-supply = <&ldo13_reg>; }; &pinctrl_0 {
Signature · 1 line
2.1.4
Quoted 2 lines · Markus Reichl
Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on odroid XU3 and XU4 to avoid warnings in dmesg output.
What warnings?
Quoted 29 lines
Signed-off-by Markus Reichl <[email protected]>--- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +2
-2@@ -121,7 +121,7 @@ }; ldo3_reg: LDO3 { - regulator-name = "vdd_ldo3"; + regulator-name = "vddq_mmc0"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on;@@ -184,7 +184,7 @@ }; ldo13_reg: LDO13 { - regulator-name = "vdd_ldo13"; + regulator-name = "vddq_mmc2"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; regulator-always-on;
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi line 218
Quoted 8 lines
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +5
-0@@ -211,6 +211,13 @@ regulator-always-on; }; + ldo18_reg: LDO18 { + regulator-name = "vdd_emmc_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on;
In the same patchset you add always-on and remove. What is the point of this juggle?
Best regards,
Krzysztof
Hi Krzysztof,
Am 04.04.2016 um 02:28 schrieb Krzysztof Kozlowski:
Quoted 5 lines · Markus Reichl
Quoted 2 lines
Add vmmc and vqmmc supplies from MF circuit sheets for eMMC and SD on odroid XU3 and XU4 to avoid warnings in dmesg output.
What warnings?
[ 1.843689] dwmmc_exynos 12200000.mmc: Looking up vmmc-supply property in node /mmc@12200000 failed [ 1.843773] dwmmc_exynos 12200000.mmc: Looking up vqmmc-supply property in node /mmc@12200000 failed [ 1.912340] dwmmc_exynos 12220000.mmc: Looking up vmmc-supply property in node /mmc@12220000 failed [ 1.912410] dwmmc_exynos 12220000.mmc: Looking up vqmmc-supply property in node /mmc@12220000 failed
Quoted 33 lines
Quoted 33 lines
Signed-off-by Markus Reichl <[email protected]>--- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +2
-2@@ -121,7 +121,7 @@ }; ldo3_reg: LDO3 { - regulator-name = "vdd_ldo3"; + regulator-name = "vddq_mmc0"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on;@@ -184,7 +184,7 @@ }; ldo13_reg: LDO13 { - regulator-name = "vdd_ldo13"; + regulator-name = "vddq_mmc2"; regulator-min-microvolt = <2800000>; regulator-max-microvolt = <2800000>; regulator-always-on;@@ -211,6 +211,13 @@ regulator-always-on; };
Quoted 8 lines
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi line 218
Quoted 5 lines
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +5
-0+ ldo18_reg: LDO18 { + regulator-name = "vdd_emmc_1V8"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-always-on;In the same patchset you add always-on and remove. What is the point of this juggle?
I will squash the two patches together in one.
Quoted 9 lines
Best regards,
Krzysztof--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Servus,
--
Markus Reichl