Skip to contentSkip to conversation

ARM: dts: exynos-5422-odroid: Remove always_on for eMMC and SD regulators

PATCH In review Markus Reichl 2 participants 3 messages Apr 1, 2016 – Apr 4, 2016

Subsystems (2)
Device tree bindings Arm Samsung Exynos
lore
Share & tools
lore

Markus Reichl

author
#0 lore raw

PATCH 1/1 ARM: dts: exynos-5422-odroid: Remove always_on for eMMC and SD regulators

Allow these suplies to be switched off if not used.

Signed-off-by Markus Reichl <[email protected]>

---
Tested with eMMC only on XU4.
SD still needs testing.

---
 arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 4 ----
 1 file changed, 4 deletions(-)
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +0 -4
index a761d3f..6f2f364 100644
@@ -141,7 +141,6 @@
                                regulator-name = "vddq_mmc0";
                                regulator-min-microvolt = <1800000>;
                                regulator-max-microvolt = <1800000>;
-                               regulator-always-on;
                        };
 
                        ldo5_reg: LDO5 {

@@ -204,7 +203,6 @@
                                regulator-name = "vddq_mmc2";
                                regulator-min-microvolt = <2800000>;
                                regulator-max-microvolt = <2800000>;
-                               regulator-always-on;
                        };
 
                        ldo15_reg: LDO15 {

@@ -232,14 +230,12 @@
                                regulator-name = "vdd_emmc_1V8";
                                regulator-min-microvolt = <1800000>;
                                regulator-max-microvolt = <1800000>;
-                               regulator-always-on;
                        };
 
                        ldo19_reg: LDO19 {
                                regulator-name = "vdd_sd";
                                regulator-min-microvolt = <2800000>;
                                regulator-max-microvolt = <2800000>;
-                               regulator-always-on;
                        };
 
                        ldo24_reg: LDO24 {
Signature · 1 line
2.1.4
#1 lore raw
Quoted 1 line · Markus Reichl

Allow these suplies to be switched off if not used.

s/suplies/supplies/

Quoted 5 lines
Signed-off-by Markus Reichl <[email protected]>

---
Tested with eMMC only on XU4.
SD still needs testing.

I wanted to test your patches but the first does not apply (next-20160401, my for-next) so I gave up.

I think this patch should be squashed with previous one. I don't see benefits of splitting this (but maybe I am missing something?).

Best regards,
Krzysztof

author
#2 lore raw

Hi Krzysztof,

Am 04.04.2016 um 02:37 schrieb Krzysztof Kozlowski:

Quoted 4 lines · Markus Reichl
Quoted 1 line

Allow these suplies to be switched off if not used.

s/suplies/supplies/

Will correct it.

Quoted 9 lines
Quoted 6 lines
Signed-off-by Markus Reichl <[email protected]>

---
Tested with eMMC only on XU4.
SD still needs testing.

I wanted to test your patches but the first does not apply (next-20160401, my for-next) so I gave up.

Will check and base on next-20160401.

Quoted 3 lines

I think this patch should be squashed with previous one. I don't see benefits of splitting this (but maybe I am missing something?).

Will sqash them into one.

Quoted 4 lines

Best regards,
Krzysztof

Servus,
--
Markus Reichl