Skip to contentSkip to conversation

cpuset: change default cpuset mount value

PATCH New Basavaraju 2 participants 2 messages Apr 7, 2016

lore
Share & tools
lore

Basavaraju

author
#0 lore raw

PATCH 1/1 cpuset: change default cpuset mount value

Hi,

Earlier cpuset is mounted under /dev/cpuset by default. This behaviour is changed in RHEL7.1 and RHEL7.2 Distributions

by default, Now its mounting under /sys/fs/cgroup/cpuset.

[root@localhost ~]# mount | grep cpuset
cgroup on /sys/fs/cgroup/cpuset type cgroup
(rw,nosuid,nodev,noexec,relatime,cpuset)
[root@localhost ~]#

Signed-off-by Basavaraju.G<[email protected]>
Tested-by Basavaraju.G<[email protected]>
(quoted diff) +0 -0

b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh index cd7000e..4c5a17b 100755

testcases/kernel/controllers/cpuset/cpuset_funcs.sh +1 -1
@@ -35,7 +35,7 @@ fi
  N_NODES=${N_NODES#*-*}
  N_NODES=$(($N_NODES + 1))
 
-CPUSET="/dev/cpuset"
+CPUSET="/sys/fs/cgroup/cpuset"
  CPUSET_TMP="/tmp/cpuset_tmp"
 
  HOTPLUG_CPU="1"

Best Regards,
Basavaraju.G

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20160407/c3291688/attachment.html>

#1 lore raw

PATCH 1/1 cpuset: change default cpuset mount value

Hi!

testcases/kernel/controllers/cpuset/cpuset_funcs.sh fi · line 39

Quoted 12 lines
testcases/kernel/controllers/cpuset/cpuset_funcs.sh +1 -1
index cd7000e..4c5a17b 100755
@@ -35,7 +35,7 @@ fi
  N_NODES=${N_NODES#*-*}
  N_NODES=$(($N_NODES + 1))
 
-CPUSET="/dev/cpuset"
+CPUSET="/sys/fs/cgroup/cpuset"
  CPUSET_TMP="/tmp/cpuset_tmp"

This does not seem like a good solution for two reasons. The first is that LTP should be backward compatible with older distributions and the second is that the testcase umounts and removes the directory at the end of the test which will break the system since the /sys/fs/cgroup/cpuset directory is mounted (and possibly used) by default on newer distributions.

So the test should be changed to:

* Create and mount cpuset on older distros

* Make use of allready moutned cpuset on newer distros

The cgroup_fj/cgroup_fj_common.sh was allready fixed to work this way.

Signature · 2 lines
Cyril Hrubis
[email protected]