scsi_dh_alua: Declare local functions static
PATCH 1/1 scsi_dh_alua: Declare local functions static
This patch avoids that building with W=1 causes gcc to report the following type of warning:
no previous prototype for ... [-Wmissing-prototypes]
Signed-off-by Bart Van Assche <[email protected]>
Cc Hannes Reinecke <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Ewan Milne <[email protected]>
--- drivers/scsi/device_handler/scsi_dh_alua.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +4 -4
@@ -190,8 +190,8 @@ static int submit_stpg(struct scsi_device *sdev, int group_id, ALUA_FAILOVER_RETRIES, NULL, req_flags); } -struct alua_port_group *alua_find_get_pg (char *id_str,size_t id_size, -int group_id) +static struct alua_port_group *alua_find_get_pg (char *id_str,size_t id_size, +int group_id) {struct alua_port_group *pg;
@@ -219,8 +219,8 @@ struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size,* Allocate a new port_group structure for a given * device. */ -struct alua_port_group *alua_alloc_pg (struct scsi_device *sdev, -int group_id,int tpgs) +static struct alua_port_group *alua_alloc_pg (struct scsi_device *sdev, +int group_id,int tpgs) {struct alua_port_group *pg, *tmp_pg;
Signature · 1 line
2.8.1
Quoted 30 lines · Bart Van Assche
This patch avoids that building with W=1 causes gcc to report the following type of warning:
no previous prototype for ... [-Wmissing-prototypes]
Signed-off-by Bart Van Assche <[email protected]>Cc Hannes Reinecke <[email protected]>Cc Christoph Hellwig <[email protected]>Cc Ewan Milne <[email protected]>--- drivers/scsi/device_handler/scsi_dh_alua.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/scsi/device_handler/scsi_dh_alua.c +2
-2@@ -190,8 +190,8 @@ static int submit_stpg(struct scsi_device *sdev, int group_id, ALUA_FAILOVER_RETRIES, NULL, req_flags); } -struct alua_port_group *alua_find_get_pg (char *id_str,size_t id_size, -int group_id) +static struct alua_port_group *alua_find_get_pg (char *id_str,size_t id_size, +int group_id) {struct alua_port_group *pg;
drivers/scsi/device_handler/scsi_dh_alua.c struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size, · line 226
Quoted 10 lines
drivers/scsi/device_handler/scsi_dh_alua.c +2
-2@@ -219,8 +219,8 @@ struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size,* Allocate a new port_group structure for a given * device. */ -struct alua_port_group *alua_alloc_pg (struct scsi_device *sdev, -int group_id,int tpgs) +static struct alua_port_group *alua_alloc_pg (struct scsi_device *sdev, +int group_id,int tpgs) {struct alua_port_group *pg, *tmp_pg;
Reviewed-by Hannes Reinecke <[email protected]>
Cheers,
Hannes
Signature · 9 lines
Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Martin K. Petersen
AppliedQuoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Bart" == Bart Van Assche <[email protected]> writes:
Bart> This patch avoids that building with W=1 causes gcc to report the Bart> following type of warning:
Bart> no previous prototype for ... [-Wmissing-prototypes]
Applied to 4.7/scsi-queue.
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering