Change in override behavior?

DISCUSSION Gary Thomas 5 participants 12 messages Apr 29, 2016 – Jun 3, 2016

Share & tools

Gary Thomas

author

2016-04-29 04:24 UTC #0 lore raw

I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"

This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"

Has this changed (recently)? Why? How to I make use of overrides?

Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28

Signature · 4 lines

------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Paul Eggleton

2016-04-29 05:08 UTC #1 lore raw

Hi Gary,

Quoted 7 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:

I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"

Quoted 7 lines

This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28

When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?

You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you sure you are seeing what you think you're seeing? If so, is the bbappend in fact being applied? Because if what you describe was really happening then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Gary Thomas

author

2016-04-29 06:06 UTC #2 lore raw

Quoted 21 lines · Paul Eggleton

Hi Gary,
Quoted 7 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:
I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"
Quoted 7 lines
This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28
When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?

Quoted 11 lines

You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you sure you are seeing what you think you're seeing? If so, is the bbappend in fact being applied? Because if what you describe was really happening then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.

Yes, I am using 'bitbake -e <recipe> | grep ^VARIABLE' to look at this.

In my main recipe, I have this:
SOME_OTHER_VARIABLE ?= "${MACHINE}"
and my .bbappend for that recipe has these lines:
SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
and local.conf has
MACHINE="my-target-B"

With Yocto 2.0 (Poky ceeb52a2544) I get this:
SOME_OTHER_VARIABLE = "something-else2" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"

With today's (Poky a9b503b26) I get this:
SOME_OTHER_VARIABLE = "my-target-B" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"

I also use this mechanism to set COMPATIBLE_MACHINE a lot and that doesn't seem to be working the same either.

Am I doing something incorrectly (and just got away with it for years)?

n.b. If you're interested, I can share the .bb/.bbappend files with you privately (I can't put them on the public list)

Signature · 4 lines

------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Paul Eggleton

2016-04-29 07:17 UTC #3 lore raw

Quoted 57 lines · On Fri, 29 Apr 2016 08:06:16 Gary Thomas wrote:

Quoted 24 lines · Paul Eggleton
Quoted 11 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:
I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"
Quoted 8 lines
This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28
When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?
Quoted 11 lines
You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you sure you are seeing what you think you're seeing? If so, is the bbappend in fact being applied? Because if what you describe was really happening then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.
Yes, I am using 'bitbake -e <recipe> | grep ^VARIABLE' to look at this.
In my main recipe, I have this:
   SOME_OTHER_VARIABLE ?= "${MACHINE}"
and my .bbappend for that recipe has these lines:
SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
and local.conf has
MACHINE="my-target-B"
With Yocto 2.0 (Poky ceeb52a2544) I get this:
SOME_OTHER_VARIABLE = "something-else2" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
With today's (Poky a9b503b26) I get this:
SOME_OTHER_VARIABLE = "my-target-B" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"

Quoted 7 lines

I also use this mechanism to set COMPATIBLE_MACHINE a lot and that doesn't seem to be working the same either.
Am I doing something incorrectly (and just got away with it for years)?
n.b. If you're interested, I can share the .bb/.bbappend files with you privately (I can't put them on the public list)

Ah, one thing... do your machine names have uppercase characters in them (as your pseudo-examples above do)? If so that was a 2.1 change; anything that is to be used as an override must now be lower case (so DISTRO, MACHINE, etc.)

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Gary Thomas

author

2016-04-29 07:24 UTC #4 lore raw

Quoted 61 lines · Paul Eggleton

Quoted 60 lines · On Fri, 29 Apr 2016 08:06:16 Gary Thomas wrote:
Quoted 24 lines · Paul Eggleton
Quoted 11 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:
I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"
Quoted 8 lines
This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28
When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?
Quoted 11 lines
You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you sure you are seeing what you think you're seeing? If so, is the bbappend in fact being applied? Because if what you describe was really happening then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.
Yes, I am using 'bitbake -e <recipe> | grep ^VARIABLE' to look at this.
In my main recipe, I have this:
    SOME_OTHER_VARIABLE ?= "${MACHINE}"
and my .bbappend for that recipe has these lines:
SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
and local.conf has
MACHINE="my-target-B"
With Yocto 2.0 (Poky ceeb52a2544) I get this:
SOME_OTHER_VARIABLE = "something-else2" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
With today's (Poky a9b503b26) I get this:
SOME_OTHER_VARIABLE = "my-target-B" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
I also use this mechanism to set COMPATIBLE_MACHINE a lot and that doesn't seem to be working the same either.

Quoted 8 lines

Quoted 4 lines
Am I doing something incorrectly (and just got away with it for years)?
n.b. If you're interested, I can share the .bb/.bbappend files with you privately (I can't put them on the public list)
Ah, one thing... do your machine names have uppercase characters in them (as your pseudo-examples above do)? If so that was a 2.1 change; anything that is to be used as an override must now be lower case (so DISTRO, MACHINE, etc.)

Indeed, my machine names do have an upper case letter in them. Any suggestions for how to handle this (short of renaming everything which would be a HUGE chore)?

Signature · 4 lines

------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Gary Thomas

author

2016-04-29 07:32 UTC #5 lore raw

Quoted 67 lines · Gary Thomas

Quoted 66 lines · Paul Eggleton
Quoted 64 lines · On Fri, 29 Apr 2016 08:06:16 Gary Thomas wrote:
Quoted 24 lines · Paul Eggleton
Quoted 11 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:
I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"
Quoted 8 lines
This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28
When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?
Quoted 11 lines
You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you sure you are seeing what you think you're seeing? If so, is the bbappend in fact being applied? Because if what you describe was really happening then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.
Yes, I am using 'bitbake -e <recipe> | grep ^VARIABLE' to look at this.
In my main recipe, I have this:
    SOME_OTHER_VARIABLE ?= "${MACHINE}"
and my .bbappend for that recipe has these lines:
SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
and local.conf has
MACHINE="my-target-B"
With Yocto 2.0 (Poky ceeb52a2544) I get this:
SOME_OTHER_VARIABLE = "something-else2" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
With today's (Poky a9b503b26) I get this:
SOME_OTHER_VARIABLE = "my-target-B" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
I also use this mechanism to set COMPATIBLE_MACHINE a lot and that doesn't seem to be working the same either.
Am I doing something incorrectly (and just got away with it for years)?
n.b. If you're interested, I can share the .bb/.bbappend files with you privately (I can't put them on the public list)

Quoted 8 lines

Quoted 3 lines
Ah, one thing... do your machine names have uppercase characters in them (as your pseudo-examples above do)? If so that was a 2.1 change; anything that is to be used as an override must now be lower case (so DISTRO, MACHINE, etc.)
Indeed, my machine names do have an upper case letter in them. Any suggestions for how to handle this (short of renaming everything which would be a HUGE chore)?

Query: I also use this mechanism for additional patches, etc, specified as SRC_URI_append_my-target-A and these are being handled correctly. Does the "append" mode behave differently?

Signature · 4 lines

------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Paul Eggleton

2016-04-29 09:51 UTC #6 lore raw

In reply to Gary Thomas

Quoted 70 lines · On Fri, 29 Apr 2016 09:24:23 Gary Thomas wrote:

Quoted 69 lines · Paul Eggleton
Quoted 67 lines · On Fri, 29 Apr 2016 08:06:16 Gary Thomas wrote:
Quoted 24 lines · Paul Eggleton
Quoted 11 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:
I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"
Quoted 8 lines
This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28
When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?
Quoted 11 lines
You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you sure you are seeing what you think you're seeing? If so, is the bbappend in fact being applied? Because if what you describe was really happening then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.
Yes, I am using 'bitbake -e <recipe> | grep ^VARIABLE' to look at this.
In my main recipe, I have this:
    SOME_OTHER_VARIABLE ?= "${MACHINE}"
and my .bbappend for that recipe has these lines:
SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
and local.conf has
MACHINE="my-target-B"
With Yocto 2.0 (Poky ceeb52a2544) I get this:
SOME_OTHER_VARIABLE = "something-else2" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
With today's (Poky a9b503b26) I get this:
SOME_OTHER_VARIABLE = "my-target-B" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
I also use this mechanism to set COMPATIBLE_MACHINE a lot and that doesn't seem to be working the same either.
Am I doing something incorrectly (and just got away with it for years)?
n.b. If you're interested, I can share the .bb/.bbappend files with you privately (I can't put them on the public list)

Quoted 8 lines

Quoted 4 lines
Ah, one thing... do your machine names have uppercase characters in them (as your pseudo-examples above do)? If so that was a 2.1 change; anything that is to be used as an override must now be lower case (so DISTRO, MACHINE, etc.)
Indeed, my machine names do have an upper case letter in them. Any suggestions for how to handle this (short of renaming everything which would be a HUGE chore)?

It's no longer supported I'm afraid, BitBake's datastore is now coded to expect lowercase for all override values. You say it's a huge chore but surely a grep -l | xargs -n1 sed -i would do it?

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Gary Thomas

author

2016-04-29 10:01 UTC #7 lore raw

Quoted 76 lines · Paul Eggleton

Quoted 75 lines · On Fri, 29 Apr 2016 09:24:23 Gary Thomas wrote:
Quoted 73 lines · Paul Eggleton
Quoted 60 lines · On Fri, 29 Apr 2016 08:06:16 Gary Thomas wrote:
Quoted 24 lines · Paul Eggleton
Quoted 11 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:
I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"
Quoted 8 lines
This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28
When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?
Quoted 11 lines
You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you sure you are seeing what you think you're seeing? If so, is the bbappend in fact being applied? Because if what you describe was really happening then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.
Yes, I am using 'bitbake -e <recipe> | grep ^VARIABLE' to look at this.
In my main recipe, I have this:
     SOME_OTHER_VARIABLE ?= "${MACHINE}"
and my .bbappend for that recipe has these lines:
SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
and local.conf has
MACHINE="my-target-B"
With Yocto 2.0 (Poky ceeb52a2544) I get this:
SOME_OTHER_VARIABLE = "something-else2" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
With today's (Poky a9b503b26) I get this:
SOME_OTHER_VARIABLE = "my-target-B" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
Quoted 7 lines
I also use this mechanism to set COMPATIBLE_MACHINE a lot and that doesn't seem to be working the same either.
Am I doing something incorrectly (and just got away with it for years)?
n.b. If you're interested, I can share the .bb/.bbappend files with you privately (I can't put them on the public list)
Ah, one thing... do your machine names have uppercase characters in them (as your pseudo-examples above do)? If so that was a 2.1 change; anything that is to be used as an override must now be lower case (so DISTRO, MACHINE, etc.)

Quoted 7 lines

Quoted 3 lines
Indeed, my machine names do have an upper case letter in them. Any suggestions for how to handle this (short of renaming everything which would be a HUGE chore)?
It's no longer supported I'm afraid, BitBake's datastore is now coded to expect lowercase for all override values. You say it's a huge chore but surely a grep -l | xargs -n1 sed -i would do it?

If I were to rename my target (MACHINE), I'd then have to go through and rename all of the directories in the recipes that hold machine customizations and there are quite a few of those. Similarly I'd have to rework all the recipes that use the old names (with upper case letters) to the new ones. Not impossible, but quite a lot of work.

Short of actually renaming the target machines, I could add an additional override (in <MACHINE>.conf) that is lowercase only and update just the recipes to use that instead.

By experimentation, I have found that XYZ_append_<MACHINE> seems to do the correct thing, even when <MACHINE> has upper case letters. Maybe this is an oversight that will be fixed?

Signature · 4 lines

------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Paul Eggleton

2016-04-29 10:09 UTC #8 lore raw

Quoted 92 lines · On Fri, 29 Apr 2016 12:00:58 Gary Thomas wrote:

Quoted 82 lines · Paul Eggleton
Quoted 81 lines · On Fri, 29 Apr 2016 09:24:23 Gary Thomas wrote:
Quoted 79 lines · Paul Eggleton
Quoted 65 lines · On Fri, 29 Apr 2016 08:06:16 Gary Thomas wrote:
Quoted 24 lines · Paul Eggleton
Quoted 11 lines · On Fri, 29 Apr 2016 06:24:55 Gary Thomas wrote:
I used to be able to use something like this:
VARIABLE = "xyz"
and maybe in a .bbappend use
VARIABLE_mymachine = "xyzzy"
where 'mymachine' is in OVERRIDES, which resulted in
VARIABLE = "xyzzy"
Quoted 8 lines
This doesn't seem to work the same today, what I get is
VARIABLE = "xyz"
VARIABLE_mymachine = "xyzzy"
Has this changed (recently)? Why? How to I make use of overrides?
Note: I'm using the latest Poky master (a9b503b26) updated 2016-04-28
When you say this is what you're seeing, how are you checking this? bitbake -e ? Which part of that output are you looking at?
Quoted 16 lines
You *will* now see VARIABLE_mymachine in bitbake -e output even if "mymachine" is in OVERRIDES - that's because the overridden values stay
in the datastore instead of a "finalisation" step eliminating them, in order to allow OVERRIDES to be changed dynamically (possibly multiple times) and still get the datastore contents you expect. That change was
made in the 2.0 release (jethro). However That should not affect the final value of VARIABLE if "mymachine" is in OVERRIDES however. Are you
sure you are seeing what you think you're seeing? If so, is the bbappend
in fact being applied? Because if what you describe was really happening
then pretty much the entire system would be broken. I just checked a similar case here and I see the expected results.
Yes, I am using 'bitbake -e <recipe> | grep ^VARIABLE' to look at this.
In my main recipe, I have this:
     SOME_OTHER_VARIABLE ?= "${MACHINE}"
and my .bbappend for that recipe has these lines:
SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
and local.conf has
MACHINE="my-target-B"
With Yocto 2.0 (Poky ceeb52a2544) I get this:
SOME_OTHER_VARIABLE = "something-else2" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
With today's (Poky a9b503b26) I get this:
SOME_OTHER_VARIABLE = "my-target-B" SOME_OTHER_VARIABLE_my-target-A = "something-else1" SOME_OTHER_VARIABLE_my-target-B = "something-else2"
Quoted 7 lines
I also use this mechanism to set COMPATIBLE_MACHINE a lot and that doesn't seem to be working the same either.
Am I doing something incorrectly (and just got away with it for years)?
n.b. If you're interested, I can share the .bb/.bbappend files with you privately (I can't put them on the public list)
Ah, one thing... do your machine names have uppercase characters in them (as your pseudo-examples above do)? If so that was a 2.1 change; anything
that is to be used as an override must now be lower case (so DISTRO, MACHINE, etc.)
Quoted 8 lines
Quoted 4 lines
Indeed, my machine names do have an upper case letter in them. Any suggestions for how to handle this (short of renaming everything which
would be a HUGE chore)?
It's no longer supported I'm afraid, BitBake's datastore is now coded to expect lowercase for all override values. You say it's a huge chore but surely a grep -l | xargs -n1 sed -i would do it?

Quoted 5 lines

If I were to rename my target (MACHINE), I'd then have to go through and rename all of the directories in the recipes that hold machine customizations and there are quite a few of those. Similarly I'd have to rework all the recipes that use the old names (with upper case letters) to the new ones. Not impossible, but quite a lot of work.

That is unfortunate, but again should be pretty easy to automate (assuming they are local of course and not proliferated across many users' build machines).

Quoted 7 lines

Short of actually renaming the target machines, I could add an additional override (in <MACHINE>.conf) that is lowercase only and update just the recipes to use that instead.
By experimentation, I have found that XYZ_append_<MACHINE> seems to do the correct thing, even when <MACHINE> has upper case letters. Maybe this is an oversight that will be fixed?

I'm not sure - Richard?

Cheers,
Paul

Signature · 2 lines

Paul Eggleton
Intel Open Source Technology Centre

Khem Raj

2016-04-30 02:19 UTC #9 lore raw

Quoted 8 lines · Paul Eggleton

Quoted 5 lines
By experimentation, I have found that XYZ_append_<MACHINE> seems to do the correct thing, even when <MACHINE> has upper case letters. Maybe this is an oversight that will be fixed?

This seems to be an oversight and should be fixed for consistency. packagers may have gripes about using uppercase too, not sure how thats working out in your case.

Richard Purdie

2016-05-24 12:32 UTC #10 lore raw

In reply to Paul Eggleton

Quoted 36 lines · Paul Eggleton

Quoted 15 lines · On Fri, 29 Apr 2016 12:00:58 Gary Thomas wrote:
Quoted 8 lines · Paul Eggleton
Quoted 6 lines · On Fri, 29 Apr 2016 09:24:23 Gary Thomas wrote:
On 2016-04-29 09:16, Paul Eggleton wrote:
Indeed, my machine names do have an upper case letter in them. Any suggestions for how to handle this (short of renaming everything
which
would be a HUGE chore)?
Quoted 5 lines
It's no longer supported I'm afraid, BitBake's datastore is now coded to
expect lowercase for all override values. You say it's a huge chore but
surely a grep -l | xargs -n1 sed -i would do it?
Quoted 7 lines
If I were to rename my target (MACHINE), I'd then have to go through
and rename all of the directories in the recipes that hold machine customizations and there are quite a few of those. Similarly I'd have to rework all the recipes that use the old names (with upper case
letters) to the new ones. Not impossible, but quite a lot of work.
That is unfortunate, but again should be pretty easy to automate (assuming
they are local of course and not proliferated across many users' build
machines).
Quoted 6 lines
Short of actually renaming the target machines, I could add an additional
override (in <MACHINE>.conf) that is lowercase only and update just the
recipes to use that instead.

Quoted 7 lines

Quoted 5 lines
By experimentation, I have found that XYZ_append_<MACHINE> seems to do
the correct thing, even when <MACHINE> has upper case letters.
Maybe this
is an oversight that will be fixed?
I'm not sure - Richard?

Sorry for the delay in getting to this. It does sound like there is a codepath in bitbake which is still recognising variables with mixed case. I took a quick look and think this change appears to address it:

bitbake/lib/bb/data_smart.py +1 -1

index 25c412c..ec6709f 100644
@@ -39,7 +39,7 @@ from bb.COW  import COWDictBase
 logger = logging.getLogger("BitBake.Data")
 
 __setvar_keyword__ = ["_append", "_prepend", "_remove"]
-__setvar_regexp__ = re.compile('(?P<base>.*?)(?P<keyword>_append|_prepend|_remove)(_(?P<add>.*))?$')
+__setvar_regexp__ = re.compile('(?P<base>.*?)(?P<keyword>_append|_prepend|_remove)(_(?P<add>[^A-Z]*))?$')
 __expand_var_regexp__ = re.compile(r"\${[^{}@\n\t :]+}")
 __expand_python_regexp__ = re.compile(r"\${@.+?}")

Cheers,

Richard

Andre McCurdy

2016-06-03 01:43 UTC #11 lore raw

Quoted 54 lines · Richard Purdie

Quoted 36 lines · Paul Eggleton
Quoted 15 lines · On Fri, 29 Apr 2016 12:00:58 Gary Thomas wrote:
Quoted 8 lines · Paul Eggleton
Quoted 6 lines · On Fri, 29 Apr 2016 09:24:23 Gary Thomas wrote:
On 2016-04-29 09:16, Paul Eggleton wrote:
Indeed, my machine names do have an upper case letter in them. Any suggestions for how to handle this (short of renaming everything
which
would be a HUGE chore)?
Quoted 5 lines
It's no longer supported I'm afraid, BitBake's datastore is now coded to
expect lowercase for all override values. You say it's a huge chore but
surely a grep -l | xargs -n1 sed -i would do it?
Quoted 7 lines
If I were to rename my target (MACHINE), I'd then have to go through
and rename all of the directories in the recipes that hold machine customizations and there are quite a few of those. Similarly I'd have to rework all the recipes that use the old names (with upper case
letters) to the new ones. Not impossible, but quite a lot of work.
That is unfortunate, but again should be pretty easy to automate (assuming
they are local of course and not proliferated across many users' build
machines).
Quoted 6 lines
Short of actually renaming the target machines, I could add an additional
override (in <MACHINE>.conf) that is lowercase only and update just the
recipes to use that instead.
Quoted 7 lines
Quoted 5 lines
By experimentation, I have found that XYZ_append_<MACHINE> seems to do
the correct thing, even when <MACHINE> has upper case letters.
Maybe this
is an oversight that will be fixed?
I'm not sure - Richard?
Sorry for the delay in getting to this. It does sound like there is a codepath in bitbake which is still recognising variables with mixed case. I took a quick look and think this change appears to address it:
bitbake/lib/bb/data_smart.py +0 -0
index 25c412c..ec6709f 100644

bitbake/lib/bb/data_smart.py from bb.COW import COWDictBase · line 44

Quoted 7 lines

bitbake/lib/bb/data_smart.py +1 -1

@@ -39,7 +39,7 @@ from bb.COW  import COWDictBase
 logger = logging.getLogger("BitBake.Data")
 
 __setvar_keyword__ = ["_append", "_prepend", "_remove"]
-__setvar_regexp__ = re.compile('(?P<base>.*?)(?P<keyword>_append|_prepend|_remove)(_(?P<add>.*))?$')
+__setvar_regexp__ = re.compile('(?P<base>.*?)(?P<keyword>_append|_prepend|_remove)(_(?P<add>[^A-Z]*))?$')
 __expand_var_regexp__ = re.compile(r"\${[^{}@\n\t :]+}")
 __expand_python_regexp__ = re.compile(r"\${@.+?}")

What about over-rides which contain only numbers?

It doesn't look like this change is going to filter them out, but they haven't worked as regular over-rides since:

http://git.openembedded.org/bitbake/commit/?id=c9b9443faa76ee7366b1400a56f826f3f9dec1be

(My personal preference for resolving that inconsistency would be to re-enable and officially support over-rides containing only numbers).

Quoted 9 lines

bitbake/lib/bb/data_smart.py +0 -0
 Cheers,
Richard
--
_______________________________________________
yocto mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/yocto