Skip to contentSkip to conversation

Mainline: Build error in drivers/nvdimm/pmem.c due to commit 658922e57b84

DISCUSSION Guenter Roeck 2 participants 2 messages May 6, 2016 Stable branch

lore
Share & tools
lore
#0 lore raw

alpha:allmodconfig fails to build with the following error.

drivers/nvdimm/pmem.c: In function 'nd_pfn_init':
drivers/nvdimm/pmem.c:407:17: error: 'HPAGE_SIZE' undeclared

Problem is due to commit 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing").

HPAGE_SIZE is not defined for all architectures and was up to now not used in driver code. All other architectures with 64 bit physical address provide the definition, though, as far as I can see, so it may be that only alpha is affected.

Since stable is copied - this will also result in stable build errors if applied to -stable branches.

Guenter

#1 lore raw
Quoted 8 lines · Guenter Roeck

alpha:allmodconfig fails to build with the following error.

drivers/nvdimm/pmem.c: In function 'nd_pfn_init':
drivers/nvdimm/pmem.c:407:17: error: 'HPAGE_SIZE' undeclared

Problem is due to commit 658922e57b84 ("libnvdimm, pfn: fix memmap reservation sizing").

Quoted 8 lines

HPAGE_SIZE is not defined for all architectures and was up to now not used in driver code. All other architectures with 64 bit physical address provide the
definition, though, as far as I can see, so it may be that only alpha is affected.

Since stable is copied - this will also result in stable build errors if applied to -stable branches.

Ah, sorry, I had only built alpha_defconfig before pushing that one. I'll send a follow on fix, thanks for the report.