fbdev: ssd1307fb: Fix charge pump setting

PATCH Tomi Valkeinen 1 participant 1 message May 10, 2016 Framebuffer layer

lore

Share & tools

lore

Tomi Valkeinen

author

2016-05-10 10:30 UTC #0 lore raw

Hi,

Quoted 17 lines · Julian Scheel

Make sure bit 4 is set for the charge pump setting. It is required according to SSD1306 App Note.
Signed-off-by Julian Scheel <[email protected]>
---
Changes in v2:
- Simplify commit message
- Use BIT macros to increase readability
---
 drivers/video/fbdev/ssd1307fb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/ssd1307fb.c +0 -0
index 1611215..3b9ee0c 100644

drivers/video/fbdev/ssd1307fb.c static int ssd1307fb_init(struct ssd1307fb_par *par) · line 394

Quoted 7 lines

drivers/video/fbdev/ssd1307fb.c +1 -1

@@ -389,7 +389,7 @@ static int ssd1307fb_init(struct ssd1307fb_par *par)
 		return ret;
 
 	ret = ssd1307fb_write_cmd(par->client,
-		(par->device_info->need_chargepump & 0x1 << 2) & 0x14);
+		BIT(4) | (par->device_info->need_chargepump ? BIT(2) : 0));
 	if (ret < 0)
 		return ret;

Thanks, queued for 4.7.

Tomi