CONFIG_ZBOOT_ROM_TEXT and CONFIG_ZBOOT_ROM_BSS in defconfig
Hello,
When reviewing my platform's defconfig, these two entries jumped out:
CONFIG_ZBOOT_ROM_TEXT=0x0CONFIG_ZBOOT_ROM_BSS=0x0
I found it odd that they would appear in the defconfig, since I don't care about them, and left them at their default value -- as most platforms seem to do:
$ git grep CONFIG_ZBOOT_ROM_TEXT=0x0 arch/arm/configs | wc -l 83
# Compressed boot loader in ROM. Yes, we really want to ask about # TEXT and BSS so we preserve their values in the config files. config ZBOOT_ROM_TEXT
hex "Compressed ROM boot loader base address" default "0"
It seems 'make savedefconfig' doesn't consider 0 and 0x0 to be equivalent.
I can submit a patch changing the default from 0 to 0x0, i.e. no functional change. The two entries would then disappear from defconfigs.
Arnd didn't seem to like the idea. How do others feel?
Regards.
Quoted 3 lines · Mason
I can submit a patch changing the default from 0 to
0x0, i.e. no functional change. The two entries would then disappear from defconfigs.
Specifically, this is what I meant:
arch/arm/Kconfig +2 -2
@@ -1823,7 +1823,7 @@ config DEPRECATED_PARAM_STRUCT # TEXT and BSS so we preserve their values in the config files. config ZBOOT_ROM_TEXT hex "Compressed ROM boot loader base address" - default "0" + default 0x0 help The physical address at which the ROM-able zImage is to be placed in the target. Platforms which normally make use of
@@ -1834,7 +1834,7 @@ config ZBOOT_ROM_TEXT config ZBOOT_ROM_BSS hex "Compressed ROM boot loader BSS address" - default "0" + default 0x0 help The base address of an area of read/write memory in the target for the ROM-able zImage which must be available while the
Quoted 32 lines · On Wed, 18 May 2016 10:30:17 +0200 Mason <[email protected]> wrote:
Quoted 3 lines · Mason
I can submit a patch changing the default from 0 to
0x0, i.e. no functional change. The two entries would then disappear from defconfigs.Specifically, this is what I meant:
arch/arm/Kconfig +2
-2@@ -1823,7 +1823,7 @@ config DEPRECATED_PARAM_STRUCT # TEXT and BSS so we preserve their values in the config files. config ZBOOT_ROM_TEXT hex "Compressed ROM boot loader base address" - default "0" + default 0x0 help The physical address at which the ROM-able zImage is to be placed in the target. Platforms which normally make use of@@ -1834,7 +1834,7 @@ config ZBOOT_ROM_TEXT config ZBOOT_ROM_BSS hex "Compressed ROM boot loader BSS address" - default "0" + default 0x0 help The base address of an area of read/write memory in thetarget for the ROM-able zImage which must be available while the
Quoted 4 lines
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
If the goal is to get rid of the 0x0's in the defconfigs, would it not be just as effective to drop those so they land at "0"?