Inclusion for 916d4092a1d2d7b in 4.4 stable

DISCUSSION Nikolay Borisov 2 participants 6 messages May 19, 2016 – May 20, 2016 1 message not in the archive Stable branch

lore

Share & tools

lore

Nikolay Borisov

author

2016-05-19 15:00 UTC #1 lore raw

In reply to a message not in the archive

[Resending since I did mistyped the stable mailing list address]

Quoted 24 lines · Nikolay Borisov

Quoted 23 lines · Greg KH
Quoted 19 lines · Nikolay Borisov
Quoted 11 lines
Hello Greg,
Turns out building perf is broken in the 4.4 kernel tree on centos6. Executing make in toosl/perf results in :
cc1: warnings being treated as errors
tests/llvm.c: In function ‘test_llvm__fetch_bpf_obj’:
tests/llvm.c:53: error: declaration of ‘index’ shadows a global declaration /usr/include/string.h:489: error: shadowed declaration is here
mv: cannot stat `tests/.llvm.o.tmp': No such file or directory
Quoted 5 lines
This can be fixed by applying the following commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=916d4092a1d2d7bb50630497be71ee4c4c2807fa
Would it be possible to apply it for 4.4.12 otherwise using perf from that tree is useless?
Is this something that recently broke? Or has it always been an issue?

Quoted 8 lines

Quoted 5 lines
According to the Fixes tags in the commit this broke in the following
series: http://marc.info/?l=linux-kernel&m=144681782820358
Which was applied in November 6. 2015. So I'd say it's been fairly recently.
So it's always been broken in 4.4? Or did I break it in a newer release?

Before that I was on 3.12 stable and everything worked, so I guess it did break in the release which included the aforementioned patches.

Quoted 8 lines

I'll queue it up for the next round of patches, but it seems odd that no one has reported this before, so trying to figure out why...
thanks,
greg k-h

Greg KH

maintainer

2016-05-19 15:33 UTC #2 lore raw

Quoted 29 lines · Nikolay Borisov

[Resending since I did mistyped the stable mailing list address]
Quoted 27 lines · Nikolay Borisov
Quoted 26 lines · Greg KH
Quoted 12 lines · Nikolay Borisov
Quoted 11 lines
Hello Greg,
Turns out building perf is broken in the 4.4 kernel tree on centos6. Executing make in toosl/perf results in :
cc1: warnings being treated as errors
tests/llvm.c: In function ‘test_llvm__fetch_bpf_obj’:
tests/llvm.c:53: error: declaration of ‘index’ shadows a global declaration /usr/include/string.h:489: error: shadowed declaration is here
mv: cannot stat `tests/.llvm.o.tmp': No such file or directory
Quoted 7 lines
Quoted 5 lines
This can be fixed by applying the following commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=916d4092a1d2d7bb50630497be71ee4c4c2807fa
Would it be possible to apply it for 4.4.12 otherwise using perf from that tree is useless?
Is this something that recently broke? Or has it always been an issue?
According to the Fixes tags in the commit this broke in the following
series: http://marc.info/?l=linux-kernel&m=144681782820358

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
Which was applied in November 6. 2015. So I'd say it's been fairly recently.
So it's always been broken in 4.4? Or did I break it in a newer release?
Before that I was on 3.12 stable and everything worked, so I guess it did break in the release which included the aforementioned patches.

That's not what I need to know. Is 4.4.0 broken? If not, then I worry, if so, then there's not really anything interesting here. Unless 4.6.0 also works. Does it?

We need some help narrowing this down if you want to see it resolved.

thanks,

greg k-h

Nikolay Borisov

author

2016-05-20 06:19 UTC #3 lore raw

Quoted 36 lines · Greg KH

Quoted 35 lines · Nikolay Borisov
[Resending since I did mistyped the stable mailing list address]
Quoted 32 lines · Nikolay Borisov
Quoted 21 lines · Greg KH
Quoted 18 lines · Nikolay Borisov
Quoted 16 lines
Hello Greg,
Turns out building perf is broken in the 4.4 kernel tree on centos6. Executing make in toosl/perf results in :
cc1: warnings being treated as errors
tests/llvm.c: In function ‘test_llvm__fetch_bpf_obj’:
tests/llvm.c:53: error: declaration of ‘index’ shadows a global declaration /usr/include/string.h:489: error: shadowed declaration is here
mv: cannot stat `tests/.llvm.o.tmp': No such file or directory
This can be fixed by applying the following commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=916d4092a1d2d7bb50630497be71ee4c4c2807fa
Would it be possible to apply it for 4.4.12 otherwise using perf from that tree is useless?
Quoted 7 lines
Quoted 1 line
Is this something that recently broke? Or has it always been an issue?
According to the Fixes tags in the commit this broke in the following
series: http://marc.info/?l=linux-kernel&m=144681782820358
Which was applied in November 6. 2015. So I'd say it's been fairly recently.
So it's always been broken in 4.4? Or did I break it in a newer release?

Quoted 6 lines

Quoted 2 lines
Before that I was on 3.12 stable and everything worked, so I guess it did break in the release which included the aforementioned patches.
That's not what I need to know. Is 4.4.0 broken? If not, then I worry, if so, then there's not really anything interesting here. Unless 4.6.0 also works. Does it?

Just tested, so 4.4.0 is broken, 4.6 works.

Quoted 7 lines

We need some help narrowing this down if you want to see it resolved.
thanks,
greg k-h

Greg KH

maintainer

2016-05-20 06:31 UTC #4 lore raw

Quoted 39 lines · Nikolay Borisov

Quoted 36 lines · Greg KH
Quoted 35 lines · Nikolay Borisov
[Resending since I did mistyped the stable mailing list address]
Quoted 32 lines · Nikolay Borisov
Quoted 21 lines · Greg KH
Quoted 18 lines · Nikolay Borisov
Quoted 16 lines
Hello Greg,
Turns out building perf is broken in the 4.4 kernel tree on centos6. Executing make in toosl/perf results in :
cc1: warnings being treated as errors
tests/llvm.c: In function ‘test_llvm__fetch_bpf_obj’:
tests/llvm.c:53: error: declaration of ‘index’ shadows a global declaration /usr/include/string.h:489: error: shadowed declaration is here
mv: cannot stat `tests/.llvm.o.tmp': No such file or directory
This can be fixed by applying the following commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=916d4092a1d2d7bb50630497be71ee4c4c2807fa
Would it be possible to apply it for 4.4.12 otherwise using perf from that tree is useless?
Quoted 7 lines
Quoted 1 line
Is this something that recently broke? Or has it always been an issue?
According to the Fixes tags in the commit this broke in the following
series: http://marc.info/?l=linux-kernel&m=144681782820358
Which was applied in November 6. 2015. So I'd say it's been fairly recently.
So it's always been broken in 4.4? Or did I break it in a newer release?

Quoted 8 lines

Quoted 6 lines
Quoted 2 lines
Before that I was on 3.12 stable and everything worked, so I guess it did break in the release which included the aforementioned patches.
That's not what I need to know. Is 4.4.0 broken? If not, then I worry, if so, then there's not really anything interesting here. Unless 4.6.0 also works. Does it?
Just tested, so 4.4.0 is broken, 4.6 works.

Great, can you use 'git bisect' to find the patch that fixes it?

Nikolay Borisov

author

2016-05-20 06:34 UTC #5 lore raw

Quoted 43 lines · Greg KH

Quoted 42 lines · Nikolay Borisov
Quoted 39 lines · Greg KH
Quoted 37 lines · Nikolay Borisov
[Resending since I did mistyped the stable mailing list address]
Quoted 24 lines · Nikolay Borisov
Quoted 23 lines · Greg KH
Quoted 19 lines · Nikolay Borisov
Quoted 11 lines
Hello Greg,
Turns out building perf is broken in the 4.4 kernel tree on centos6. Executing make in toosl/perf results in :
cc1: warnings being treated as errors
tests/llvm.c: In function ‘test_llvm__fetch_bpf_obj’:
tests/llvm.c:53: error: declaration of ‘index’ shadows a global declaration /usr/include/string.h:489: error: shadowed declaration is here
mv: cannot stat `tests/.llvm.o.tmp': No such file or directory
Quoted 5 lines
This can be fixed by applying the following commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=916d4092a1d2d7bb50630497be71ee4c4c2807fa
Would it be possible to apply it for 4.4.12 otherwise using perf from that tree is useless?
Is this something that recently broke? Or has it always been an issue?
Quoted 8 lines
Quoted 5 lines
According to the Fixes tags in the commit this broke in the following
series: http://marc.info/?l=linux-kernel&m=144681782820358
Which was applied in November 6. 2015. So I'd say it's been fairly recently.
So it's always been broken in 4.4? Or did I break it in a newer release?
Before that I was on 3.12 stable and everything worked, so I guess it did break in the release which included the aforementioned patches.

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
That's not what I need to know. Is 4.4.0 broken? If not, then I worry, if so, then there's not really anything interesting here. Unless 4.6.0 also works. Does it?
Just tested, so 4.4.0 is broken, 4.6 works.
Great, can you use 'git bisect' to find the patch that fixes it?

Well, I have given you a link to this patch in my first email. I can't understand what the problem here is ?

Quoted 1 line

Greg KH

maintainer

2016-05-20 17:36 UTC #6 lore raw

Quoted 50 lines · Nikolay Borisov

Quoted 47 lines · Greg KH
Quoted 46 lines · Nikolay Borisov
Quoted 42 lines · Greg KH
Quoted 29 lines · Nikolay Borisov
[Resending since I did mistyped the stable mailing list address]
Quoted 27 lines · Nikolay Borisov
Quoted 26 lines · Greg KH
Quoted 12 lines · Nikolay Borisov
Quoted 11 lines
Hello Greg,
Turns out building perf is broken in the 4.4 kernel tree on centos6. Executing make in toosl/perf results in :
cc1: warnings being treated as errors
tests/llvm.c: In function ‘test_llvm__fetch_bpf_obj’:
tests/llvm.c:53: error: declaration of ‘index’ shadows a global declaration /usr/include/string.h:489: error: shadowed declaration is here
mv: cannot stat `tests/.llvm.o.tmp': No such file or directory
Quoted 7 lines
Quoted 5 lines
This can be fixed by applying the following commit:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=916d4092a1d2d7bb50630497be71ee4c4c2807fa
Would it be possible to apply it for 4.4.12 otherwise using perf from that tree is useless?
Is this something that recently broke? Or has it always been an issue?
According to the Fixes tags in the commit this broke in the following
series: http://marc.info/?l=linux-kernel&m=144681782820358
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Which was applied in November 6. 2015. So I'd say it's been fairly recently.
So it's always been broken in 4.4? Or did I break it in a newer release?
Before that I was on 3.12 stable and everything worked, so I guess it did break in the release which included the aforementioned patches.
That's not what I need to know. Is 4.4.0 broken? If not, then I worry, if so, then there's not really anything interesting here. Unless 4.6.0 also works. Does it?

Quoted 6 lines

Quoted 3 lines
Quoted 1 line
Just tested, so 4.4.0 is broken, 4.6 works.
Great, can you use 'git bisect' to find the patch that fixes it?
Well, I have given you a link to this patch in my first email. I can't understand what the problem here is ?

Doh, sorry, you are correct, I got confused here, thanks for being persistent...

greg k-h