drivers: of: of_reserved_mem: fixup the CMA alignment not to affect dma-coherent
Quoted 17 lines
Hello,
Quoted 13 lines · Rob Herring
Quoted 10 lines · Jaewon Kim
From: Jaewon <[email protected]>
There was an alignment mismatch issue for CMA and it was fixed by
commit1cc8e3458b51("drivers: of:of_reserved_mem: fixup the alignment with CMA setup"). However the way of the commit considers not only dma-contiguous(CMA) but also dma-coherent which has no that requirement.This patch checks more to distinguish dma-contiguous(CMA) from dma-coherent.
Signed-off-by Jaewon Kim <[email protected]>I suppose this needs to go to stable? If so, adding the stable tag and kernel version would be nice so I don't have to.
Hello
In my opinion, this patch is not that critical.
Commit 1cc8e3458b51 might move unaligned(pageblock size) dma-coherent region.
And this patch will move the region back to different address which is aligned less than pageblock size. But if you think it need to stable branch, please let me know how to add the stable tag.
Quoted 7 lines
Quoted 5 lines
Quoted 4 lines
--- drivers/of/of_reserved_mem.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)I'm looking for an ack from Marek on this.
Acked-by Marek Szyprowski <[email protected]>
Thank you for your Ack
Quoted 5 lines
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>