Port: fix compatibility header for Cygwin
Both patches merged into master and stable-0.9, thanks!
Mathieu
Quoted 26 lines · ----- On Jun 2, 2016, at 5:01 AM, Sebastien Boisvert [email protected] wrote:
Signed-off-by Sebastien Boisvert <[email protected]>---
urcu/syscall-compat.h| 4 ++++1 file changed, 4 insertions(+)urcu/syscall-compat.h +4
-1@@ -31,6 +31,10 @@#include <sys/syscall.h> #elif defined(__linux__) || defined(__GLIBC__)#include <syscall.h> + +#elif defined(__CYGWIN__) +/* Don't include anything on Cygwin. */ +#else #error "Add platform support to urcu/syscall-compat.h"#endif --2.8.3
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Signature · 7 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Thank you for reviewing the patches.
I noticed that I should have send an email with "[PATCH userspace-rcu 0/2]" in the subject before sending the 2 others.
My next stop is building LTTng-UST in Cygwin. I am not saying that it will work, but it will be fun.
Quoted 24 lines · Mathieu Desnoyers
Both patches merged into master and stable-0.9, thanks!
Mathieu
Quoted 18 lines · ----- On Jun 2, 2016, at 5:01 AM, Sebastien Boisvert [email protected] wrote:
Signed-off-by Sebastien Boisvert <[email protected]>---
urcu/syscall-compat.h| 4 ++++1 file changed, 4 insertions(+)urcu/syscall-compat.h +4
-0@@ -31,6 +31,10 @@#include <sys/syscall.h> #elif defined(__linux__) || defined(__GLIBC__)#include <syscall.h> + +#elif defined(__CYGWIN__) +/* Don't include anything on Cygwin. */ +#else
Quoted 9 lines
Quoted 8 lines
urcu/syscall-compat.h +0
-1#error "Add platform support to urcu/syscall-compat.h"#endif --2.8.3
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 8 lines · ----- On Jun 3, 2016, at 2:55 PM, Sebastien Boisvert [email protected] wrote:
Thank you for reviewing the patches.
I noticed that I should have send an email with "[PATCH userspace-rcu 0/2]" in the subject
before sending the 2 others.My next stop is building LTTng-UST in Cygwin. I am not saying that it will work, but it will be fun.
We did experimental ports of ust and tools to cygwin a while back. The main issue ended up being file descriptor passing not being supported on cygwin.
See the resulting prototypes here (for lttng 2.0):
http://git.lttng.org/?p=lttng-ust.git;a=shortlog;h=refs/heads/cygwin-2.0-experimental
http://git.lttng.org/?p=lttng-tools.git;a=shortlog;h=refs/heads/cygwin-2.0-experimental
Thanks,
Mathieu
Quoted 34 lines · Mathieu Desnoyers
Quoted 32 lines
Both patches merged into master and stable-0.9, thanks!
Mathieu
Quoted 26 lines · ----- On Jun 2, 2016, at 5:01 AM, Sebastien Boisvert [email protected] wrote:
Signed-off-by Sebastien Boisvert <[email protected]>---
urcu/syscall-compat.h| 4 ++++1 file changed, 4 insertions(+)urcu/syscall-compat.h +4
-1@@ -31,6 +31,10 @@#include <sys/syscall.h> #elif defined(__linux__) || defined(__GLIBC__)#include <syscall.h> + +#elif defined(__CYGWIN__) +/* Don't include anything on Cygwin. */ +#else #error "Add platform support to urcu/syscall-compat.h"#endif --2.8.3
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Signature · 7 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 11 lines · Mathieu Desnoyers
Quoted 8 lines · ----- On Jun 3, 2016, at 2:55 PM, Sebastien Boisvert [email protected] wrote:
Thank you for reviewing the patches.
I noticed that I should have send an email with "[PATCH userspace-rcu 0/2]" in the subject
before sending the 2 others.My next stop is building LTTng-UST in Cygwin. I am not saying that it will work, but it will be fun.
Quoted 7 lines
We did experimental ports of ust and tools to cygwin a while back. The main issue ended up being file descriptor passing not being supported on cygwin.
See the resulting prototypes here (for lttng 2.0):
http://git.lttng.org/?p=lttng-ust.git;a=shortlog;h=refs/heads/cygwin-2.0-experimental
I can see that the solution to the file descriptor passing was to pass VFS paths instead [1].
Are there other caveats ?
[1] http://git.lttng.org/?p=lttng-ust.git;a=commit;h=bf5ff35ed0a3a7f60e92d654a5b97e73b94da852
Quoted 33 lines
http://git.lttng.org/?p=lttng-tools.git;a=shortlog;h=refs/heads/cygwin-2.0-experimental
Thanks,
Mathieu
Quoted 26 lines · Mathieu Desnoyers
Quoted 24 lines
Both patches merged into master and stable-0.9, thanks!
Mathieu
Quoted 18 lines · ----- On Jun 2, 2016, at 5:01 AM, Sebastien Boisvert [email protected] wrote:
Signed-off-by Sebastien Boisvert <[email protected]>---
urcu/syscall-compat.h| 4 ++++1 file changed, 4 insertions(+)urcu/syscall-compat.h +4
-0@@ -31,6 +31,10 @@#include <sys/syscall.h> #elif defined(__linux__) || defined(__GLIBC__)#include <syscall.h> + +#elif defined(__CYGWIN__) +/* Don't include anything on Cygwin. */ +#else
Quoted 9 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
urcu/syscall-compat.h +0
-1#error "Add platform support to urcu/syscall-compat.h"#endif --2.8.3
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 16 lines · ----- On Jun 3, 2016, at 5:52 PM, Sebastien Boisvert [email protected] wrote:
Quoted 15 lines · Mathieu Desnoyers
Quoted 8 lines · ----- On Jun 3, 2016, at 2:55 PM, Sebastien Boisvert [email protected] wrote:
Thank you for reviewing the patches.
I noticed that I should have send an email with "[PATCH userspace-rcu 0/2]" in the subject
before sending the 2 others.My next stop is building LTTng-UST in Cygwin. I am not saying that it will work, but it will be fun.
We did experimental ports of ust and tools to cygwin a while back. The main issue ended up being file descriptor passing not being supported on cygwin.
Quoted 7 lines
Quoted 3 lines
See the resulting prototypes here (for lttng 2.0):
http://git.lttng.org/?p=lttng-ust.git;a=shortlog;h=refs/heads/cygwin-2.0-experimental
I can see that the solution to the file descriptor passing was to pass VFS paths instead [1].
Unfortunately this solution is inelegant and intrusive. If windows with "handles" can do something similar to FD passing over unix sockets, it would fit much better in our design.
Quoted 2 lines
Are there other caveats ?
Also, I think you need to use LTTNG_DEBUG_NOCLONE=1 when running sessiond, due to other cygwin limitations.
Other than that, not that I recall (it has been a few year...).
Thanks,
Mathieu
Quoted 46 lines
[1]
http://git.lttng.org/?p=lttng-ust.git;a=commit;h=bf5ff35ed0a3a7f60e92d654a5b97e73b94da852Quoted 41 lines
http://git.lttng.org/?p=lttng-tools.git;a=shortlog;h=refs/heads/cygwin-2.0-experimental
Thanks,
Mathieu
Quoted 34 lines · Mathieu Desnoyers
Quoted 32 lines
Both patches merged into master and stable-0.9, thanks!
Mathieu
Quoted 26 lines · ----- On Jun 2, 2016, at 5:01 AM, Sebastien Boisvert [email protected] wrote:
Signed-off-by Sebastien Boisvert <[email protected]>---
urcu/syscall-compat.h| 4 ++++1 file changed, 4 insertions(+)urcu/syscall-compat.h +4
-1@@ -31,6 +31,10 @@#include <sys/syscall.h> #elif defined(__linux__) || defined(__GLIBC__)#include <syscall.h> + +#elif defined(__CYGWIN__) +/* Don't include anything on Cygwin. */ +#else #error "Add platform support to urcu/syscall-compat.h"#endif --2.8.3
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Signature · 7 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev