v3.18-stable-queue and v4.1.y-stable-queue build failures
v3.18:
arm64:defconfig:
drivers/irqchip/irq-gic-v3.c: In function ‘gic_dist_init’:drivers/irqchip/irq-gic-v3.c:319:29: error: ‘GICD_IGROUPR’
drivers/irqchip/irq-gic-v3.c: In function ‘gic_cpu_init’:drivers/irqchip/irq-gic-v3.c:417:29: error: ‘GICR_IGROUPR0’ undeclared
All mips builds:
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:689:2: error: implicit declaration of function 'reserve_bootmem_region'
v4.1, all mips builds:
arch/mips/mm/cache.c: In function '__update_cache':arch/mips/mm/cache.c:134:26: error: implicit declaration of function 'kmap_atomic' arch/mips/mm/cache.c:142:4: error: implicit declaration of function '__kunmap_atomic'
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:690:2: error: implicit declaration of function 'reserve_bootmem_region'
Guenter
Quoted 18 lines · Guenter Roeck
v3.18:
arm64:defconfig:
drivers/irqchip/irq-gic-v3.c: In function ‘gic_dist_init’:drivers/irqchip/irq-gic-v3.c:319:29: error: ‘GICD_IGROUPR’
drivers/irqchip/irq-gic-v3.c: In function ‘gic_cpu_init’:drivers/irqchip/irq-gic-v3.c:417:29: error: ‘GICR_IGROUPR0’ undeclaredAll mips builds:
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:689:2: error: implicit declaration of function 'reserve_bootmem_region'v4.1, all mips builds:
Quoted 8 lines
arch/mips/mm/cache.c: In function '__update_cache':arch/mips/mm/cache.c:134:26: error: implicit declaration of function 'kmap_atomic'arch/mips/mm/cache.c:142:4: error: implicit declaration of function '__kunmap_atomic'
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:690:2: error: implicit declaration of function 'reserve_bootmem_region'Guenter
Thanks Guenter, all should be fixed now.
Thanks,
Sasha
Quoted 23 lines · Sasha Levin
Quoted 22 lines · Guenter Roeck
v3.18:
arm64:defconfig:
drivers/irqchip/irq-gic-v3.c: In function ‘gic_dist_init’:drivers/irqchip/irq-gic-v3.c:319:29: error: ‘GICD_IGROUPR’
drivers/irqchip/irq-gic-v3.c: In function ‘gic_cpu_init’:drivers/irqchip/irq-gic-v3.c:417:29: error: ‘GICR_IGROUPR0’ undeclaredAll mips builds:
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:689:2: error: implicit declaration of function 'reserve_bootmem_region'v4.1, all mips builds:
arch/mips/mm/cache.c: In function '__update_cache':arch/mips/mm/cache.c:134:26: error: implicit declaration of function 'kmap_atomic'arch/mips/mm/cache.c:142:4: error: implicit declaration of function '__kunmap_atomic'
Quoted 7 lines
Quoted 4 lines
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:690:2: error: implicit declaration of function 'reserve_bootmem_region'Guenter
Thanks Guenter, all should be fixed now.
Confirmed.
Can you let Greg know how you fixed the mips problem in mm/cache.c ? It now affects 4.4, 4.5, and 4.6 as well.
Thanks,
Guenter
Quoted 27 lines · Guenter Roeck
Quoted 26 lines · Sasha Levin
Quoted 25 lines · Guenter Roeck
v3.18:
arm64:defconfig:
drivers/irqchip/irq-gic-v3.c: In function ‘gic_dist_init’:drivers/irqchip/irq-gic-v3.c:319:29: error: ‘GICD_IGROUPR’
drivers/irqchip/irq-gic-v3.c: In function ‘gic_cpu_init’:drivers/irqchip/irq-gic-v3.c:417:29: error: ‘GICR_IGROUPR0’ undeclaredAll mips builds:
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:689:2: error: implicit declaration of function 'reserve_bootmem_region'v4.1, all mips builds:
arch/mips/mm/cache.c: In function '__update_cache':arch/mips/mm/cache.c:134:26: error: implicit declaration of function 'kmap_atomic'arch/mips/mm/cache.c:142:4: error: implicit declaration of function '__kunmap_atomic'
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:690:2: error: implicit declaration of function 'reserve_bootmem_region'
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Guenter
Thanks Guenter, all should be fixed now.
Confirmed.
Can you let Greg know how you fixed the mips problem in
mm/cache.c? It now affects 4.4, 4.5, and 4.6 as well.
So the commit that was supposed to get this fix was only introduced in 4.2, so I just removed it from the 3.18/4.1 trees, but I suspect Greg will need to do something else here.
Thanks,
Sasha
Quoted 13 lines · Sasha Levin
Quoted 13 lines
Quoted 13 lines
Quoted 10 lines
v4.1, all mips builds:
arch/mips/mm/cache.c: In function '__update_cache':arch/mips/mm/cache.c:134:26: error: implicit declaration of function 'kmap_atomic'arch/mips/mm/cache.c:142:4: error: implicit declaration of function '__kunmap_atomic'
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:690:2: error: implicit declaration of function 'reserve_bootmem_region'Guenter
Thanks Guenter, all should be fixed now.
Quoted 9 lines
Quoted 4 lines
Confirmed.
Can you let Greg know how you fixed the mips problem in
mm/cache.c? It now affects 4.4, 4.5, and 4.6 as well.So the commit that was supposed to get this fix was only introduced in 4.2, so I just removed it from the 3.18/4.1 trees, but I suspect Greg will need to do something else here.
I ended up reverting 'MIPS: Sync icache & dcache in set_pte_at' as well as 'MIPS: Handle highmem pages in __update_cache'. That results in a passing build at least for 4.4. No idea if it has side effects, though.
Guenter
Greg Kroah-Hartman
maintainerQuoted 19 lines · Guenter Roeck
Quoted 18 lines · Sasha Levin
Quoted 17 lines
Quoted 6 lines
Quoted 6 lines
v4.1, all mips builds:
arch/mips/mm/cache.c: In function '__update_cache':arch/mips/mm/cache.c:134:26: error: implicit declaration of function 'kmap_atomic'arch/mips/mm/cache.c:142:4: error: implicit declaration of function '__kunmap_atomic'Quoted 7 lines
Quoted 4 lines
arch/mips/kernel/setup.c: In function 'arch_mem_init':arch/mips/kernel/setup.c:690:2: error: implicit declaration of function 'reserve_bootmem_region'Guenter
Thanks Guenter, all should be fixed now.
Confirmed.
Can you let Greg know how you fixed the mips problem in
mm/cache.c? It now affects 4.4, 4.5, and 4.6 as well.
Quoted 7 lines
Quoted 4 lines
So the commit that was supposed to get this fix was only introduced in 4.2, so I just removed it from the 3.18/4.1 trees, but I suspect Greg will need to do something else here.
I ended up reverting 'MIPS: Sync icache & dcache in
set_pte_at' as well as 'MIPS: Handle highmem pages in__update_cache'. That results in a passing build at least for 4.4. No idea if it has side effects, though.
Hm, I did something else, I guess if anyone from MIPS cares about the stable trees, they will let us know...
thanks,
greg k-h