nl80211: avoid possible memleak on nl80211_set_reg

PATCH New Eduardo Abinader 1 participant 1 message Jun 6, 2016 802.11 (including cfg80211/NL80211)

lore

Share & tools

lore

Eduardo Abinader

author

2016-06-06 14:57 UTC #0 lore raw

PATCH 1/1 nl80211: avoid possible memleak on nl80211_set_reg

Setting NULL just after freeing regdomain.

Signed-off-by Eduardo Abinader <[email protected]>

---
 net/wireless/nl80211.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

net/wireless/nl80211.c +2 -1

index d120449..39d107d 100644
@@ -5839,10 +5839,11 @@ static int nl80211_set_reg(struct sk_buff *skb, struct genl_info *info)
 
 	r = set_regdom(rd, REGD_SOURCE_CRDA);
 	/* set_regdom took ownership */
-	rd = NULL;
 
  bad_reg:
 	kfree(rd);
+	rd = NULL;
+
 	return r;
 }
 #endif /* CONFIG_CFG80211_CRDA_SUPPORT */

Signature · 1 line

2.5.0