Skip to contentSkip to conversation

select on non-existing Kconfig option CRC32C

DISCUSSION Andreas Ziegler 3 participants 3 messages Jun 15, 2016 Crypto API

lore
Share & tools
lore

Andreas Ziegler

author
#0 lore raw

Hi Hendrik,

your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195.

The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist. Should I prepare a trivial patch to fix this up or would you like to do that on your side?

I found this issue by comparing yesterday's tree and today's tree using 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'.

Best regards,

Andreas

#1 lore raw
Quoted 5 lines · Andreas Ziegler

Hi Hendrik,

your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195.

Quoted 7 lines

The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist. Should I prepare a trivial patch to fix this up or would you like to do that on your side?

I found this issue by comparing yesterday's tree and today's tree using 'scripts/checkkconfigsymbols -f -d next-20160614..next-20160615'.

or should it select CRC32 or LIBCRC32C? (probably not the LIB... one)

Signature · 1 line
~Randy
#2 lore raw
In reply to Andreas Ziegler

Hi Andreas,

Quoted 6 lines · Andreas Ziegler

your patch "s390/crc32-vx: add crypto API module for optimized CRC-32
algorithms" showed up in linux-next today (next-20160615) as commit 364148e0b195.

The patch defines the Kconfig option CRYPTO_CRC32_S390 which 'select's CRC32C. However, this should probably have been CRYPTO_CRC32C, as CRC32C does not exist.

Thanks for informing me. Actually, the crc32-vx driver requires the __crc32c_le() function which is available by selecting CONFIG_CRC32. There is no need for CRYPTO_CRC32C. So this can be safely removed.

Quoted 2 lines

Should I prepare a trivial patch to fix this up or would you like to do that on your side?

Martin have already corrected the patch.

Thanks and kind regards,
Hendrik