VMW_PVSCSI: Change to update maintainer details (name, email)

PATCH In review Jim Gill 6 participants 14 messages Jun 17, 2016 – Jun 21, 2016

Subsystems (2)

SCSI VMware pvscsi driver

lore

Share & tools

lore

Jim Gill

author

2016-06-17 01:05 UTC #0 lore raw

PATCH 1/1 VMW_PVSCSI: Change to update maintainer details (name, email)

From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <[email protected]>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Signed-off-by Jim Gill <[email protected]>

---
 drivers/scsi/vmw_pvscsi.c | 2 +-
 drivers/scsi/vmw_pvscsi.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

drivers/scsi/vmw_pvscsi.c +1 -1

index 6164634..4a0d3cd 100644
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  *
- * Maintained by: Arvind Kumar <[email protected]>
+ * Maintained by: Jim Gill <[email protected]>
  *
  */

drivers/scsi/vmw_pvscsi.h +1 -1

index 12712c9..c097d2c 100644
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
  *
- * Maintained by: Arvind Kumar <[email protected]>
+ * Maintained by: Jim Gill <[email protected]>
  *
  */

Signature · 1 line

2.5.0

Arvind Kumar

Acked-by on v1 1/1

2016-06-17 01:19 UTC #1 lore raw

Looks fine to me.

Acked-by Arvind Kumar ([email protected])

Thanks!
Arvind
________________________________________
From: Jim Gill <[email protected]>
Sent: Thursday, June 16, 2016 6:05 PM
To: [email protected]; [email protected]
Cc: Arvind Kumar; [email protected]; [email protected]; [email protected]
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Signed-off-by Jim Gill <[email protected]>

---
  drivers/scsi/vmw_pvscsi.c | 2 +-
  drivers/scsi/vmw_pvscsi.h | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

drivers/scsi/vmw_pvscsi.c +1 -1

index 6164634..4a0d3cd 100644
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <[email protected]>
+ * Maintained by: Jim Gill <[email protected]>
   *
   */

drivers/scsi/vmw_pvscsi.h +1 -1

index 12712c9..c097d2c 100644
@@ -17,7 +17,7 @@
   * along with this program; if not, write to the Free Software
   * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
   *
- * Maintained by: Arvind Kumar <[email protected]>
+ * Maintained by: Jim Gill <[email protected]>
   *
   */

--
2.5.0

Julian Calaby

2016-06-17 01:48 UTC #2 lore raw

In reply to Jim Gill

Hi Jim,

Quoted 19 lines · Jim Gill

From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <[email protected]>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Signed-off-by Jim Gill <[email protected]>
---
 drivers/scsi/vmw_pvscsi.c | 2 +-
 drivers/scsi/vmw_pvscsi.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/vmw_pvscsi.c +0 -0
index 6164634..4a0d3cd 100644
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301

Quoted 4 lines

USA.
*
- * Maintained by: Arvind Kumar <[email protected]>
+ * Maintained by: Jim Gill <[email protected]>

Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant?

Thanks,

Signature · 4 lines

Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

Arvind Kumar

2016-06-17 02:03 UTC #3 lore raw

Hi Julian,

Thanks for spotting that. We will update that too.

I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file.

Thanks!
Arvind
________________________________________
From: Julian Calaby <[email protected]>
Sent: Thursday, June 16, 2016 6:48 PM
To: Jim Gill
Cc: [email protected]; Martin K. Petersen; Arvind Kumar; [email protected]; linux-scsi; [email protected]
Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)

Hi Jim,

Quoted 19 lines · Jim Gill

From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <[email protected]>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Signed-off-by Jim Gill <[email protected]>
---
 drivers/scsi/vmw_pvscsi.c | 2 +-
 drivers/scsi/vmw_pvscsi.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/vmw_pvscsi.c +0 -0
index 6164634..4a0d3cd 100644
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301

Quoted 4 lines

USA.
*
- * Maintained by: Arvind Kumar <[email protected]>
+ * Maintained by: Jim Gill <[email protected]>

Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant?

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY&m=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk&s=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM&e=

Julian Calaby

2016-06-17 02:18 UTC #4 lore raw

Hi Arvind,

Quoted 5 lines · Arvind Kumar

Hi Julian,
Thanks for spotting that. We will update that too.
I don't really see it as redundant rather as a quick reference instead of digging out the MAINTAINERS file and then search for vmw_pvscsi.c file. Specially for those readers who might not even know about the MAINTAINERS file.

You can use the get_maintainers script in the scripts directory to quickly get information from MAINTAINERS, i.e.:

./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

./scripts/get_maintainers.pl patchfile.patch

Thanks,

Julian Calaby

Quoted 47 lines

Thanks!
Arvind
________________________________________
From: Julian Calaby <[email protected]>
Sent: Thursday, June 16, 2016 6:48 PM
To: Jim Gill
Cc: [email protected]; Martin K. Petersen; Arvind Kumar; [email protected]; linux-scsi; [email protected]
Subject: Re: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Hi Jim,
Quoted 19 lines · Jim Gill
From 6a076cc00ec12c6f9cba58ee7e4c3dec49e1e7e5 Mon Sep 17 00:00:00 2001
From: Jim Gill <[email protected]>
Date: Thu, 16 Jun 2016 14:10:43 -0700
Subject: [PATCH] VMW_PVSCSI: Change to update maintainer details (name, email)
Signed-off-by Jim Gill <[email protected]>
---
 drivers/scsi/vmw_pvscsi.c | 2 +-
 drivers/scsi/vmw_pvscsi.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/vmw_pvscsi.c +0 -0
index 6164634..4a0d3cd 100644
@@ -17,7 +17,7 @@
  * along with this program; if not, write to the Free Software
  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
Quoted 4 lines
USA.
*
- * Maintained by: Arvind Kumar <[email protected]>
+ * Maintained by: Jim Gill <[email protected]>
Shouldn't you update MAINTAINERs too? And isn't having this information in these files redundant?
Thanks,
--
Julian Calaby
Email: [email protected]
Profile: https://urldefense.proofpoint.com/v2/url?u=http-3A__www.google.com_profiles_julian.calaby_&d=CwIBaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=bUMaNc7nC9xbXtaMJrOvIIPNpPH0chY2kdRsskQn6GY&m=JibRIMgSBQLffjc5PofQnpJ0k_gawmvafvIKpsEaMzk&s=CeVpY1FwvY9Qlb0VDeQUXeeL3kuVkcIKTZIC7exS6SM&e=

Signature · 4 lines

Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

Joe Perches

2016-06-17 02:33 UTC #5 lore raw

Quoted 1 line · Julian Calaby

./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c

just fyi: the script name is not plural

$ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
Arvind Kumar <[email protected]> (maintainer:VMware PVSCSI driver)
VMware PV-Drivers <[email protected]> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <[email protected]> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <[email protected]> (maintainer:SCSI SUBSYSTEM)
[email protected] (open list:VMware PVSCSI driver)
[email protected] (open list)

and another fyi:

get_maintainer.pl also has a rarely used "--file-emails" option to scan for what appears to be email addresses in specific files.

$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar <[email protected]> (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers <[email protected]> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <[email protected]> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <[email protected]> (maintainer:SCSI SUBSYSTEM)
[email protected] (open list:VMware PVSCSI driver)
[email protected] (open list)

note the "in file" after Arvind's name

Julian Calaby

2016-06-17 02:44 UTC #6 lore raw

Hi Joe,

Quoted 4 lines · Joe Perches

Quoted 1 line · Julian Calaby
./scripts/get_maintainers.pl -f drivers/scsi/vmw_pvscsi.c
just fyi: the script name is not plural

Thanks, must have typo'd it between running it and typing it into the email.

Quoted 21 lines

$ ./scripts/get_maintainer.pl  -f drivers/scsi/vmw_pvscsi.c
Arvind Kumar <[email protected]> (maintainer:VMware PVSCSI driver)
VMware PV-Drivers <[email protected]> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <[email protected]> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <[email protected]> (maintainer:SCSI SUBSYSTEM)
[email protected] (open list:VMware PVSCSI driver)
[email protected] (open list)

and another fyi:

get_maintainer.pl also has a rarely used "--file-emails" option to scan for what appears to be email addresses in specific files.

$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar <[email protected]> (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers <[email protected]> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <[email protected]> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <[email protected]> (maintainer:SCSI SUBSYSTEM)
[email protected] (open list:VMware PVSCSI driver)
[email protected] (open list)

Quoted 1 line

note the "in file" after Arvind's name

Didn't know this, however my point stands: the maintainer line in the file is redundant if we find maintainers through MAINTAINERS or the get_maintainer.pl script.

Thanks,

Signature · 4 lines

Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

Joe Perches

2016-06-17 03:04 UTC #7 lore raw

Quoted 1 line · Julian Calaby

Hi Joe,

rehi Julian.

Quoted 1 line · Joe Perches

[]

Quoted 11 lines

get_maintainer.pl also has a rarely used "--file-emails" option to scan for what appears to be email addresses in specific files.

$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar <[email protected]> (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers <[email protected]> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <[email protected]> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <[email protected]> (maintainer:SCSI SUBSYSTEM)
[email protected] (open list:VMware PVSCSI driver)
[email protected] (open list)

Quoted 4 lines

Quoted 1 line
note the "in file" after Arvind's name
Didn't know this, however my point stands: the maintainer line in the file is redundant if we find maintainers through MAINTAINERS or the get_maintainer.pl script.

Yes, I'm not suggesting anything else. Jim's name should appear in the MAINTAINERS file somewhere.

The question to me is whether or not Jim Gill is taking over the maintainership of the entire VMware PVSCSI driver or just a few files of it.

Julian Calaby

2016-06-17 03:11 UTC #8 lore raw

Hi Joe,

Quoted 4 lines · Joe Perches

Quoted 1 line · Julian Calaby
Hi Joe,
rehi Julian.

(I always put a salutation on my emails and always finish them with "Thanks," =) )

Quoted 18 lines

Quoted 1 line · Joe Perches
[]
Quoted 11 lines
Quoted 11 lines
get_maintainer.pl also has a rarely used "--file-emails" option to scan for what appears to be email addresses in specific files.
$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar <[email protected]> (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers <[email protected]> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <[email protected]> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <[email protected]> (maintainer:SCSI SUBSYSTEM)
[email protected] (open list:VMware PVSCSI driver)
[email protected] (open list)
Quoted 4 lines
Quoted 1 line
note the "in file" after Arvind's name
Didn't know this, however my point stands: the maintainer line in the file is redundant if we find maintainers through MAINTAINERS or the get_maintainer.pl script.

Quoted 6 lines

Yes, I'm not suggesting anything else. Jim's name should appear in the MAINTAINERS file somewhere.
The question to me is whether or not Jim Gill is taking over the maintainership of the entire VMware PVSCSI driver or just a few files of it.

As I see it, he's taking over maintainership of all of it: it's only files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.

Thanks,

Signature · 4 lines

Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/

Thomas Hellstrom

2016-06-17 07:55 UTC #9 lore raw

Hi!

IMO we shouldn't have maintainer info mentioned in the source files, since the information is redundant and moreover if we change maintainer a patch touching multiple files would just look odd, and we'd leave a lot of stale info in older kernels.

Having the linux git *master* MAINTAINERS file as the authoritative information source for this makes most sense. If there are different maintainers of different parts of a single module we should be able to sort that out internally.

Thanks,
Thomas

Quoted 37 lines · Julian Calaby

Hi Joe,
Quoted 3 lines · Joe Perches
Quoted 1 line · Julian Calaby
Hi Joe,
rehi Julian.
(I always put a salutation on my emails and always finish them with "Thanks," =) )
Quoted 17 lines
Quoted 1 line · Joe Perches
[]
Quoted 11 lines
Quoted 11 lines
get_maintainer.pl also has a rarely used "--file-emails" option to scan for what appears to be email addresses in specific files.
$ ./scripts/get_maintainer.pl  -f --file-emails drivers/scsi/vmw_pvscsi.c
Arvind Kumar <[email protected]> (maintainer:VMware PVSCSI driver,in file)
VMware PV-Drivers <[email protected]> (maintainer:VMware PVSCSI driver)
"James E.J. Bottomley" <[email protected]> (maintainer:SCSI SUBSYSTEM)
"Martin K. Petersen" <[email protected]> (maintainer:SCSI SUBSYSTEM)
[email protected] (open list:VMware PVSCSI driver)
[email protected] (open list)
Quoted 4 lines
Quoted 1 line
note the "in file" after Arvind's name
Didn't know this, however my point stands: the maintainer line in the file is redundant if we find maintainers through MAINTAINERS or the get_maintainer.pl script.
Quoted 6 lines
Yes, I'm not suggesting anything else. Jim's name should appear in the MAINTAINERS file somewhere.
The question to me is whether or not Jim Gill is taking over the maintainership of the entire VMware PVSCSI driver or just a few files of it.
As I see it, he's taking over maintainership of all of it: it's only files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.
Thanks,

Jim Gill

author

2016-06-17 17:44 UTC #10 lore raw

In reply to Julian Calaby

Quoted 10 lines · Julian Calaby

[]
Quoted 5 lines
Quoted 1 line · Joe Perches
[]
The question to me is whether or not Jim Gill is
taking over the maintainership of the entire
VMware PVSCSI driver or just a few files of it.
As I see it, he's taking over maintainership of all of it: it's only files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.

This is correct, I am taking over maintainership of the entire vmw_pvscsi driver.

Joe Perches

2016-06-17 18:06 UTC #11 lore raw

Quoted 9 lines · Jim Gill

Quoted 5 lines · Julian Calaby
[]
Quoted 2 lines
Quoted 2 lines

Quoted 8 lines

Quoted 7 lines
Quoted 5 lines
Quoted 1 line · Joe Perches
[]
The question to me is whether or not Jim Gill is
taking over the maintainership of the entire
VMware PVSCSI driver or just a few files of it.
As I see it, he's taking over maintainership of all of it: it's only files are drivers/scsi/vmw_pvscsi.[ch] AFAIK.
This is correct, I am taking over maintainership of the entire vmw_pvscsi driver.

Perhaps a patch like this:

From e727c6549e3be466ec3c79e919502cb0b9909b03 Mon Sep 17 00:00:00 2001
Message-Id: <e727c6549e3be466ec3c79e919502cb0b9909b03.1466186573.git.joe@perches.com>
From: Joe Perches <[email protected]>
Date: Fri, 17 Jun 2016 10:56:49 -0700
Subject: [PATCH] vmw_pvscsi: Move into separate directory, Jim Gill is MAINTAINER

Separate directories for drivers are generally better.

Miscellanea:

o Update the MAINTAINER entry
o Remove maintainer and FSF addresses from driver files
---
MAINTAINERS | 5 ++--- drivers/scsi/Kconfig | 8 +------- drivers/scsi/Makefile | 2 +- drivers/scsi/vmware/Kconfig | 7 +++++++ drivers/scsi/vmware/Makefile | 1 + drivers/scsi/{ => vmware}/vmw_pvscsi.c | 7 ------- drivers/scsi/{ => vmware}/vmw_pvscsi.h | 7 -------

 7 files changed, 12 insertions(+), 25 deletions(-)

create mode 100644 drivers/scsi/vmware/Kconfig create mode 100644 drivers/scsi/vmware/Makefile rename drivers/scsi/{ => vmware}/vmw_pvscsi.c (99%) rename drivers/scsi/{ => vmware}/vmw_pvscsi.h (98%)

MAINTAINERS +0 -0

index d174e34..2763582 100644
@@ -12421,12 +12421,11 @@ S:	Maintained

F: drivers/net/vmxnet3/

VMware PVSCSI driver
-M: Arvind Kumar <[email protected]>
+M: Jim Gill <[email protected]>
M: VMware PV-Drivers <[email protected]>
L: [email protected]
S: Maintained
-F: drivers/scsi/vmw_pvscsi.c
-F: drivers/scsi/vmw_pvscsi.h
+F: drivers/scsi/vmware/

VOLTAGE AND CURRENT REGULATOR FRAMEWORK
M: Liam Girdwood <[email protected]>

drivers/scsi/Kconfig +0 -0

index 1918f54..339c230 100644
@@ -576,13 +576,7 @@ config SCSI_FLASHPOINT

  substantial, so users of MultiMaster Host Adapters may not wish to include it.

-config VMWARE_PVSCSI
- tristate "VMware PVSCSI driver support"
- depends on PCI && SCSI && X86
- help
-   This driver supports VMware's para virtualized SCSI HBA.
-   To compile this driver as a module, choose M here: the
-   module will be called vmw_pvscsi.
+source "drivers/scsi/vmware/Kconfig"

config XEN_SCSI_FRONTEND
tristate "XEN SCSI frontend driver"

drivers/scsi/Makefile +0 -0

index 862ab4e..6cfefaa 100644
@@ -141,7 +141,7 @@ obj-$(CONFIG_BE2ISCSI)		+= libiscsi.o be2iscsi/

obj-$(CONFIG_SCSI_ESAS2R) += esas2r/
obj-$(CONFIG_SCSI_PMCRAID) += pmcraid.o
obj-$(CONFIG_SCSI_VIRTIO) += virtio_scsi.o
-obj-$(CONFIG_VMWARE_PVSCSI) += vmw_pvscsi.o
+obj-$(CONFIG_VMWARE_PVSCSI) += vmware/
obj-$(CONFIG_XEN_SCSI_FRONTEND) += xen-scsifront.o
obj-$(CONFIG_HYPERV_STORAGE) += hv_storvsc.o
obj-$(CONFIG_SCSI_WD719X) += wd719x.o

drivers/scsi/vmware/Kconfig new file +7 -0

new file mode 100644
index 0000000..3c0c53b
@@ -0,0 +1,7 @@
+config VMWARE_PVSCSI
+	tristate "VMware PVSCSI driver support"
+	depends on PCI && SCSI && X86
+	help
+	  This driver supports VMware's para virtualized SCSI HBA.
+	  To compile this driver as a module, choose M here: the
+	  module will be called vmw_pvscsi.

drivers/scsi/vmware/Makefile new file +1 -0

new file mode 100644
index 0000000..ae8d278
@@ -0,0 +1 @@
+obj-$(CONFIG_VMWARE_PVSCSI)    += vmw_pvscsi.o

drivers/scsi/vmware/vmw_pvscsi.c renamed from drivers/scsi/vmw_pvscsi.c +0 -0

similarity index 99%
rename from drivers/scsi/vmw_pvscsi.c
rename to drivers/scsi/vmware/vmw_pvscsi.c
index 6164634..eb1229e 100644
@@ -12,13 +12,6 @@

* MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
* NON INFRINGEMENT. See the GNU General Public License for more
* details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Maintained by: Arvind Kumar <[email protected]>
- *
*/

#include <linux/kernel.h>

drivers/scsi/vmware/vmw_pvscsi.h renamed from drivers/scsi/vmw_pvscsi.h +0 -0

similarity index 98%
rename from drivers/scsi/vmw_pvscsi.h
rename to drivers/scsi/vmware/vmw_pvscsi.h
index 12712c9..5f675b9 100644
@@ -12,13 +12,6 @@

Jim Gill

author

2016-06-17 18:16 UTC #12 lore raw

I don’t yet know enough to comment on the relocation of vmw_pvscsi into a new vmware folder. I was considering offering a new patch that removed the “maintained by” from the two source files and updated MAINTAINERS, but I’m happy to defer to people with more experience. I’m fine either way.

Quoted 145 lines · Joe Perches

Perhaps a patch like this:
From e727c6549e3be466ec3c79e919502cb0b9909b03 Mon Sep 17 00:00:00 2001
Message-Id: <e727c6549e3be466ec3c79e919502cb0b9909b03.1466186573.git.joe@perches.com>
From: Joe Perches <[email protected]>
Date: Fri, 17 Jun 2016 10:56:49 -0700
Subject: [PATCH] vmw_pvscsi: Move into separate directory, Jim Gill is MAINTAINER
Separate directories for drivers are generally better.
Miscellanea:
o Update the MAINTAINER entry
o Remove maintainer and FSF addresses from driver files
---
MAINTAINERS                            | 5 ++---
drivers/scsi/Kconfig                   | 8 +-------
drivers/scsi/Makefile                  | 2 +-
drivers/scsi/vmware/Kconfig            | 7 +++++++
drivers/scsi/vmware/Makefile           | 1 +
drivers/scsi/{ => vmware}/vmw_pvscsi.c | 7 -------
drivers/scsi/{ => vmware}/vmw_pvscsi.h | 7 -------
7 files changed, 12 insertions(+), 25 deletions(-)
create mode 100644 drivers/scsi/vmware/Kconfig create mode 100644 drivers/scsi/vmware/Makefile rename drivers/scsi/{ => vmware}/vmw_pvscsi.c (99%) rename drivers/scsi/{ => vmware}/vmw_pvscsi.h (98%)
MAINTAINERS +0 -0
index d174e34..2763582 100644
@@ -12421,12 +12421,11 @@ S:	Maintained
F: drivers/net/vmxnet3/
VMware PVSCSI driver
MAINTAINERS +1 -1
-M:	Arvind Kumar <[email protected]>
+M:	Jim Gill <[email protected]>
M: VMware PV-Drivers <[email protected]>
L: [email protected]
S: Maintained
MAINTAINERS +1 -2
-F:	drivers/scsi/vmw_pvscsi.c
-F:	drivers/scsi/vmw_pvscsi.h
+F:	drivers/scsi/vmware/
VOLTAGE AND CURRENT REGULATOR FRAMEWORK
M: Liam Girdwood <[email protected]>
drivers/scsi/Kconfig +1 -7
index 1918f54..339c230 100644
@@ -576,13 +576,7 @@ config SCSI_FLASHPOINT
 	  substantial, so users of MultiMaster Host Adapters may not
 	  wish to include it.
 
-config VMWARE_PVSCSI
-	tristate "VMware PVSCSI driver support"
-	depends on PCI && SCSI && X86
-	help
-	  This driver supports VMware's para virtualized SCSI HBA.
-	  To compile this driver as a module, choose M here: the
-	  module will be called vmw_pvscsi.
+source "drivers/scsi/vmware/Kconfig"
 
config XEN_SCSI_FRONTEND
tristate "XEN SCSI frontend driver"
drivers/scsi/Makefile +0 -0
index 862ab4e..6cfefaa 100644
@@ -141,7 +141,7 @@ obj-$(CONFIG_BE2ISCSI)		+= libiscsi.o be2iscsi/
obj-$(CONFIG_SCSI_ESAS2R) += esas2r/
obj-$(CONFIG_SCSI_PMCRAID) += pmcraid.o
obj-$(CONFIG_SCSI_VIRTIO) += virtio_scsi.o
drivers/scsi/Makefile +1 -1
-obj-$(CONFIG_VMWARE_PVSCSI)	+= vmw_pvscsi.o
+obj-$(CONFIG_VMWARE_PVSCSI)	+= vmware/
obj-$(CONFIG_XEN_SCSI_FRONTEND) += xen-scsifront.o
obj-$(CONFIG_HYPERV_STORAGE) += hv_storvsc.o
obj-$(CONFIG_SCSI_WD719X) += wd719x.o
drivers/scsi/vmware/Kconfig new file +7 -0
new file mode 100644
index 0000000..3c0c53b
@@ -0,0 +1,7 @@
+config VMWARE_PVSCSI
+	tristate "VMware PVSCSI driver support"
+	depends on PCI && SCSI && X86
+	help
+	  This driver supports VMware's para virtualized SCSI HBA.
+	  To compile this driver as a module, choose M here: the
+	  module will be called vmw_pvscsi.
drivers/scsi/vmware/Makefile new file +1 -0
new file mode 100644
index 0000000..ae8d278
@@ -0,0 +1 @@
+obj-$(CONFIG_VMWARE_PVSCSI)    += vmw_pvscsi.o
drivers/scsi/vmware/vmw_pvscsi.c renamed from drivers/scsi/vmw_pvscsi.c +0 -7
similarity index 99%
rename from drivers/scsi/vmw_pvscsi.c
rename to drivers/scsi/vmware/vmw_pvscsi.c
index 6164634..eb1229e 100644
@@ -12,13 +12,6 @@
 * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
 * NON INFRINGEMENT.  See the GNU General Public License for more
 * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Maintained by: Arvind Kumar <[email protected]>
- *
 */
 
 #include <linux/kernel.h>
drivers/scsi/vmware/vmw_pvscsi.h renamed from drivers/scsi/vmw_pvscsi.h +0 -7
similarity index 98%
rename from drivers/scsi/vmw_pvscsi.h
rename to drivers/scsi/vmware/vmw_pvscsi.h
index 12712c9..5f675b9 100644
@@ -12,13 +12,6 @@
 * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE or
 * NON INFRINGEMENT.  See the GNU General Public License for more
 * details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
- *
- * Maintained by: Arvind Kumar <[email protected]>
- *
 */
 
 #ifndef _VMW_PVSCSI_H_
Signature · 1 line
2.8.0.rc4.16.g56331f8

Martin K. Petersen

2016-06-21 02:01 UTC #13 lore raw

In reply to Jim Gill

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Jim" == Jim Gill <[email protected]> writes:

Updated MAINTAINERS accordingly and applied to 4.8/scsi-queue.

Signature · 1 line

Martin K. Petersen	Oracle Linux Engineering