Doc: add a CMake example
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 13 lines · Sebastien Boisvert
Hi Phil,
shortlog:
Sebastien Boisvert (16):
Doc: add CMake example
Doc: clean up cmake example
Doc: add atrace.shscript in the cmake example
Doc: clean up cmake file
Doc: fix English issue
Doc: rename cmake example
Doc: ship cmake example with 'make distcheck'
Doc: add FindLTTngUST CMake module
Quoted 8 lines
Doc: use standard way for building with CMake
Doc: use the FindLTTngUST CMake module configure.ac: check cmake availability configure.ac: check C++ compiler availability
Doc: remove a duplicate line
Doc: add missing cmake file in cmake example
Doc: create a variable for cmake directories
Doc: add the cmake example to the distcheck output
I guess you could squash all the "Doc" together, or almost, with title "Doc: add CMake example", and perhaps the configure.ac ones too.
Phil
Quoted 36 lines
diffstat:
configure.ac | 3 ++ doc/examples/Makefile.am | 38 ++++++++++++++++++++-- doc/examples/cmake-multiple-shared-libraries/CMakeLists.txt | 23 ++++++++++++++ doc/examples/cmake-multiple-shared-libraries/README.md | 52 ++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/aligner.cpp | 10 ++++++ doc/examples/cmake-multiple-shared-libraries/cmake/FindLTTngUST.cmake | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/tester.cpp | 15 +++++++++ doc/examples/cmake-multiple-shared-libraries/trace.sh | 9 ++++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.cpp | 6 ++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.h | 27 ++++++++++++++++ 14 files changed, 338 insertions(+), 2 deletions(-)
Quoted 1 line
Have a good one.
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
A message that is not in the archive (sent off-list or not yet received): CAB4xu_2ja=f9FeS2unm7+UD0=5yX9QAg-SZzQSEAT=tseq4oZQ@mail.gmail.com
Hi Phil,
After the reordering and squashing, I have 3 commits since commit 21ddb8ec9689e02944dae9cd4e5aba1ca2ab0d5b.
You can pull from
https://github.com/sebhtml/lttng-ust.git tags/for-phil-cmake-example.v5
To see the changes in a web browser: https://github.com/sebhtml/lttng-ust/commits/for-phil-cmake-example.v5
Sebastien Boisvert (3):
configure.ac: check cmake availability
Doc: add CMake example
Doc: ship cmake example with 'make distcheck'
Quoted 23 lines · Philippe Proulx
Quoted 13 lines · Sebastien Boisvert
Hi Phil,
shortlog:
Sebastien Boisvert (16):
Doc: add CMake example
Doc: clean up cmake example
Doc: add atrace.shscript in the cmake example
Doc: clean up cmake file
Doc: fix English issue
Doc: rename cmake example
Doc: ship cmake example with 'make distcheck'
Doc: add FindLTTngUST CMake moduleQuoted 8 lines
Doc: use standard way for building with CMake
Doc: use the FindLTTngUST CMake module configure.ac: check cmake availability configure.ac: check C++ compiler availability
Doc: remove a duplicate line
Doc: add missing cmake file in cmake example
Doc: create a variable for cmake directories
Doc: add the cmake example to the distcheck output
Quoted 42 lines
I guess you could squash all the "Doc" together, or almost, with title "Doc: add CMake example", and perhaps the configure.ac ones too.
Phil
Quoted 37 lines
diffstat:
configure.ac | 3 ++ doc/examples/Makefile.am | 38 ++++++++++++++++++++-- doc/examples/cmake-multiple-shared-libraries/CMakeLists.txt | 23 ++++++++++++++ doc/examples/cmake-multiple-shared-libraries/README.md | 52 ++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/aligner.cpp | 10 ++++++ doc/examples/cmake-multiple-shared-libraries/cmake/FindLTTngUST.cmake | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/tester.cpp | 15 +++++++++ doc/examples/cmake-multiple-shared-libraries/trace.sh | 9 ++++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.cpp | 6 ++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.h | 27 ++++++++++++++++ 14 files changed, 338 insertions(+), 2 deletions(-)Have a good one.
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
Quoted 23 lines · ----- On Jun 21, 2016, at 12:02 AM, Philippe Proulx [email protected]…
Quoted 13 lines · Sebastien Boisvert
Hi Phil,
shortlog:
Sebastien Boisvert (16):
Doc: add CMake example
Doc: clean up cmake example
Doc: add atrace.shscript in the cmake example
Doc: clean up cmake file
Doc: fix English issue
Doc: rename cmake example
Doc: ship cmake example with 'make distcheck'
Doc: add FindLTTngUST CMake moduleQuoted 8 lines
Doc: use standard way for building with CMake
Doc: use the FindLTTngUST CMake module configure.ac: check cmake availability configure.ac: check C++ compiler availability
Doc: remove a duplicate line
Doc: add missing cmake file in cmake example
Doc: create a variable for cmake directories
Doc: add the cmake example to the distcheck output
Quoted 2 lines
I guess you could squash all the "Doc" together, or almost, with title "Doc: add CMake example", and perhaps the configure.ac ones too.
+1, I prefer keeping a clean history in master whenever possible, so rebasing in this way makes sense.
Thanks,
Mathieu
Quoted 40 lines
Phil
Quoted 37 lines
diffstat:
configure.ac | 3 ++ doc/examples/Makefile.am | 38 ++++++++++++++++++++-- doc/examples/cmake-multiple-shared-libraries/CMakeLists.txt | 23 ++++++++++++++ doc/examples/cmake-multiple-shared-libraries/README.md | 52 ++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/aligner.cpp | 10 ++++++ doc/examples/cmake-multiple-shared-libraries/cmake/FindLTTngUST.cmake | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/tester.cpp | 15 +++++++++ doc/examples/cmake-multiple-shared-libraries/trace.sh | 9 ++++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.cpp | 6 ++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.h | 27 ++++++++++++++++ 14 files changed, 338 insertions(+), 2 deletions(-)Have a good one.
Signature · 7 lines
Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com _______________________________________________ lttng-dev mailing list [email protected] https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 25 lines · Mathieu Desnoyers
Quoted 23 lines · ----- On Jun 21, 2016, at 12:02 AM, Philippe Proulx [email protected]…
Quoted 21 lines · Sebastien Boisvert
Hi Phil,
shortlog:
Sebastien Boisvert (16):
Doc: add CMake example
Doc: clean up cmake example
Doc: add atrace.shscript in the cmake example
Doc: clean up cmake file
Doc: fix English issue
Doc: rename cmake example
Doc: ship cmake example with 'make distcheck'
Doc: add FindLTTngUST CMake module
Doc: use standard way for building with CMake
Doc: use the FindLTTngUST CMake module configure.ac: check cmake availability configure.ac: check C++ compiler availability
Doc: remove a duplicate line
Doc: add missing cmake file in cmake example
Doc: create a variable for cmake directories
Doc: add the cmake example to the distcheck output
Quoted 5 lines
Quoted 2 lines
I guess you could squash all the "Doc" together, or almost, with title "Doc: add CMake example", and perhaps the configure.ac ones too.
+1, I prefer keeping a clean history in master whenever possible, so rebasing in this way makes sense.
It makes sense to me too. I did the rebasing:
https://github.com/sebhtml/lttng-ust.git tags/for-phil-cmake-example.v5
Quoted 46 lines
Thanks,
Mathieu
Quoted 40 lines
Phil
Quoted 37 lines
diffstat:
configure.ac | 3 ++ doc/examples/Makefile.am | 38 ++++++++++++++++++++-- doc/examples/cmake-multiple-shared-libraries/CMakeLists.txt | 23 ++++++++++++++ doc/examples/cmake-multiple-shared-libraries/README.md | 52 ++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/aligner-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/aligner.cpp | 10 ++++++ doc/examples/cmake-multiple-shared-libraries/cmake/FindLTTngUST.cmake | 111 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.cpp | 16 ++++++++++ doc/examples/cmake-multiple-shared-libraries/tester-lib.h | 7 +++++ doc/examples/cmake-multiple-shared-libraries/tester.cpp | 15 +++++++++ doc/examples/cmake-multiple-shared-libraries/trace.sh | 9 ++++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.cpp | 6 ++++ doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.h | 27 ++++++++++++++++ 14 files changed, 338 insertions(+), 2 deletions(-)Have a good one.
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev