Skip to contentSkip to conversation

Doc: add a CMake example

GIT PULL Mathieu Desnoyers 1 participant 1 message Jun 27, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 18 lines · ----- On Jun 26, 2016, at 10:01 PM, Sebastien Boisvert [email protected]…

Hi Mathieu,

This is the version 7 of my pull request; it contains a CMake example in C++ which uses LTTng-UST
instrumentation in 2 shared libraries. Yes, this is v7. I started to count from v1, but the first that you
reviewed was v5 I think. Philippe helped me with v1 through v4/v5.

I looked at the comments from your code reviews (on both v5 and v6 [1]).

I implemented all the required changes (acked-by, style, whitespace lines, and so on).

I went the extra mile too. I also converted the 4-space indentations to tab indentations. Finally, I improved the tracepoints in the example such that it makes
more sense.

Quoted 8 lines

Philippe: I used the 'fixup' thing and I love it.

Mathieu, you can pull from

https://github.com/sebhtml/lttng-ust.git tags/for-compudj-cmake-example.v7

Just merged it. I added a coding style fix commit on top.

Thanks!

Mathieu

Quoted 58 lines

The changes can be viewed on github:

https://github.com/sebhtml/lttng-ust/commits/for-compudj-cmake-example.v7

Let me know if there should be a v8, given my previous misuse of git acked-by and signed-off tags.

shortlog

Sebastien Boisvert (3):
configure.ac: check cmake availability
Doc: add CMake example
Doc: ship cmake example with 'make distcheck'

diffstat

 configure.ac                                                          |   3 ++
 doc/examples/Makefile.am                                              |  38
 ++++++++++++++++++++--
 doc/examples/cmake-multiple-shared-libraries/CMakeLists.txt           |  23
 ++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/README.md                |  52
 ++++++++++++++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/aligner-lib.cpp          |  34
 ++++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/aligner-lib.h            |  30
 ++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/aligner.cpp              |  30
 ++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/cmake/FindLTTngUST.cmake | 111
 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/tester-lib.cpp           |  31
 ++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/tester-lib.h             |  30
 ++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/tester.cpp               |  35
 +++++++++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/trace.sh                 |   9
 ++++++
 doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.cpp  |  26
 +++++++++++++++
 doc/examples/cmake-multiple-shared-libraries/tracepoint-provider.h    |  60
 +++++++++++++++++++++++++++++++++++
 14 files changed, 510 insertions(+), 2 deletions(-)

References

[1] https://lists.lttng.org/pipermail/lttng-dev/2016-June/026255.html

Signature · 7 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
_______________________________________________
lttng-dev mailing list
[email protected]
https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev