Skip to contentSkip to conversation

tracing: Have HIST_TRIGGERS select TRACING

PATCH In review Tom Zanussi 2 participants 2 messages Jul 3, 2016 – Jul 5, 2016 Tracing

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tracing: Have HIST_TRIGGERS select TRACING

The kbuild test robot reported a compile error if HIST_TRIGGERS was enabled but nothing else that selected TRACING was configured in.

HIST_TRIGGERS should directly select it and not rely on anything else to do it.

---
 kernel/trace/Kconfig | 1 +
 1 file changed, 1 insertion(+)
kernel/trace/Kconfig +1 -0
index fafeaf8..f4b86e8 100644
@@ -542,6 +542,7 @@ config HIST_TRIGGERS
 	bool "Histogram triggers"
 	depends on ARCH_HAVE_NMI_SAFE_CMPXCHG
 	select TRACING_MAP
+	select TRACING
 	default n
 	help
 	  Hist triggers allow one or more arbitrary trace event fields
Signature · 1 line
1.9.3
maintainer
#1 lore raw
Quoted 6 lines · On Sun, 03 Jul 2016 08:51:34 -0500 Tom Zanussi <[email protected]>…

The kbuild test robot reported a compile error if HIST_TRIGGERS was enabled but nothing else that selected TRACING was configured in.

HIST_TRIGGERS should directly select it and not rely on anything else to do it.

I added:

Fixes 7ef224d1d0e3a ("tracing: Add 'hist' event trigger command")

This isn't that big of a deal, so I'm just going to put it into my queue for the next merge window.

-- Steve

Quoted 17 lines
---
 kernel/trace/Kconfig | 1 +
 1 file changed, 1 insertion(+)
kernel/trace/Kconfig +1 -0
index fafeaf8..f4b86e8 100644
@@ -542,6 +542,7 @@ config HIST_TRIGGERS
 	bool "Histogram triggers"
 	depends on ARCH_HAVE_NMI_SAFE_CMPXCHG
 	select TRACING_MAP
+	select TRACING
 	default n
 	help
 	  Hist triggers allow one or more arbitrary trace event fields