Skip to contentSkip to conversation

MIPS: Octeon: mark GPIO controller node not populated after IRQ init.

PATCH In review Steven J. Hill 2 participants 3 messages Aug 26, 2016 – Sep 26, 2016 1 message not in the archive MIPS

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 MIPS: Octeon: mark GPIO controller node not populated after IRQ init.

We clear the OF_POPULATED flag for the GPIO controller node on Octeon processors. Otherwise, none of the devices hanging on the GPIO lines are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition to other devices on Cavium 71xx and 78xx development boards.

Fixes 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")
---
 arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/cavium-octeon/octeon-irq.c +6 -0
index 5a9b87b..c1eb1ff 100644
@@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
 		return -ENOMEM;
 	}
 
+	/*
+	 * Clear the OF_POPULATED flag that was set by of_irq_init()
+	 * so that all GPIO devices will be probed.
+	 */
+	of_node_clear_flag(gpio_node, OF_POPULATED);
+
 	return 0;
 }
 /*
Signature · 1 line
1.9.1

A message that is not in the archive (sent off-list or not yet received): 57C0922C.40907-YGCgFSpz5w/[email protected]

#2 lore raw

Hi,

Quoted 8 lines · Steven J. Hill

We clear the OF_POPULATED flag for the GPIO controller node on Octeon processors. Otherwise, none of the devices hanging on the GPIO lines are probed. The 'gpio-leds' driver on OCTEON failed to probe in addition to other devices on Cavium 71xx and 78xx development boards.

Fixes 15cc2ed6dcf9 ("of/irq: Mark initialised interrupt controllers as populated")

Ralf, I think this patch should be still included in v4.8 final.

Thanks,

A.

Quoted 25 lines
---
 arch/mips/cavium-octeon/octeon-irq.c | 6 ++++++
 1 file changed, 6 insertions(+)
arch/mips/cavium-octeon/octeon-irq.c +6 -0
index 5a9b87b..c1eb1ff 100644
@@ -1619,6 +1619,12 @@ static int __init octeon_irq_init_gpio(
 		return -ENOMEM;
 	}
 
+	/*
+	 * Clear the OF_POPULATED flag that was set by of_irq_init()
+	 * so that all GPIO devices will be probed.
+	 */
+	of_node_clear_flag(gpio_node, OF_POPULATED);
+
 	return 0;
 }
 /*
Signature · 1 line
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 7 lines · Aaro Koskinen

Ralf, I think this patch should be still included in v4.8 final.

Thanks,

A.

Yes, please put it in 4.8 final. Thanks!