Skip to contentSkip to conversation

Fix no. of gpio cells in the pxa gpio binding doucmentation

PATCH In review Vijay Kumar 2 participants 2 messages Sep 5, 2016 – Sep 18, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix no. of gpio cells in the pxa gpio binding doucmentation

Fix the no. of gpio cells in pxa gpio binding documentation.

The no. of gpio cells for the pxa gpio is actually 2. But is incorrectly specified as 1, in the binding documentation. From the driver code, the second cell specifies the standard flags as described in gpio.txt.

Documentation/devicetree/bindings/gpio/mrvl-gpio.txt +4 -2
Index: linux-4.7.1/Documentation/devicetree/bindings/gpio/mrvl-gpio.txt
===================================================================
@@ -17,7 +17,9 @@ Required properties:
 - #interrupt-cells: Specifies the number of cells needed to encode an
   interrupt source.
 - gpio-controller : Marks the device node as a gpio controller.
-- #gpio-cells : Should be one.  It is the pin number.
+- #gpio-cells : Should be two.  The first cell is the pin number and
+  the second cell is used to specify flags. See gpio.txt for possible
+  values.
 
 Example for a MMP platform:
 
@@ -27,7 +29,7 @@ Example for a MMP platform:
 		interrupts = <49>;
 		interrupt-names = "gpio_mux";
 		gpio-controller;
-		#gpio-cells = <1>;
+		#gpio-cells = <2>;
 		interrupt-controller;
 		#interrupt-cells = <1>;
       };
#1 lore raw
Quoted 8 lines · Vijay Kumar

Fix the no. of gpio cells in pxa gpio binding documentation.

The no. of gpio cells for the pxa gpio is actually 2. But is incorrectly specified as 1, in the binding documentation. From the driver code, the second cell specifies the standard flags as described in gpio.txt.

Yes, that's correct. I'll add this to pxa/dt tree, thanks.

Cheers.

--
Robert