net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY
PATCH 1/1 net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY
Quoted 4 lines · sbabic at denx.de
Quoted 4 lines
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode.
[...]
Quoted 1 line
Applied to u-boot-imx, master, thanks !
Didn't this fail to build on mx25 ?
PATCH 1/1 net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY
Hi Marek,
Quoted 11 lines · Marek Vasut
Quoted 4 lines · sbabic at denx.de
Quoted 4 lines
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode.
[...]
Quoted 1 line
Applied to u-boot-imx, master, thanks !
Didn't this fail to build on mx25 ?
Yes, sorry, this is a false positive - patch has not been applied.
Regards,
Stefano
PATCH 1/1 net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY
Quoted 10 lines · Stefano Babic
Hi Marek,
Quoted 6 lines · Marek Vasut
Quoted 4 lines · sbabic at denx.de
Quoted 4 lines
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode.
Quoted 7 lines
Quoted 5 lines
[...]
Quoted 1 line
Applied to u-boot-imx, master, thanks !
Didn't this fail to build on mx25 ?
Yes, sorry, this is a false positive - patch has not been applied.
Anyway, as there will be another solution that won't break mx25/mx35, I should retest the new patch version on apalis, so I'm calling off my review so far.
Quoted 2 lines
Regards,
Stefano
Signature · 4 lines
Best regards Oleksandr Suvorov cryosay at gmail.com
PATCH 1/1 net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY
Quoted 15 lines · Oleksandr Suvorov
Quoted 14 lines · Stefano Babic
Hi Marek,
Quoted 10 lines · Marek Vasut
Quoted 4 lines · sbabic at denx.de
Quoted 4 lines
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode.
[...]
Quoted 1 line
Applied to u-boot-imx, master, thanks !
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Didn't this fail to build on mx25 ?
Yes, sorry, this is a false positive - patch has not been applied.
Anyway, as there will be another solution that won't break mx25/mx35, I should retest the new patch version on apalis, so I'm calling off my review so far.
The only change required to that patch is an extra ifdef DM_ETH, so for mx8 apalis nothing changed, since you have DM_ETH enabled.
PATCH 1/1 net: fec: Get rid of FEC_ENET_ENABLE_[TR]XC_DELAY
Hi Marek,
Quoted 19 lines · Marek Vasut
Quoted 17 lines · Oleksandr Suvorov
Quoted 16 lines · Stefano Babic
Hi Marek,
Quoted 11 lines · Marek Vasut
Quoted 4 lines · sbabic at denx.de
Quoted 4 lines
The FEC_ENET_ENABLE_.XC_DELAY setting is only used by one system which supports OF control, correctly set the rgmii-id PHY mode in the DT and then determine whether or not to enable the FEC RXC/TXC internal delay based on the PHY mode.
[...]
Quoted 1 line
Applied to u-boot-imx, master, thanks !
Didn't this fail to build on mx25 ?
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Yes, sorry, this is a false positive - patch has not been applied.
Anyway, as there will be another solution that won't break mx25/mx35, I should retest the new patch version on apalis, so I'm calling off my review so far.
The only change required to that patch is an extra ifdef
DM_ETH, so for mx8 apalis nothing changed, since you haveDM_ETHenabled.
Thanks for clarifying! So you have my review for apalis mx8.
Signature · 4 lines
Best regards Oleksandr Suvorov cryosay at gmail.com