ACPI: thermal: Adjust critical.flags.valid check

PATCH New Rafael J. Wysocki 1 participant 1 message Dec 5, 2022

Subsystems (2)

ACPI ACPI thermal driver

lore

Share & tools

lore

Rafael J. Wysocki

author

2022-12-05 18:56 UTC #0 lore raw

PATCH 1/1 ACPI: thermal: Adjust critical.flags.valid check

From: Rafael J. Wysocki <[email protected]>

It is not necessary to compare critical.flags.valid to 1 in acpi_thermal_trips_update() and doing so is also inconsistent with other similar checks in that code, so simply check if the flag is not 0 instead.

No expected functional impact.

Signed-off-by Rafael J. Wysocki <[email protected]>

---
 drivers/acpi/thermal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/acpi/thermal.c +1 -1

Index: linux-pm/drivers/acpi/thermal.c
===================================================================
@@ -291,7 +291,7 @@ static int acpi_thermal_trips_update(str
 					  "Found critical threshold [%lu]\n",
 					  tz->trips.critical.temperature);
 		}
-		if (tz->trips.critical.flags.valid == 1) {
+		if (tz->trips.critical.flags.valid) {
 			if (crt == -1) {
 				tz->trips.critical.flags.valid = 0;
 			} else if (crt > 0) {