Skip to contentSkip to conversation

ocfs2: cleanup unused func declaration and assignment

PATCH New piaojun 3 participants 3 messages Oct 13, 2017 OCFS2

lore
Share & tools
lore

piaojun

author
#0 lore raw

PATCH 2/2 ocfs2: cleanup unused func declaration and assignment

Signed-off-by Jun Piao <[email protected]>
---
 fs/ocfs2/alloc.c             | 2 --
 fs/ocfs2/cluster/heartbeat.h | 2 --
 2 files changed, 4 deletions(-)
fs/ocfs2/alloc.c +0 -2
index a177eae..31a416d 100644
@@ -3585,8 +3585,6 @@ static int ocfs2_merge_rec_left(struct ocfs2_path *right_path,
 		 * The easy case - we can just plop the record right in.
 		 */
 		*left_rec = *split_rec;
-
-		has_empty_extent = 0;
 	} else
 		le16_add_cpu(&left_rec->e_leaf_clusters, split_clusters);
fs/ocfs2/cluster/heartbeat.h +0 -2
index 3ef5137..a9e67ef 100644
@@ -79,10 +79,8 @@ void o2hb_fill_node_map(unsigned long *map,
 			unsigned bytes);
 void o2hb_exit(void);
 int o2hb_init(void);
-int o2hb_check_node_heartbeating(u8 node_num);
 int o2hb_check_node_heartbeating_no_sem(u8 node_num);
 int o2hb_check_node_heartbeating_from_callback(u8 node_num);
-int o2hb_check_local_node_heartbeating(void);
 void o2hb_stop_all_regions(void);
 int o2hb_get_all_regions(char *region_uuids, u8 numregions);
 int o2hb_global_heartbeat_active(void);
#1 lore raw

PATCH 2/2 ocfs2: cleanup unused func declaration and assignment

Look good, but hope you can add more comments in the patch description.

Reviewed-by Gang He <[email protected]>

Thanks
Gang

Quoted 42 lines
Quoted 1 line
Quoted 1 line
Signed-off-by Jun Piao <[email protected]>
---
 fs/ocfs2/alloc.c             | 2 --
 fs/ocfs2/cluster/heartbeat.h | 2 --
 2 files changed, 4 deletions(-)
fs/ocfs2/alloc.c +0 -2
index a177eae..31a416d 100644
@@ -3585,8 +3585,6 @@ static int ocfs2_merge_rec_left(struct ocfs2_path 
 *right_path,
 		 * The easy case - we can just plop the record right in.
 		 */
 		*left_rec = *split_rec;
-
-		has_empty_extent = 0;
 	} else
 		le16_add_cpu(&left_rec->e_leaf_clusters, split_clusters);
fs/ocfs2/cluster/heartbeat.h +0 -2
index 3ef5137..a9e67ef 100644
@@ -79,10 +79,8 @@ void o2hb_fill_node_map(unsigned long *map,
 			unsigned bytes);
 void o2hb_exit(void);
 int o2hb_init(void);
-int o2hb_check_node_heartbeating(u8 node_num);
 int o2hb_check_node_heartbeating_no_sem(u8 node_num);
 int o2hb_check_node_heartbeating_from_callback(u8 node_num);
-int o2hb_check_local_node_heartbeating(void);
 void o2hb_stop_all_regions(void);
 int o2hb_get_all_regions(char *region_uuids, u8 numregions);
 int o2hb_global_heartbeat_active(void);
Signature · 4 lines
_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel at oss.oracle.com 
https://oss.oracle.com/mailman/listinfo/ocfs2-devel
#2 lore raw

PATCH 2/2 ocfs2: cleanup unused func declaration and assignment

In reply to piaojun
Quoted 1 line · piaojun
Signed-off-by Jun Piao <[email protected]>
Reviewed-by Joseph Qi <[email protected]>
Quoted 34 lines
---
 fs/ocfs2/alloc.c             | 2 --
 fs/ocfs2/cluster/heartbeat.h | 2 --
 2 files changed, 4 deletions(-)
fs/ocfs2/alloc.c +0 -2
index a177eae..31a416d 100644
@@ -3585,8 +3585,6 @@ static int ocfs2_merge_rec_left(struct ocfs2_path *right_path,
 		 * The easy case - we can just plop the record right in.
 		 */
 		*left_rec = *split_rec;
-
-		has_empty_extent = 0;
 	} else
 		le16_add_cpu(&left_rec->e_leaf_clusters, split_clusters);
fs/ocfs2/cluster/heartbeat.h +0 -2
index 3ef5137..a9e67ef 100644
@@ -79,10 +79,8 @@ void o2hb_fill_node_map(unsigned long *map,
 			unsigned bytes);
 void o2hb_exit(void);
 int o2hb_init(void);
-int o2hb_check_node_heartbeating(u8 node_num);
 int o2hb_check_node_heartbeating_no_sem(u8 node_num);
 int o2hb_check_node_heartbeating_from_callback(u8 node_num);
-int o2hb_check_local_node_heartbeating(void);
 void o2hb_stop_all_regions(void);
 int o2hb_get_all_regions(char *region_uuids, u8 numregions);
 int o2hb_global_heartbeat_active(void);