ext4: no need flush workqueue before destroying it

PATCH In review piaojun 1 participant 2 messages Dec 1, 2017 – Dec 4, 2017 ext4 file system

lore

Share & tools

lore

piaojun

author

2017-12-01 07:44 UTC #0 lore raw

PATCH 1/1 ext4: no need flush workqueue before destroying it

destroy_workqueue() will do flushing work for us.

Signed-off-by Jun Piao <[email protected]>

---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)

fs/ext4/super.c +0 -1

index 0556cd0..2f46b0b 100644
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
 	ext4_unregister_li_request(sb);
 	ext4_quota_off_umount(sb);
 
-	flush_workqueue(sbi->rsv_conversion_wq);
 	destroy_workqueue(sbi->rsv_conversion_wq);
 
 	if (sbi->s_journal) {

piaojun

author

2017-12-04 00:43 UTC #1 lore raw

Hi Ted,

Could you help reviewing my patch?

thanks,
Jun

Quoted 20 lines · piaojun

destroy_workqueue() will do flushing work for us.

Signed-off-by Jun Piao <[email protected]>

---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)

fs/ext4/super.c +0 -1

index 0556cd0..2f46b0b 100644
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
 	ext4_unregister_li_request(sb);
 	ext4_quota_off_umount(sb);
 
-	flush_workqueue(sbi->rsv_conversion_wq);
 	destroy_workqueue(sbi->rsv_conversion_wq);
 
 	if (sbi->s_journal) {