Skip to contentSkip to conversation

Regression test failure

DISCUSSION Bruce Dubbs 2 participants 3 messages Dec 19, 2017 – Jan 3, 2018 1 message not in the archive Util-Linux package

lore
Share & tools
lore

Bruce Dubbs

author
#0 lore raw

In version 2.31.1, I had one failure:

fincore: count file contents in core ... FAILED (fincore/count)

1 tests of 200 FAILED

$ cat ./tests/diff/fincore/count
--- /sources/util-linux-2.31.1/tests/expected/fincore/count.4096 2017-09-18 09:48:03.676890826 +0000
+++ /sources/util-linux-2.31.1/tests/output/fincore/count       2017-12-19 20:18:24.410460239 +0000
@@ -13,7 +13,7 @@
 return value: 0
     0  8192 i_TWO_PAGES_directio_
 return value: 0
-    1  8192 i_TWO_PAGES_mixed_directio_incore_
+    2  8192 i_TWO_PAGES_mixed_directio_incore_
 return value: 0
     1  8192 i_TWO_PAGES_mixed_incore_directio_
 return value: 0
@@ -42,7 +42,7 @@
     0      4096 i_JUST_PAGESIZE_directio_
     2      8192 i_TWO_PAGES_incore_
     0      8192 i_TWO_PAGES_directio_
-    1      8192 i_TWO_PAGES_mixed_directio_incore_
+    2      8192 i_TWO_PAGES_mixed_directio_incore_
     1      8192 i_TWO_PAGES_mixed_incore_directio_
     2 134213632 i_WINDOW_SIZE_incore-sparse-incore_
     0 134213632 i_WINDOW_SIZE_directio-sparse-directio_

-----------------------
The system is a fresh LFS build (systemd version):

./configure ADJTIME_PATH=/var/lib/hwclock/adjtime   \
            --docdir=/usr/share/doc/util-linux-2.31 \
            --disable-chfn-chsh  \
            --disable-login      \
            --disable-nologin    \
            --disable-su         \
            --disable-setpriv    \
            --disable-runuser    \
            --disable-pylibmount \
            --disable-static     \
            --without-python

make

chown -Rv nobody .
su nobody -s /bin/bash -c "PATH=$PATH make -k check"

-- Bruce

A message that is not in the archive (sent off-list or not yet received): [email protected]

author
#2 lore raw

The filesystem is ext4, kernel 4.14.6, x86_64.

-- Bruce

Quoted 69 lines · Ruediger Meier
Quoted 3 lines · you

In version 2.31.1, I had one failure:

fincore: count file contents in core ... FAILED (fincore/count)

Which filesystem are you using for the build directory? And which kernel version, architecture?

AFAIR this test is somehow fragile. Maybe we should whitelist this test only for a set of known filesystems with default block sizes etc..

cu,
Rudi

Quoted 52 lines

1 tests of 200 FAILED

$ cat ./tests/diff/fincore/count
--- /sources/util-linux-2.31.1/tests/expected/fincore/count.4096
2017-09-18 09:48:03.676890826 +0000
+++ /sources/util-linux-2.31.1/tests/output/fincore/count
2017-12-19 20:18:24.410460239 +0000
(quoted diff) +2 -3
@@ -13,7 +13,7 @@
   return value: 0
       0  8192 i_TWO_PAGES_directio_
   return value: 0
-    1  8192 i_TWO_PAGES_mixed_directio_incore_
+    2  8192 i_TWO_PAGES_mixed_directio_incore_
   return value: 0
       1  8192 i_TWO_PAGES_mixed_incore_directio_
   return value: 0

@@ -42,7 +42,7 @@
       0      4096 i_JUST_PAGESIZE_directio_
       2      8192 i_TWO_PAGES_incore_
       0      8192 i_TWO_PAGES_directio_
-    1      8192 i_TWO_PAGES_mixed_directio_incore_
+    2      8192 i_TWO_PAGES_mixed_directio_incore_
       1      8192 i_TWO_PAGES_mixed_incore_directio_
       2 134213632 i_WINDOW_SIZE_incore-sparse-incore_
       0 134213632 i_WINDOW_SIZE_directio-sparse-directio_
 
-----------------------

The system is a fresh LFS build (systemd version):

./configure ADJTIME_PATH=/var/lib/hwclock/adjtime   \
              --docdir=/usr/share/doc/util-linux-2.31 \
              --disable-chfn-chsh  \
              --disable-login      \
              --disable-nologin    \
              --disable-su         \
              --disable-setpriv    \
              --disable-runuser    \
              --disable-pylibmount \
              --disable-static     \
              --without-python

make

chown -Rv nobody .
su nobody -s /bin/bash -c "PATH=$PATH make -k check"

-- Bruce
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#3 lore raw
In reply to Bruce Dubbs
Quoted 21 lines · Bruce Dubbs

In version 2.31.1, I had one failure:

fincore: count file contents in core ... FAILED (fincore/count)

1 tests of 200 FAILED

$ cat ./tests/diff/fincore/count
--- /sources/util-linux-2.31.1/tests/expected/fincore/count.4096 2017-09-18
09:48:03.676890826 +0000
+++ /sources/util-linux-2.31.1/tests/output/fincore/count       2017-12-19
20:18:24.410460239 +0000
(quoted diff) +1 -1
@@ -13,7 +13,7 @@
 return value: 0
     0  8192 i_TWO_PAGES_directio_
 return value: 0
-    1  8192 i_TWO_PAGES_mixed_directio_incore_
+    2  8192 i_TWO_PAGES_mixed_directio_incore_
 return value: 0
     1  8192 i_TWO_PAGES_mixed_incore_directio_
 return value: 0

Review line 48

Quoted 8 lines
(quoted diff) +1 -1
@@ -42,7 +42,7 @@
     0      4096 i_JUST_PAGESIZE_directio_
     2      8192 i_TWO_PAGES_incore_
     0      8192 i_TWO_PAGES_directio_
-    1      8192 i_TWO_PAGES_mixed_directio_incore_
+    2      8192 i_TWO_PAGES_mixed_directio_incore_
     1      8192 i_TWO_PAGES_mixed_incore_directio_
     2 134213632 i_WINDOW_SIZE_incore-sparse-incore_
     0 134213632 i_WINDOW_SIZE_directio-sparse-directio_

Frankly, this test seems pretty unstable. I'll probably mark it as KNOWN_FAIL.

Karel

Signature · 2 lines
 Karel Zak  <[email protected]>
 http://karelzak.blogspot.com