Skip to contentSkip to conversation

ext4: no need flush workqueue before destroying it

PATCH Applied piaojun 3 participants 4 messages Jan 9, 2018 – Jan 10, 2018 ext4 file system

lore
Share & tools
lore

piaojun

author
#0 lore raw

PATCH 1/1 ext4: no need flush workqueue before destroying it

destroy_workqueue() will do flushing work for us.

Signed-off-by Jun Piao <[email protected]>
---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)
fs/ext4/super.c +0 -1
index 0556cd0..2f46b0b 100644
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
 	ext4_unregister_li_request(sb);
 	ext4_quota_off_umount(sb);
 
-	flush_workqueue(sbi->rsv_conversion_wq);
 	destroy_workqueue(sbi->rsv_conversion_wq);
 
 	if (sbi->s_journal) {
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · piaojun

destroy_workqueue() will do flushing work for us.

Signed-off-by Jun Piao <[email protected]>

Looks good. You can add:

Reviewed-by Jan Kara <[email protected]>

Adding Ted to CC as a maintainer...

Honza

Quoted 17 lines
---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)
fs/ext4/super.c +0 -1
index 0556cd0..2f46b0b 100644
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
 	ext4_unregister_li_request(sb);
 	ext4_quota_off_umount(sb);
 
-	flush_workqueue(sbi->rsv_conversion_wq);
 	destroy_workqueue(sbi->rsv_conversion_wq);
 
 	if (sbi->s_journal) {
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR
author
#2 lore raw

Hi Jan,

Thanks for reviewing, and I will resend this patch again.

thanks,
Jun

Quoted 30 lines · Jan Kara
Quoted 3 lines · piaojun

destroy_workqueue() will do flushing work for us.

Signed-off-by Jun Piao <[email protected]>

Looks good. You can add:

Reviewed-by Jan Kara <[email protected]>

Adding Ted to CC as a maintainer...

Honza

Quoted 17 lines
---
 fs/ext4/super.c | 1 -
 1 file changed, 1 deletion(-)
fs/ext4/super.c +0 -1
index 0556cd0..2f46b0b 100644
@@ -870,7 +870,6 @@ static void ext4_put_super(struct super_block *sb)
 	ext4_unregister_li_request(sb);
 	ext4_quota_off_umount(sb);
 
-	flush_workqueue(sbi->rsv_conversion_wq);
 	destroy_workqueue(sbi->rsv_conversion_wq);
 
 	if (sbi->s_journal) {
maintainer Applied
#3 lore raw
Quoted 10 lines · piaojun
Quoted 8 lines · Jan Kara
Quoted 3 lines · piaojun

destroy_workqueue() will do flushing work for us.

Signed-off-by Jun Piao <[email protected]>

Looks good. You can add:

Reviewed-by Jan Kara <[email protected]>

Thanks, applied. (Note, you don't have resend the patch after it's been reviewed; I can append the Reviewed-by line.)

- Ted