Skip to contentSkip to conversation

fs/9p: don't set SB_NOATIME by default

PATCH In review jiangyiwen 2 participants 4 messages Feb 9, 2018 – Feb 26, 2018

Subsystems (2)
lore
Share & tools
lore

jiangyiwen

author
#0 lore raw

PATCH 1/1 fs/9p: don't set SB_NOATIME by default

User use some syscall, for example mmap(v9fs_file_mmap), it will not update atime even if user's mnt_flags have MNT_NOATIME, because v9fs default set SB_NOATIME in v9fs_set_super.

For supporting access time is updated when user mount with relatime, we should clear SB_NOATIME by default.

---
 fs/9p/vfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/9p/vfs_super.c +1 -1
index af03c2a..48ce504 100644
@@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data)
 	if (v9ses->cache)
 		sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE;
 
-	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME;
+	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC;
 	if (!v9ses->cache)
 		sb->s_flags |= SB_SYNCHRONOUS;
 
Signature · 1 line
1.8.3.1
author
#1 lore raw
Quoted 17 lines · jiangyiwen

User use some syscall, for example mmap(v9fs_file_mmap), it will not update atime even if user's mnt_flags have MNT_NOATIME, because v9fs default set SB_NOATIME in v9fs_set_super.

For supporting access time is updated when user mount with relatime, we should clear SB_NOATIME by default.

---
 fs/9p/vfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/9p/vfs_super.c +0 -0
index af03c2a..48ce504 100644

fs/9p/vfs_super.c static int v9fs_set_super(struct super_block *s, void *data) · line 100

Quoted 8 lines
fs/9p/vfs_super.c +1 -1
@@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data)
 	if (v9ses->cache)
 		sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE;
 
-	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME;
+	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC;
 	if (!v9ses->cache)
 		sb->s_flags |= SB_SYNCHRONOUS;
 

Hi Alexander Viro and Eric,

My patch has already sent two weeks, but nobody help me to review, I have a question about now who is the v9fs's maintainer? Or who can help me review the patch?

I hope v9fs's maintainer can give me some advices or merge into the mainline if it has no problem.

Thanks,
Yiwen.

author
#2 lore raw
Quoted 32 lines · jiangyiwen
Quoted 17 lines · jiangyiwen

User use some syscall, for example mmap(v9fs_file_mmap), it will not update atime even if user's mnt_flags have MNT_NOATIME, because v9fs default set SB_NOATIME in v9fs_set_super.

For supporting access time is updated when user mount with relatime, we should clear SB_NOATIME by default.

---
 fs/9p/vfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/9p/vfs_super.c +0 -0
index af03c2a..48ce504 100644

fs/9p/vfs_super.c static int v9fs_set_super(struct super_block *s, void *data) · line 100

Quoted 8 lines
fs/9p/vfs_super.c +1 -1
@@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data)
 	if (v9ses->cache)
 		sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE;
 
-	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME;
+	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC;
 	if (!v9ses->cache)
 		sb->s_flags |= SB_SYNCHRONOUS;
 

Hi Alexander Viro and Eric,

My patch has already sent two weeks, but nobody help me to review, I have a question about now who is the v9fs's maintainer? Or who can help me review the patch?

Quoted 6 lines

I hope v9fs's maintainer can give me some advices or merge into the mainline if it has no problem.

Thanks,
Yiwen.

Hi Andrew,

My patch has already sent more than two weeks, but nobody help me to review, I have a question about now who is the v9fs's maintainer? Or who can help me review the patch?

I hope v9fs's maintainer can give me some advices or merge into the mainline if it has no problem.

Thanks,
Yiwen.

#3 lore raw

Hi,
I think you would better to modify the subject line without [V9fs-developers].

Quoted 36 lines · jiangyiwen
Quoted 35 lines · jiangyiwen
Quoted 17 lines · jiangyiwen

User use some syscall, for example mmap(v9fs_file_mmap), it will not update atime even if user's mnt_flags have MNT_NOATIME, because v9fs default set SB_NOATIME in v9fs_set_super.

For supporting access time is updated when user mount with relatime, we should clear SB_NOATIME by default.

---
 fs/9p/vfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/9p/vfs_super.c +0 -0
index af03c2a..48ce504 100644

fs/9p/vfs_super.c static int v9fs_set_super(struct super_block *s, void *data) · line 100

Quoted 8 lines
fs/9p/vfs_super.c +1 -1
@@ -94,7 +94,7 @@ static int v9fs_set_super(struct super_block *s, void *data)
 	if (v9ses->cache)
 		sb->s_bdi->ra_pages = (VM_MAX_READAHEAD * 1024)/PAGE_SIZE;
 
-	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC | SB_NOATIME;
+	sb->s_flags |= SB_ACTIVE | SB_DIRSYNC;
 	if (!v9ses->cache)
 		sb->s_flags |= SB_SYNCHRONOUS;
 

Hi Alexander Viro and Eric,

My patch has already sent two weeks, but nobody help me to review, I have a question about now who is the v9fs's maintainer? Or who can help me review the patch?

I hope v9fs's maintainer can give me some advices or merge into the mainline if it has no problem.

Quoted 9 lines
Quoted 3 lines

Thanks,
Yiwen.

Hi Andrew,

My patch has already sent more than two weeks, but nobody help me to review, I have a question about now who is the v9fs's maintainer? Or who can help me review the patch?

There is no maintainer with V9fs in get_maintain.pl and V9fs git tree laterest commit before two years.so,situation become bad. Maybe you eamil linus directly,although this is't good

Quoted 10 lines

I hope v9fs's maintainer can give me some advices or merge into the mainline if it has no problem.

Thanks,
Yiwen.

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html