x86: fix {pmd,pud}_{set,clear}_flags()
Quoted 8 lines · Jan Beulich
Just like pte_{set,clear}_flags() their PMD and PUD counterparts should not do any address translation. This was outright wrong under Xen (causing a dead boot with no useful output on "suitable" systems), and produced needlessly more complicated code (even if just slightly) when paravirt was enabled.
Signed-off-by Jan Beulich <[email protected]>
While the changes look alright I'm really curious which kind of failure you are seeing, especially considering how long those functions haven't been changed (since more than 6 years).
Juergen
Quoted 8 lines
Quoted 1 line
Quoted 1 line · On 19.02.18 at 17:23, <[email protected]> wrote:
Quoted 6 lines · Jan Beulich
Just like pte_{set,clear}_flags() their PMD and PUD counterparts should not do any address translation. This was outright wrong under Xen (causing a dead boot with no useful output on "suitable" systems), and produced needlessly more complicated code (even if just slightly) when paravirt was enabled.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Jan Beulich <[email protected]>While the changes look alright I'm really curious which kind of failure you are seeing, especially considering how long those functions haven't been changed (since more than 6 years).
It's the new use of pmd_set_flags() in 2cc42bac1c ("x86-64/Xen:
eliminate W+X mappings"), and due to the (very odd afaic) identity map handling the issue is invisible on most systems/setups.
Jan
Juergen Gross
Reviewed-byQuoted 11 lines · Jan Beulich
Quoted 11 lines
Quoted 1 line
Quoted 1 line · On 19.02.18 at 17:23, <[email protected]> wrote:
Quoted 8 lines · Jan Beulich
Just like pte_{set,clear}_flags() their PMD and PUD counterparts should not do any address translation. This was outright wrong under Xen (causing a dead boot with no useful output on "suitable" systems), and produced needlessly more complicated code (even if just slightly) when paravirt was enabled.
Signed-off-by Jan Beulich <[email protected]>
Quoted 7 lines
Quoted 3 lines
While the changes look alright I'm really curious which kind of failure you are seeing, especially considering how long those functions haven't been changed (since more than 6 years).
It's the new use of
pmd_set_flags()in2cc42bac1c("x86-64/Xen:
eliminate W+X mappings"), and due to the (very odd afaic) identity map handling the issue is invisible on most systems/setups.
Aah, okay. This helps.
Juergen